提交 5933048c 编写于 作者: R Rusty Russell

module: cleanup FIXME comments about trimming exception table entries.

Everyone cut and paste this comment from my original one.  We now do
it generically, so cut the comments.
Signed-off-by: NRusty Russell <rusty@rustcorp.com.au>
Cc: Amerigo Wang <amwang@redhat.com>
上级 ad6561df
...@@ -32,8 +32,6 @@ void module_free(struct module *mod, void *module_region) ...@@ -32,8 +32,6 @@ void module_free(struct module *mod, void *module_region)
mod->arch.syminfo = NULL; mod->arch.syminfo = NULL;
vfree(module_region); vfree(module_region);
/* FIXME: if module_region == mod->init_region, trim exception
* table entries. */
} }
static inline int check_rela(Elf32_Rela *rela, struct module *module, static inline int check_rela(Elf32_Rela *rela, struct module *module,
......
...@@ -48,8 +48,6 @@ void *module_alloc(unsigned long size) ...@@ -48,8 +48,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region) void module_free(struct module *mod, void *module_region)
{ {
FREE_MODULE(module_region); FREE_MODULE(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
} }
/* We don't need anything special. */ /* We don't need anything special. */
......
...@@ -35,8 +35,6 @@ void *module_alloc(unsigned long size) ...@@ -35,8 +35,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region) void module_free(struct module *mod, void *module_region)
{ {
vfree(module_region); vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
} }
/* We don't need anything special. */ /* We don't need anything special. */
......
...@@ -23,8 +23,6 @@ void *module_alloc(unsigned long size) ...@@ -23,8 +23,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region) void module_free(struct module *mod, void *module_region)
{ {
vfree(module_region); vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
} }
/* We don't need anything special. */ /* We don't need anything special. */
......
...@@ -44,8 +44,6 @@ void *module_alloc(unsigned long size) ...@@ -44,8 +44,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region) void module_free(struct module *mod, void *module_region)
{ {
vfree(module_region); vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
} }
/* We don't need anything special. */ /* We don't need anything special. */
......
...@@ -31,8 +31,6 @@ void *module_alloc(unsigned long size) ...@@ -31,8 +31,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region) void module_free(struct module *mod, void *module_region)
{ {
vfree(module_region); vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
} }
/* We don't need anything special. */ /* We don't need anything special. */
......
...@@ -23,8 +23,6 @@ void *module_alloc(unsigned long size) ...@@ -23,8 +23,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region) void module_free(struct module *mod, void *module_region)
{ {
vfree(module_region); vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
} }
/* We don't need anything special. */ /* We don't need anything special. */
......
...@@ -68,8 +68,6 @@ void *module_alloc(unsigned long size) ...@@ -68,8 +68,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region) void module_free(struct module *mod, void *module_region)
{ {
vfree(module_region); vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
} }
int module_frob_arch_sections(Elf_Ehdr *hdr, Elf_Shdr *sechdrs, int module_frob_arch_sections(Elf_Ehdr *hdr, Elf_Shdr *sechdrs,
......
...@@ -48,8 +48,6 @@ void *module_alloc(unsigned long size) ...@@ -48,8 +48,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region) void module_free(struct module *mod, void *module_region)
{ {
vfree(module_region); vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
* table entries. */
} }
/* /*
......
...@@ -267,8 +267,6 @@ void module_free(struct module *mod, void *module_region) ...@@ -267,8 +267,6 @@ void module_free(struct module *mod, void *module_region)
mod->arch.section = NULL; mod->arch.section = NULL;
vfree(module_region); vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
} }
/* Additional bytes needed in front of individual sections */ /* Additional bytes needed in front of individual sections */
......
...@@ -43,8 +43,6 @@ void *module_alloc(unsigned long size) ...@@ -43,8 +43,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region) void module_free(struct module *mod, void *module_region)
{ {
vfree(module_region); vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
} }
static const Elf_Shdr *find_section(const Elf_Ehdr *hdr, static const Elf_Shdr *find_section(const Elf_Ehdr *hdr,
......
...@@ -56,8 +56,6 @@ void *module_alloc(unsigned long size) ...@@ -56,8 +56,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region) void module_free(struct module *mod, void *module_region)
{ {
vfree(module_region); vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
} }
static void static void
......
...@@ -46,8 +46,6 @@ void *module_alloc(unsigned long size) ...@@ -46,8 +46,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region) void module_free(struct module *mod, void *module_region)
{ {
vfree(module_region); vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
} }
/* We don't need anything special. */ /* We don't need anything special. */
......
...@@ -75,8 +75,6 @@ void *module_alloc(unsigned long size) ...@@ -75,8 +75,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region) void module_free(struct module *mod, void *module_region)
{ {
vfree(module_region); vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
} }
/* Make generic code ignore STT_REGISTER dummy undefined symbols. */ /* Make generic code ignore STT_REGISTER dummy undefined symbols. */
......
...@@ -56,8 +56,6 @@ void *module_alloc(unsigned long size) ...@@ -56,8 +56,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region) void module_free(struct module *mod, void *module_region)
{ {
vfree(module_region); vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
} }
/* We don't need anything special. */ /* We don't need anything special. */
......
...@@ -34,8 +34,6 @@ void *module_alloc(unsigned long size) ...@@ -34,8 +34,6 @@ void *module_alloc(unsigned long size)
void module_free(struct module *mod, void *module_region) void module_free(struct module *mod, void *module_region)
{ {
vfree(module_region); vfree(module_region);
/* FIXME: If module_region == mod->init_region, trim exception
table entries. */
} }
int module_frob_arch_sections(Elf32_Ehdr *hdr, int module_frob_arch_sections(Elf32_Ehdr *hdr,
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册