• A
    tty: serial: fsl_lpuart: Drop unnecessary lpuart*_stop_tx() · 8a9b8242
    Andrey Smirnov 提交于
    By the time lpuart_shutdown() calls lpuart_stop_tx() UARTCR2_TE and
    UARTCR2_TIE (which the latter will clear) are already cleared, so that
    function call should effectively be a no-op. Moreso, lpuart_stop_tx()
    is expected to be executed with port spinlock held, which the caller
    doesn't. Given all that, drop the call to lpuart_stop_tx() in
    lpuart_shutdown().
    
    In case of lpuart32_shutdown()/lpuart32_stop_tx(), TIE won't even be
    set if lpuart_dma_tx_use is true. Drop it there as well.
    Signed-off-by: NAndrey Smirnov <andrew.smirnov@gmail.com>
    Cc: Stefan Agner <stefan@agner.ch>
    Cc: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
    Cc: Chris Healy <cphealy@gmail.com>
    Cc: Cory Tusar <cory.tusar@zii.aero>
    Cc: Lucas Stach <l.stach@pengutronix.de>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Jiri Slaby <jslaby@suse.com>
    Cc: linux-imx@nxp.com
    Cc: linux-serial@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    Link: https://lore.kernel.org/r/20190729195226.8862-18-andrew.smirnov@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    8a9b8242
fsl_lpuart.c 68.5 KB