diff --git a/modules/java/android_lib/lint.xml b/modules/java/android_lib/lint.xml index e54ced1dc4889c551aab72ed2beb210998b07f98..a95e509d22c5d3fd87497d0bd0ce92d709ef325b 100644 --- a/modules/java/android_lib/lint.xml +++ b/modules/java/android_lib/lint.xml @@ -1,5 +1,8 @@ + + + diff --git a/modules/java/generator/src/java/android+CameraBridgeViewBase.java b/modules/java/generator/src/java/android+CameraBridgeViewBase.java index 36417c5829331dc30af534c38181589bff5020ca..5ec9b12fdd04adbdf431165eb0075946655c3ac4 100644 --- a/modules/java/generator/src/java/android+CameraBridgeViewBase.java +++ b/modules/java/generator/src/java/android+CameraBridgeViewBase.java @@ -74,6 +74,7 @@ public abstract class CameraBridgeViewBase extends SurfaceView implements Surfac getHolder().addCallback(this); mMaxWidth = MAX_UNSPECIFIED; mMaxHeight = MAX_UNSPECIFIED; + styledAttrs.recycle(); } public interface CvCameraViewListener { @@ -155,8 +156,6 @@ public abstract class CameraBridgeViewBase extends SurfaceView implements Surfac mPreviewFormat = format; } - private CvCameraViewListenerAdapter() {} - private int mPreviewFormat = Highgui.CV_CAP_ANDROID_COLOR_FRAME_RGBA; private CvCameraViewListener mOldStyleListener; }; diff --git a/modules/java/generator/src/java/android+JavaCameraView.java b/modules/java/generator/src/java/android+JavaCameraView.java index f07b7d2ca82fc665a3baf7857fd3d00a69b455fc..f0036ef0290e7960c72b67cc26764b7fab131998 100644 --- a/modules/java/generator/src/java/android+JavaCameraView.java +++ b/modules/java/generator/src/java/android+JavaCameraView.java @@ -267,9 +267,6 @@ public class JavaCameraView extends CameraBridgeViewBase implements PreviewCallb mRgba.release(); } - private JavaCameraFrame(CvCameraViewFrame obj) { - } - private Mat mYuvFrameData; private Mat mRgba; private int mWidth; diff --git a/modules/java/generator/src/java/android+NativeCameraView.java b/modules/java/generator/src/java/android+NativeCameraView.java index 496ed53d6e736d3cb9315dee964c4ad40d55ee3b..6f3ab265cb820a8f07535fd5bf953ed1e0be73e6 100644 --- a/modules/java/generator/src/java/android+NativeCameraView.java +++ b/modules/java/generator/src/java/android+NativeCameraView.java @@ -131,17 +131,17 @@ public class NativeCameraView extends CameraBridgeViewBase { } } - private class NativeCameraFrame implements CvCameraViewFrame { + private static class NativeCameraFrame implements CvCameraViewFrame { @Override public Mat rgba() { - mCamera.retrieve(mRgba, Highgui.CV_CAP_ANDROID_COLOR_FRAME_RGBA); + mCapture.retrieve(mRgba, Highgui.CV_CAP_ANDROID_COLOR_FRAME_RGBA); return mRgba; } @Override public Mat gray() { - mCamera.retrieve(mGray, Highgui.CV_CAP_ANDROID_GREY_FRAME); + mCapture.retrieve(mGray, Highgui.CV_CAP_ANDROID_GREY_FRAME); return mGray; } @@ -158,9 +158,6 @@ public class NativeCameraView extends CameraBridgeViewBase { private class CameraWorker implements Runnable { - private Mat mRgba = new Mat(); - private Mat mGray = new Mat(); - public void run() { do { if (!mCamera.grab()) { diff --git a/samples/android/native-activity/src/org/opencv/samples/NativeActivity/CvNativeActivity.java b/samples/android/native-activity/src/org/opencv/samples/NativeActivity/CvNativeActivity.java index d8e437533e8d3a8963222de282a10d8a38f8678b..1a9302b1d5dff070e9a1d3f863ef473628d1f3ad 100644 --- a/samples/android/native-activity/src/org/opencv/samples/NativeActivity/CvNativeActivity.java +++ b/samples/android/native-activity/src/org/opencv/samples/NativeActivity/CvNativeActivity.java @@ -6,7 +6,6 @@ import org.opencv.android.OpenCVLoader; import android.app.Activity; import android.content.Intent; -import android.os.Bundle; import android.util.Log; public class CvNativeActivity extends Activity { diff --git a/samples/android/tutorial-1-camerapreview/res/layout/tutorial1_surface_view.xml b/samples/android/tutorial-1-camerapreview/res/layout/tutorial1_surface_view.xml index 52b9dfaf6e9b0a90a518e8be5e2412dd27b845d7..40f5f4932624d5c7fa878487fbc943c8e529df6c 100644 --- a/samples/android/tutorial-1-camerapreview/res/layout/tutorial1_surface_view.xml +++ b/samples/android/tutorial-1-camerapreview/res/layout/tutorial1_surface_view.xml @@ -1,4 +1,4 @@ - - +