From ebc3eba43c1959c0be60886e5616718f88e70c9d Mon Sep 17 00:00:00 2001 From: Zhenghua Lyu Date: Thu, 28 Mar 2019 11:06:22 +0800 Subject: [PATCH] Remove useless FIXME in InitPlan BuildPartitionNodeFromRoot will always use root relid no matter what parameter is passed to it. There is an optimization we might do: for some cases, like if user directly insert into a child partition, then set estate->es_result_partitions to NULL to avoid dispatch it since a huge partition table's partition info may cost much memory. We can spike this later. --- src/backend/executor/execMain.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/backend/executor/execMain.c b/src/backend/executor/execMain.c index d3b9f1b090..791d4bd308 100644 --- a/src/backend/executor/execMain.c +++ b/src/backend/executor/execMain.c @@ -1747,7 +1747,6 @@ InitPlan(QueryDesc *queryDesc, int eflags) containRoot = true; } - /* FIXME: does relid here have to be the root's OID? */ estate->es_result_partitions = BuildPartitionNodeFromRoot(relid); /* -- GitLab