From e5c86775f5e0161239395c23cc41a219c4490853 Mon Sep 17 00:00:00 2001
From: Hubert Zhang <hzhang@pivotal.io>
Date: Wed, 29 Jul 2020 07:40:52 +0000
Subject: [PATCH] Coverity: Variable unused

Remove unused varaible.
For tuplesort.h, we doesn't support mksort based cluster,
so we should just set is_mk_tuplesortstate to false
---
 src/backend/access/external/external.c | 4 ----
 src/backend/commands/exttablecmds.c    | 4 ----
 src/include/utils/tuplesort.h          | 1 -
 3 files changed, 9 deletions(-)

diff --git a/src/backend/access/external/external.c b/src/backend/access/external/external.c
index 0d8e16975b..5949e116bc 100644
--- a/src/backend/access/external/external.c
+++ b/src/backend/access/external/external.c
@@ -773,7 +773,6 @@ create_external_scan_uri_list(ExtTableEntry *ext, bool *ismasteronly)
 
 				uri = ParseExternalTableUri(uri_str);
 
-				found_candidate = false;
 				found_match = false;
 
 				/*
@@ -804,9 +803,6 @@ create_external_scan_uri_list(ExtTableEntry *ext, bool *ismasteronly)
 								continue;	/* skip it */
 						}
 
-						/* a valid primary segdb exist on this host */
-						found_candidate = true;
-
 						if (segdb_file_map[segind] == NULL)
 						{
 							/* segdb not taken yet. assign this URI to this segdb */
diff --git a/src/backend/commands/exttablecmds.c b/src/backend/commands/exttablecmds.c
index 80e8df1f94..e0b26c43b2 100644
--- a/src/backend/commands/exttablecmds.c
+++ b/src/backend/commands/exttablecmds.c
@@ -88,7 +88,6 @@ DefineExternalRelation(CreateExternalStmt *createExtStmt)
 	char	   *locationUris = NULL;
 	char	   *locationExec = NULL;
 	char	   *commandString = NULL;
-	char	   *customProtName = NULL;
 	char		rejectlimittype = '\0';
 	char		formattype;
 	int			rejectlimit = -1;
@@ -329,9 +328,6 @@ DefineExternalRelation(CreateExternalStmt *createExtStmt)
 									GetAssignedOidsForDispatch(),
 									NULL);
 	}
-
-	if (customProtName)
-		pfree(customProtName);
 }
 
 /*
diff --git a/src/include/utils/tuplesort.h b/src/include/utils/tuplesort.h
index a3bf080137..d7d74b1d62 100644
--- a/src/include/utils/tuplesort.h
+++ b/src/include/utils/tuplesort.h
@@ -288,7 +288,6 @@ switcheroo_tuplesort_begin_cluster(TupleDesc tupDesc,
 			tuplesort_begin_cluster_pg(tupDesc, indexRel,
 									   workMem, randomAccess);
 	}
-	state->is_mk_tuplesortstate = gp_enable_mk_sort;
 	state->is_mk_tuplesortstate = false;
 	return state;
 }
-- 
GitLab