From c7ebc7b0398b167b8be581d3043aaaa0bfbc885e Mon Sep 17 00:00:00 2001 From: Jesse Zhang Date: Mon, 27 Feb 2017 15:44:28 -0800 Subject: [PATCH] Hard code to PST8 [#140373273] We cannot assume we are running in a special environment that is always in -8 time zone without DST. Making such setting explicit to make tests portable. Unskipping test as they will succeed now. --- .../functional/sql/changedistpolicy_dml_pttab_timestamptz.sql | 1 - .../sql/changedistpolicy_dml_regtab_random_timestamptz.sql | 1 - .../functional/sql/changedistpolicy_dml_regtab_timestamptz.sql | 1 - .../tincrepo/dml/functional/sql/colalias_dml_timestamptz.sql | 1 - .../tincrepo/dml/functional/sql/dml_boundary_timestamptz.sql | 1 - src/test/tinc/tincrepo/dml/functional/sql/setup/timezone.sql | 1 + 6 files changed, 1 insertion(+), 5 deletions(-) create mode 100644 src/test/tinc/tincrepo/dml/functional/sql/setup/timezone.sql diff --git a/src/test/tinc/tincrepo/dml/functional/sql/changedistpolicy_dml_pttab_timestamptz.sql b/src/test/tinc/tincrepo/dml/functional/sql/changedistpolicy_dml_pttab_timestamptz.sql index e8db5999e2..84ee4e85c3 100644 --- a/src/test/tinc/tincrepo/dml/functional/sql/changedistpolicy_dml_pttab_timestamptz.sql +++ b/src/test/tinc/tincrepo/dml/functional/sql/changedistpolicy_dml_pttab_timestamptz.sql @@ -5,7 +5,6 @@ -- @product_version gpdb: [4.3-] -- @optimizer_mode on -- @description Tests for MPP-21090 --- @skip #140373273 \echo --start_ignore set gp_enable_column_oriented_table=on; \echo --end_ignore diff --git a/src/test/tinc/tincrepo/dml/functional/sql/changedistpolicy_dml_regtab_random_timestamptz.sql b/src/test/tinc/tincrepo/dml/functional/sql/changedistpolicy_dml_regtab_random_timestamptz.sql index 2dd26a6d39..1f3db5682f 100644 --- a/src/test/tinc/tincrepo/dml/functional/sql/changedistpolicy_dml_regtab_random_timestamptz.sql +++ b/src/test/tinc/tincrepo/dml/functional/sql/changedistpolicy_dml_regtab_random_timestamptz.sql @@ -5,7 +5,6 @@ -- @product_version gpdb: [4.3-] -- @optimizer_mode on -- @description Tests for MPP-21090 --- @skip #140373273 \echo --start_ignore set gp_enable_column_oriented_table=on; \echo --end_ignore diff --git a/src/test/tinc/tincrepo/dml/functional/sql/changedistpolicy_dml_regtab_timestamptz.sql b/src/test/tinc/tincrepo/dml/functional/sql/changedistpolicy_dml_regtab_timestamptz.sql index e4e552e55b..836bc59ab8 100644 --- a/src/test/tinc/tincrepo/dml/functional/sql/changedistpolicy_dml_regtab_timestamptz.sql +++ b/src/test/tinc/tincrepo/dml/functional/sql/changedistpolicy_dml_regtab_timestamptz.sql @@ -5,7 +5,6 @@ -- @product_version gpdb: [4.3-] -- @optimizer_mode on -- @description Tests for MPP-21090 --- @skip #140373273 \echo --start_ignore set gp_enable_column_oriented_table=on; \echo --end_ignore diff --git a/src/test/tinc/tincrepo/dml/functional/sql/colalias_dml_timestamptz.sql b/src/test/tinc/tincrepo/dml/functional/sql/colalias_dml_timestamptz.sql index 58e3c9c6e7..b5164f46d3 100644 --- a/src/test/tinc/tincrepo/dml/functional/sql/colalias_dml_timestamptz.sql +++ b/src/test/tinc/tincrepo/dml/functional/sql/colalias_dml_timestamptz.sql @@ -5,7 +5,6 @@ -- @product_version gpdb: [4.3-] -- @optimizer_mode on -- @description Tests for MPP-21090 --- @skip #140373273 \echo --start_ignore set gp_enable_column_oriented_table=on; \echo --end_ignore diff --git a/src/test/tinc/tincrepo/dml/functional/sql/dml_boundary_timestamptz.sql b/src/test/tinc/tincrepo/dml/functional/sql/dml_boundary_timestamptz.sql index 9344ad6009..b59e8fc5af 100644 --- a/src/test/tinc/tincrepo/dml/functional/sql/dml_boundary_timestamptz.sql +++ b/src/test/tinc/tincrepo/dml/functional/sql/dml_boundary_timestamptz.sql @@ -4,7 +4,6 @@ -- @tags dml -- @db_name dmldb -- @description test: Boundary test for timestamptz --- @skip #140373273 \echo --start_ignore set gp_enable_column_oriented_table=on; \echo --end_ignore diff --git a/src/test/tinc/tincrepo/dml/functional/sql/setup/timezone.sql b/src/test/tinc/tincrepo/dml/functional/sql/setup/timezone.sql new file mode 100644 index 0000000000..3d351523c4 --- /dev/null +++ b/src/test/tinc/tincrepo/dml/functional/sql/setup/timezone.sql @@ -0,0 +1 @@ +ALTER DATABASE dmldb SET timezone TO PST8; -- GitLab