From bb32076649755eeb7d2d38a0f1963cbf59cd73db Mon Sep 17 00:00:00 2001 From: Gang Xiong Date: Mon, 26 Oct 2020 18:35:45 +0000 Subject: [PATCH] Remove a fixme of pg12 merge function 'pg_logdir_ls' returns the creation time of log files by parsing the file name, it's different from 'pg_ls_dir_files', we should keep it if we still consider 'pg_logdir_ls' useful. --- src/backend/utils/adt/genfile.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/backend/utils/adt/genfile.c b/src/backend/utils/adt/genfile.c index e88f669609..51514bad83 100644 --- a/src/backend/utils/adt/genfile.c +++ b/src/backend/utils/adt/genfile.c @@ -740,8 +740,9 @@ pg_file_length(PG_FUNCTION_ARGS) /* - * GPDB_12_MERGE_FIXME: Perhaps this function can call into generic function - * pg_ls_dir_files() rather than re-implmenting much of the same pattern. + * This function returns the name and creation time of the log files, the creation + * time is parsed from the file name. It's different from 'pg_ls_dir_files' because + * it returns the modification time of the log files. */ Datum pg_logdir_ls(PG_FUNCTION_ARGS) -- GitLab