Use correct CMAKE build option for debug builds

Previously, we used "DEBUG" (in all caps) in our CI/scripts, which isn't
canonical (https://cmake.org/cmake/help/v3.0/variable/CMAKE_BUILD_TYPE.html).
Authored-by: NChris Hajas <chajas@pivotal.io>

CMakeLists.txt

@@ -6,7 +6,7 @@ project(gpopt LANGUAGES CXX C)
 set(CMAKE_CXX_STANDARD 98)
 set(GPORCA_VERSION_MAJOR 3)
 set(GPORCA_VERSION_MINOR 92)
-set(GPORCA_VERSION_PATCH 1)
+set(GPORCA_VERSION_PATCH 2)
 set(GPORCA_VERSION_STRING "${GPORCA_VERSION_MAJOR}.${GPORCA_VERSION_MINOR}.${GPORCA_VERSION_PATCH}")
 
 # Whenever an ABI-breaking change is made to GPORCA, this should be incremented.

README.md

@@ -219,7 +219,7 @@ Here are a few build flavors (commands run from the ORCA checkout directory):
 
 ```
 # debug build
-cmake -GNinja -D CMAKE_BUILD_TYPE=DEBUG -H. -Bbuild.debug
+cmake -GNinja -D CMAKE_BUILD_TYPE=Debug -H. -Bbuild.debug
 ```
 
 ```

concourse/pipeline.yml

@@ -339,7 +339,7 @@ jobs:
     image: centos5-build
     file: orca_src/concourse/build_and_test.yml
     params:
-      BUILD_TYPE: --build_type=DEBUG
+      BUILD_TYPE: --build_type=Debug
       OUTPUT_DIR: --output_dir=build_and_test/install
       SKIP_TESTS: ''
   - task: package_tarball_debug
@@ -393,7 +393,7 @@ jobs:
     image: centos6-build
     file: orca_src/concourse/build_and_test.yml
     params:
-      BUILD_TYPE: --build_type=DEBUG
+      BUILD_TYPE: --build_type=Debug
       OUTPUT_DIR: --output_dir=build_and_test/install
   - task: package_tarball_debug
     image: centos6-build
@@ -446,7 +446,7 @@ jobs:
     image: centos7-build
     file: orca_src/concourse/build_and_test.yml
     params:
-      BUILD_TYPE: --build_type=DEBUG
+      BUILD_TYPE: --build_type=Debug
       OUTPUT_DIR: --output_dir=build_and_test/install
   - task: package_tarball_debug
     image: centos7-build
@@ -498,7 +498,7 @@ jobs:
   - task: build_and_test_debug
     file: orca_src/concourse/build_and_test.yml
     params:
-      BUILD_TYPE: --build_type=DEBUG
+      BUILD_TYPE: --build_type=Debug
       OUTPUT_DIR: --output_dir=build_and_test/install
       SKIP_TESTS: ""
     image: ubuntu18.04-build

concourse/pr_pipeline.yml

@@ -94,7 +94,7 @@ jobs:
       file: orca_src/concourse/build_and_test.yml
       image: centos5-build
       params:
-        BUILD_TYPE: --build_type=DEBUG
+        BUILD_TYPE: --build_type=Debug
         OUTPUT_DIR: --output_dir=build_and_test/install_debug
       timeout: 30m
     on_failure: &pr_failure

concourse/test_orca_pipeline.yml

@@ -176,7 +176,7 @@ jobs:
   - task: untar_build_and_test_debug
     file: orca_main_src/concourse/untar_build_and_test.yml
     params:
-      BUILD_TYPE: --build_type=DEBUG
+      BUILD_TYPE: --build_type=Debug
       OUTPUT_DIR: --output_dir=build_and_test/install
       SKIP_TESTS: ''
   - in_parallel:

concourse/untar_build_and_test.py

@@ -6,7 +6,7 @@ import sys
 BUILD_TYPE=os.environ['BUILD_TYPE']
 OUTPUT_DIR=os.environ['OUTPUT_DIR']
 SKIP_TESTS=os.environ['SKIP_TESTS']
-if 'DEBUG' in BUILD_TYPE:
+if 'Debug' in BUILD_TYPE:
     path_identifier = 'debug'
 else:
     path_identifier = 'release'