From a8cdedaa9f5a47e9a5f773f03d1b189d4392a531 Mon Sep 17 00:00:00 2001 From: Jialun Du Date: Wed, 27 Feb 2019 16:19:02 +0800 Subject: [PATCH] gpexpand minor fix - Change rollback complete message for online expand needn't restart - fsync the status file write operation to make sure that the data has been sync to disk --- gpMgmt/bin/gpexpand | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gpMgmt/bin/gpexpand b/gpMgmt/bin/gpexpand index df6ef25cb0..274f71f600 100755 --- a/gpMgmt/bin/gpexpand +++ b/gpMgmt/bin/gpexpand @@ -425,8 +425,10 @@ class GpExpandStatus(): self._fp_standby = open(self._status_standby_filename, 'w') self._fp_standby.write('UNINITIALIZED:None\n') self._fp_standby.flush() + os.fsync(self._fp_standby) self._fp.write('UNINITIALIZED:None\n') self._fp.flush() + os.fsync(self._fp) self._status.append('UNINITIALIZED') self._status_info.append('None') except IOError: @@ -463,9 +465,11 @@ class GpExpandStatus(): if self._master_mirror: self._fp_standby.write('%s:%s\n' % (status, status_info)) self._fp_standby.flush() + os.fsync(self._fp_standby) self._sync_status_file() self._fp.write('%s:%s\n' % (status, status_info)) self._fp.flush() + os.fsync(self._fp) self._status.append(status) self._status_info.append(status_info) @@ -2262,7 +2266,7 @@ def main(options, args, parser): logger.error('There is no partially completed setup to rollback.') sys.exit(1) _gp_expand.rollback(dburl) - logger.info('Rollback complete. Greenplum Database can now be started') + logger.info('Rollback complete.') sys.exit(0) except ExpansionError, e: logger.error(e) -- GitLab