From 6aac45f3f934cc24a3a155f2b52fe89bc39374bf Mon Sep 17 00:00:00 2001 From: Jesse Zhang Date: Wed, 30 Sep 2020 11:59:38 -0700 Subject: [PATCH] Add format checking in PR pipeline In the same vein as commit 868fd2d78e34b46a, this adds a very quick clang-format job that checks for conformance, similar to the Travis CI job did in commit 54273fdd729a1958 (greenplum-db/gpdb#10357). --- concourse/pipelines/pr_pipeline.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/concourse/pipelines/pr_pipeline.yml b/concourse/pipelines/pr_pipeline.yml index cfe8af076d..bd1bf793d4 100644 --- a/concourse/pipelines/pr_pipeline.yml +++ b/concourse/pipelines/pr_pipeline.yml @@ -47,6 +47,10 @@ resources: json_key: ((concourse-gcs-resources-service-account-key)) regexp: gp-internal-artifacts/centos7/libquicklz-devel-(1\.5\.0-.*)-1.el7.x86_64.rpm +- name: clang_toolchain + type: registry-image + source: + repository: gcr.io/data-orca/clang-toolchain jobs: - name: compile_and_test_gpdb @@ -63,6 +67,7 @@ jobs: resource: libquicklz-centos7 - get: libquicklz-devel-installer resource: libquicklz-devel-centos7 + - get: clang_toolchain - put: gpdb_pr params: @@ -96,6 +101,9 @@ jobs: git submodule update --init --recursive inputs: [{ name: gpdb_pr }] outputs: [{ name: gpdb_src }] + - task: check_format + image: clang_toolchain + file: gpdb_src/concourse/tasks/check_format.yml - task: compile_gpdb_centos7 file: gpdb_pr/concourse/tasks/compile_gpdb.yml image: gpdb7-centos7-build -- GitLab