From 43f2fd58e2959976aff78b5859e3d9f242d0f340 Mon Sep 17 00:00:00 2001
From: Ashwin Agrawal <aagrawal@pivotal.io>
Date: Tue, 16 Jan 2018 14:05:39 -0800
Subject: [PATCH] In debug PANIC for relcache decrement for bad reference
 count.

---
 src/backend/utils/cache/relcache.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
index c85fbfa41d..ce6b335183 100644
--- a/src/backend/utils/cache/relcache.c
+++ b/src/backend/utils/cache/relcache.c
@@ -1701,7 +1701,15 @@ RelationDecrementReferenceCount(Relation rel)
 {
 	if (rel->rd_refcnt <= 0)
 	{
+		/*
+		 * In CI intermittently ERROR is seen. To help debug the issue, just
+		 * for debug builds elevating ERROR to PANIC.
+		 */
+#ifdef USE_ASSERT_CHECKING
+		elog(PANIC,
+#else
 		elog(ERROR,
+#endif
 			 "Relation decrement reference count found relation %u/%u/%u with bad count (reference count %d)",
 			 rel->rd_node.spcNode,
 			 rel->rd_node.dbNode,
-- 
GitLab