From 40938f5e7c0ee5e0416694f014d0de223a0d5671 Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Tue, 9 Jan 2018 14:55:29 +0200 Subject: [PATCH] Remove test on aborting distributed transaction that did CREATE TABLESPACE. CREATE TABLESPACE isn't transactional. Rolling it back doesn't work properly. This is a known limitation in PostgreSQL, we'll live with it. --- .../expected/abort_create_tablespace_post.ans | 12 ------------ .../post_sql/sql/abort_create_tablespace_post.sql | 5 ----- .../sql/abort_create_tablespace_trigger.sql | 2 -- 3 files changed, 19 deletions(-) delete mode 100755 src/test/tinc/tincrepo/mpp/gpdb/tests/storage/pg_twophase/abort_create_tests/post_sql/expected/abort_create_tablespace_post.ans delete mode 100644 src/test/tinc/tincrepo/mpp/gpdb/tests/storage/pg_twophase/abort_create_tests/post_sql/sql/abort_create_tablespace_post.sql delete mode 100644 src/test/tinc/tincrepo/mpp/gpdb/tests/storage/pg_twophase/abort_create_tests/trigger_sql/sql/abort_create_tablespace_trigger.sql diff --git a/src/test/tinc/tincrepo/mpp/gpdb/tests/storage/pg_twophase/abort_create_tests/post_sql/expected/abort_create_tablespace_post.ans b/src/test/tinc/tincrepo/mpp/gpdb/tests/storage/pg_twophase/abort_create_tests/post_sql/expected/abort_create_tablespace_post.ans deleted file mode 100755 index c47a5e7ad5..0000000000 --- a/src/test/tinc/tincrepo/mpp/gpdb/tests/storage/pg_twophase/abort_create_tests/post_sql/expected/abort_create_tablespace_post.ans +++ /dev/null @@ -1,12 +0,0 @@ -CREATE TABLESPACE abort_ts1 filespace LOCATION '/tmp/twophase_create_tablespace_test_ts'; -CREATE TABLESPACE -create table ct_ts_test(a int, b int) tablespace abort_ts1; -psql:/path/sql_file:1: NOTICE: Table doesn't have 'DISTRIBUTED BY' clause -- Using column named 'a' as the Greenplum Database data distribution key for this table. -HINT: The 'DISTRIBUTED BY' clause determines the distribution of data. Make sure column(s) chosen are the optimal data distribution key to minimize skew. -CREATE TABLE -insert into ct_ts_test select i,i+1 from generate_series(1,1000)i; -INSERT 0 1000 -drop table ct_ts_test; -DROP TABLE -DROP TABLESPACE abort_ts1; -DROP TABLESPACE diff --git a/src/test/tinc/tincrepo/mpp/gpdb/tests/storage/pg_twophase/abort_create_tests/post_sql/sql/abort_create_tablespace_post.sql b/src/test/tinc/tincrepo/mpp/gpdb/tests/storage/pg_twophase/abort_create_tests/post_sql/sql/abort_create_tablespace_post.sql deleted file mode 100644 index 019a2f8c50..0000000000 --- a/src/test/tinc/tincrepo/mpp/gpdb/tests/storage/pg_twophase/abort_create_tests/post_sql/sql/abort_create_tablespace_post.sql +++ /dev/null @@ -1,5 +0,0 @@ -CREATE TABLESPACE abort_ts1 LOCATION '/tmp/twophase_create_tablespace_test_ts'; -create table ct_ts_test(a int, b int) tablespace abort_ts1; -insert into ct_ts_test select i,i+1 from generate_series(1,1000)i; -drop table ct_ts_test; -DROP TABLESPACE abort_ts1; diff --git a/src/test/tinc/tincrepo/mpp/gpdb/tests/storage/pg_twophase/abort_create_tests/trigger_sql/sql/abort_create_tablespace_trigger.sql b/src/test/tinc/tincrepo/mpp/gpdb/tests/storage/pg_twophase/abort_create_tests/trigger_sql/sql/abort_create_tablespace_trigger.sql deleted file mode 100644 index 5fa41025db..0000000000 --- a/src/test/tinc/tincrepo/mpp/gpdb/tests/storage/pg_twophase/abort_create_tests/trigger_sql/sql/abort_create_tablespace_trigger.sql +++ /dev/null @@ -1,2 +0,0 @@ -CREATE TABLESPACE abort_ts1 LOCATION '/tmp/twophase_create_tablespace_test_ts'; - -- GitLab