From 3763b0aa88c93100f748914704af03fbc00bab8d Mon Sep 17 00:00:00 2001 From: Ashwin Agrawal Date: Wed, 2 May 2018 14:59:36 -0700 Subject: [PATCH] Re-phrase FIXME for toasting type 'm' columns for AO tables Co-authored-by: Jesse Zhang --- src/backend/access/heap/tuptoaster.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/backend/access/heap/tuptoaster.c b/src/backend/access/heap/tuptoaster.c index a89cd34de0..f4c1befed8 100644 --- a/src/backend/access/heap/tuptoaster.c +++ b/src/backend/access/heap/tuptoaster.c @@ -985,8 +985,11 @@ toast_insert_or_update_generic(Relation rel, GenericTuple newtup, GenericTuple o * externally unless really necessary. */ /* - * GPDB_90_MERGE_FIXME: Should we do something like this with memtuples on - * AO tables too? + * FIXME: Should we do something like this with memtuples on + * AO tables too? Currently we do not increase the target tuple size for AO + * table, so there are occasions when columns of type 'm' will be stored + * out-of-line but they could otherwise be accommodated in-block + * c.f. upstream Postgres commit ca7c8168de76459380577eda56a3ed09b4f6195c */ if (!ismemtuple) maxDataLen = TOAST_TUPLE_TARGET_MAIN - hoff; -- GitLab