From 249a8c5244b3da7a6aa209a4b661d684f32a9152 Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Fri, 13 May 2016 14:58:53 +0200 Subject: [PATCH] Explicitly SET gp_select_invisible to false instead of using RESET As outlined in https://github.com/greenplum-db/gpdb/issues/685 we have a problem with resetting GUCs in the backends when the GUC was previously set in the per connection parameter. Explicitly set this GUC to false since that's the intention with the RESET commands in these cases to increase robustness of the tests. --- src/test/regress/expected/qp_misc_jiras.out | 2 +- src/test/regress/expected/qp_misc_jiras_optimizer.out | 2 +- src/test/regress/sql/qp_misc_jiras.sql | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/regress/expected/qp_misc_jiras.out b/src/test/regress/expected/qp_misc_jiras.out index 1d67790b3d..18367b8b09 100644 --- a/src/test/regress/expected/qp_misc_jiras.out +++ b/src/test/regress/expected/qp_misc_jiras.out @@ -1742,7 +1742,7 @@ WHERE T.SQ = 1 (0 rows) drop table qp_misc_jiras.ins_cr_nds_dt, qp_misc_jiras.ins_cr_nds_mstr, qp_misc_jiras.m_ccr_cvr_nds_t99, qp_misc_jiras.m_ccr_mthy_cr_nds_t00; -reset gp_select_invisible; +set gp_select_invisible=false; create table qp_misc_jiras.tbl6448 (x "char"); NOTICE: Table doesn't have 'DISTRIBUTED BY' clause -- Using column named 'x' as the Greenplum Database data distribution key for this table. HINT: The 'DISTRIBUTED BY' clause determines the distribution of data. Make sure column(s) chosen are the optimal data distribution key to minimize skew. diff --git a/src/test/regress/expected/qp_misc_jiras_optimizer.out b/src/test/regress/expected/qp_misc_jiras_optimizer.out index bb629ade44..cd5da171d8 100644 --- a/src/test/regress/expected/qp_misc_jiras_optimizer.out +++ b/src/test/regress/expected/qp_misc_jiras_optimizer.out @@ -1739,7 +1739,7 @@ WHERE T.SQ = 1 (0 rows) drop table qp_misc_jiras.ins_cr_nds_dt, qp_misc_jiras.ins_cr_nds_mstr, qp_misc_jiras.m_ccr_cvr_nds_t99, qp_misc_jiras.m_ccr_mthy_cr_nds_t00; -reset gp_select_invisible; +set gp_select_invisible=false; create table qp_misc_jiras.tbl6448 (x "char"); NOTICE: Table doesn't have 'DISTRIBUTED BY' clause -- Using column named 'x' as the Greenplum Database data distribution key for this table. HINT: The 'DISTRIBUTED BY' clause determines the distribution of data. Make sure column(s) chosen are the optimal data distribution key to minimize skew. diff --git a/src/test/regress/sql/qp_misc_jiras.sql b/src/test/regress/sql/qp_misc_jiras.sql index 97e407b9ee..0f3a17ad51 100644 --- a/src/test/regress/sql/qp_misc_jiras.sql +++ b/src/test/regress/sql/qp_misc_jiras.sql @@ -1073,7 +1073,7 @@ WHERE T.SQ = 1 drop table qp_misc_jiras.ins_cr_nds_dt, qp_misc_jiras.ins_cr_nds_mstr, qp_misc_jiras.m_ccr_cvr_nds_t99, qp_misc_jiras.m_ccr_mthy_cr_nds_t00; -reset gp_select_invisible; +set gp_select_invisible=false; create table qp_misc_jiras.tbl6448 (x "char"); insert into qp_misc_jiras.tbl6448 values ('a'); -- GitLab