From 1d62e402406c346fe98db8ee6e6fddb53bd0e7d8 Mon Sep 17 00:00:00 2001 From: Shreedhar Hardikar Date: Mon, 9 Nov 2020 13:01:43 -0600 Subject: [PATCH] Include to fix compiler error on MacOS (#11135) After commit aef9968059faf33e master build on macOS started to fail with errors like this: execute_pipe.c:197:6: error: implicit declaration of function 'kill' is invalid in C99 [-Werror,-Wimplicit-function-declaration] if (kill(pid, 0) == 0) /* process exists */ ^ 1 error generated. POSIX only guarantees that kill(2) be provided through . It turns out we were relying on to indirectly include for us. But that's a GNU-ism. This also showed up in Travis CI on greenplum-db/gpdb#11121 (https://travis-ci.org/github/greenplum-db/gpdb/builds/742342058) before it got merged into master. Co-authored-by: Shreedhar Hardikar Co-authored-by: Jesse Zhang --- src/backend/storage/file/execute_pipe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/backend/storage/file/execute_pipe.c b/src/backend/storage/file/execute_pipe.c index 7267c6cebc..ef7e896c5c 100644 --- a/src/backend/storage/file/execute_pipe.c +++ b/src/backend/storage/file/execute_pipe.c @@ -22,6 +22,7 @@ #include #include +#include #include "postgres.h" #include "storage/execute_pipe.h" -- GitLab