From 06ea112c484e70873a7c4cd32decc1662b0a8ed7 Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Sat, 16 Sep 2017 16:01:06 +0300 Subject: [PATCH] Fix check for superuser_reserved_connections. Upstream uses >= here. It was changed in GPDB, to use > instead of >=. but I don't see how that's more correct or better. I tracked that change in the old pre-open-sourcing repository to this commit: commit f3e98a1ef5fc5915662077b137c563371ea1c0a4 Date: Mon Apr 6 15:04:33 2009 -0800 Fixed guc check for ReservedBackends. [git-p4: depot-paths = "//cdb2/main/": change = 33269] So, there was no explanation there either, what the alleged problem was. --- src/backend/postmaster/postmaster.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c index ecd2293a36..4ae82ed3b9 100644 --- a/src/backend/postmaster/postmaster.c +++ b/src/backend/postmaster/postmaster.c @@ -1154,7 +1154,7 @@ PostmasterMain(int argc, char *argv[]) /* * Check for invalid combinations of GUC settings. */ - if (ReservedBackends > MaxBackends) + if (ReservedBackends >= MaxBackends) { write_stderr("%s: superuser_reserved_connections must be less than max_connections\n", progname); ExitPostmaster(1); -- GitLab