From 9894c06a2812f3835b44ea7ff7ac3adb02083d9e Mon Sep 17 00:00:00 2001 From: Dom <97384583+tosemml@users.noreply.github.com> Date: Tue, 5 Sep 2023 11:35:51 -0700 Subject: [PATCH] Code Refactoring (#4262) * use dict update * use dictionary update --------- Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com> --- tests/unit/modeling.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/unit/modeling.py b/tests/unit/modeling.py index 72adc8d3..ad8bc710 100644 --- a/tests/unit/modeling.py +++ b/tests/unit/modeling.py @@ -299,8 +299,7 @@ class BertConfig(object): if isinstance(vocab_size_or_config_json_file, str): with open(vocab_size_or_config_json_file, "r", encoding='utf-8') as reader: json_config = json.loads(reader.read()) - for key, value in json_config.items(): - self.__dict__[key] = value + self.__dict__.update(json_config) elif isinstance(vocab_size_or_config_json_file, int): self.vocab_size = vocab_size_or_config_json_file self.hidden_size = hidden_size @@ -323,8 +322,7 @@ class BertConfig(object): def from_dict(cls, json_object): """Constructs a `BertConfig` from a Python dictionary of parameters.""" config = BertConfig(vocab_size_or_config_json_file=-1) - for key, value in json_object.items(): - config.__dict__[key] = value + config.__dict__.update(json_object) return config @classmethod -- GitLab