From ec32a82c792ad7dfcb5f10008151d6da04c880fd Mon Sep 17 00:00:00 2001 From: Phodal Huang Date: Thu, 26 Dec 2019 13:39:06 +0800 Subject: [PATCH] refactor: remove unused class --- core/domain/refactor/rename/rename_method.go | 4 ---- core/domain/refactor/unused/remove_unused_import.go | 1 - .../refactor/unused_classes/UnusedClassesApp.go | 12 ++++++------ 3 files changed, 6 insertions(+), 11 deletions(-) diff --git a/core/domain/refactor/rename/rename_method.go b/core/domain/refactor/rename/rename_method.go index af1af12..60c4ccd 100644 --- a/core/domain/refactor/rename/rename_method.go +++ b/core/domain/refactor/rename/rename_method.go @@ -2,7 +2,6 @@ package unused import ( "encoding/json" - models2 "github.com/phodal/coca/core/domain/refactor/base/models" support3 "github.com/phodal/coca/core/domain/refactor/rename/support" . "github.com/phodal/coca/core/models" "github.com/phodal/coca/core/support" @@ -12,7 +11,6 @@ import ( ) var parsedChange []support3.RefactorChangeRelate -var nodes []models2.JMoveStruct type RemoveMethodApp struct { } @@ -23,7 +21,6 @@ var conf string var parsedDeps []JClassNode func RenameMethodApp(dep string, p string) *RemoveMethodApp { - nodes = nil depsFile = dep configPath = p return &RemoveMethodApp{} @@ -50,7 +47,6 @@ func (j *RemoveMethodApp) Start() { } func startParse(nodes []JClassNode, relates []support3.RefactorChangeRelate) { - for _, pkgNode := range nodes { for _, related := range relates { oldInfo := support3.BuildMethodPackageInfo(related.OldObj) diff --git a/core/domain/refactor/unused/remove_unused_import.go b/core/domain/refactor/unused/remove_unused_import.go index f658af3..8f58d46 100644 --- a/core/domain/refactor/unused/remove_unused_import.go +++ b/core/domain/refactor/unused/remove_unused_import.go @@ -13,7 +13,6 @@ import ( ) var currentFile string -var moveConfig string var configPath string type RemoveUnusedImportApp struct { diff --git a/core/domain/refactor/unused_classes/UnusedClassesApp.go b/core/domain/refactor/unused_classes/UnusedClassesApp.go index 18aba28..e60cef9 100644 --- a/core/domain/refactor/unused_classes/UnusedClassesApp.go +++ b/core/domain/refactor/unused_classes/UnusedClassesApp.go @@ -1,17 +1,17 @@ package main import ( - . "github.com/phodal/coca/core/models" - "github.com/phodal/coca/core/support" "encoding/json" "fmt" + . "github.com/phodal/coca/core/models" + "github.com/phodal/coca/core/support" "sort" "strings" ) var parsedDeps []JClassNode -func main() { +func main() { var analysisPackage = "" file := support.ReadFile("deps.json") if file == nil { @@ -20,7 +20,7 @@ func main() { _ = json.Unmarshal(file, &parsedDeps) sourceClasses := make(map[string]string) - targetlasses := make(map[string]string) + targetClasses := make(map[string]string) for _, node := range parsedDeps { if strings.Contains(node.Package, analysisPackage) { @@ -31,14 +31,14 @@ func main() { for _, methodCall := range node.MethodCalls { if strings.Contains(methodCall.Package, analysisPackage) { className := methodCall.Package + "." + methodCall.Class - targetlasses[className] = className + targetClasses[className] = className } } } var excludePackage []string = nil for _, clz := range sourceClasses { - if targetlasses[clz] != clz { + if targetClasses[clz] != clz { excludePackage = append(excludePackage, clz) } } -- GitLab