From 3c55d0c69b089a1a282b8803dcd076404226901e Mon Sep 17 00:00:00 2001 From: Romain Vimont Date: Fri, 12 Jul 2019 21:05:45 +0200 Subject: [PATCH] Fix double-free on error If writing the recording header fails, do not clean the resources immediately to avoid double-free. --- app/src/recorder.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/app/src/recorder.c b/app/src/recorder.c index f0f64a5f..3de8257a 100644 --- a/app/src/recorder.c +++ b/app/src/recorder.c @@ -151,9 +151,6 @@ recorder_write_header(struct recorder *recorder, const AVPacket *packet) { int ret = avformat_write_header(recorder->ctx, NULL); if (ret < 0) { LOGE("Failed to write header to %s", recorder->filename); - SDL_free(extradata); - avio_closep(&recorder->ctx->pb); - avformat_free_context(recorder->ctx); return false; } -- GitLab