Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
github
hub
提交
f8663339
H
hub
项目概览
github
/
hub
大约 1 年 前同步成功
通知
3
Star
22523
Fork
2406
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
H
hub
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
f8663339
编写于
1月 19, 2018
作者:
M
Mislav Marohnić
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Enable team reviewers in `pull-request`
上级
55dec7d3
变更
3
显示空白变更内容
内联
并排
Showing
3 changed file
with
17 addition
and
4 deletion
+17
-4
commands/pull_request.go
commands/pull_request.go
+13
-1
features/pull_request.feature
features/pull_request.feature
+3
-2
github/http.go
github/http.go
+1
-1
未找到文件。
commands/pull_request.go
浏览文件 @
f8663339
...
...
@@ -336,7 +336,19 @@ func pullRequest(cmd *Command, args *Args) {
}
if
len
(
flagPullRequestReviewers
)
>
0
{
err
=
client
.
RequestReview
(
baseProject
,
pr
.
Number
,
map
[
string
]
interface
{}{
"reviewers"
:
flagPullRequestReviewers
})
userReviewers
:=
[]
string
{}
teamReviewers
:=
[]
string
{}
for
_
,
reviewer
:=
range
flagPullRequestReviewers
{
if
strings
.
Contains
(
reviewer
,
"/"
)
{
teamReviewers
=
append
(
teamReviewers
,
strings
.
SplitN
(
reviewer
,
"/"
,
2
)[
1
])
}
else
{
userReviewers
=
append
(
userReviewers
,
reviewer
)
}
}
err
=
client
.
RequestReview
(
baseProject
,
pr
.
Number
,
map
[
string
]
interface
{}{
"reviewers"
:
userReviewers
,
"team_reviewers"
:
teamReviewers
,
})
utils
.
Check
(
err
)
}
}
...
...
features/pull_request.feature
浏览文件 @
f8663339
...
...
@@ -743,13 +743,14 @@ BODY
json :html_url => "the://url", :number => 1234
}
post('/repos/mislav/coral/pulls/1234/requested_reviewers') {
halt 415 unless request.accept?('application/vnd.github.
black-cat
-preview+json')
halt 415 unless request.accept?('application/vnd.github.
thor
-preview+json')
assert :reviewers => ["mislav", "josh", "pcorpet"]
assert :team_reviewers => ["robots", "js"]
status 201
json :html_url => "the://url"
}
"""
When
I successfully run `hub pull-request -m hereyougo -r mislav,josh -r
pcorpet
`
When
I successfully run `hub pull-request -m hereyougo -r mislav,josh -r
github/robots -rpcorpet -r github/js
`
Then the output should contain exactly "the
:
//url\n"
Scenario
:
Pull request with milestone
...
...
github/http.go
浏览文件 @
f8663339
...
...
@@ -276,7 +276,7 @@ func (c *simpleClient) PatchJSON(path string, payload interface{}) (*simpleRespo
func
(
c
*
simpleClient
)
PostReview
(
path
string
,
payload
interface
{})
(
*
simpleResponse
,
error
)
{
return
c
.
jsonRequest
(
"POST"
,
path
,
payload
,
func
(
req
*
http
.
Request
)
{
req
.
Header
.
Set
(
"Accept"
,
"application/vnd.github.
black-cat
-preview+json;charset=utf-8"
)
req
.
Header
.
Set
(
"Accept"
,
"application/vnd.github.
thor
-preview+json;charset=utf-8"
)
})
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录