Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
github
hub
提交
295577d3
H
hub
项目概览
github
/
hub
12 个月 前同步成功
通知
3
Star
22523
Fork
2406
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
H
hub
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
295577d3
编写于
11月 25, 2014
作者:
J
Jingwen Owen Ou
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Remove editor file is there’s no title
See
https://github.com/github/hub/issues/700
上级
2ce43736
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
32 addition
and
9 deletion
+32
-9
github/editor.go
github/editor.go
+4
-0
github/editor_test.go
github/editor_test.go
+28
-9
未找到文件。
github/editor.go
浏览文件 @
295577d3
...
...
@@ -63,6 +63,10 @@ func (e *Editor) EditTitleAndBody() (title, body string, err error) {
reader
:=
bytes
.
NewReader
(
content
)
title
,
body
,
err
=
readTitleAndBody
(
reader
,
e
.
CS
)
if
err
!=
nil
||
title
==
""
{
e
.
DeleteFile
()
}
return
}
...
...
github/editor_test.go
浏览文件 @
295577d3
...
...
@@ -5,7 +5,6 @@ import (
"fmt"
"io/ioutil"
"os"
"path/filepath"
"strings"
"testing"
...
...
@@ -59,14 +58,13 @@ func TestEditor_openAndEdit_readFileIfExist(t *testing.T) {
}
func
TestEditor_openAndEdit_writeFileIfNotExist
(
t
*
testing
.
T
)
{
tempDir
,
_
:=
ioutil
.
TempDir
(
""
,
"editor-test"
)
tempFile
:=
filepath
.
Join
(
tempDir
,
"PULLREQ"
)
tempFile
,
_
:=
ioutil
.
TempFile
(
""
,
"PULLREQ"
)
editor
:=
Editor
{
Program
:
"memory"
,
File
:
tempFile
,
File
:
tempFile
.
Name
()
,
openEditor
:
func
(
program
string
,
file
string
)
error
{
assert
.
Equal
(
t
,
"memory"
,
program
)
assert
.
Equal
(
t
,
tempFile
,
file
)
assert
.
Equal
(
t
,
tempFile
.
Name
()
,
file
)
return
ioutil
.
WriteFile
(
file
,
[]
byte
(
"hello"
),
0644
)
},
...
...
@@ -77,16 +75,37 @@ func TestEditor_openAndEdit_writeFileIfNotExist(t *testing.T) {
assert
.
Equal
(
t
,
"hello"
,
string
(
content
))
}
func
TestEditor_EditTitleAndBodyEmptyTitle
(
t
*
testing
.
T
)
{
tempFile
,
_
:=
ioutil
.
TempFile
(
""
,
"PULLREQ"
)
editor
:=
Editor
{
Program
:
"memory"
,
File
:
tempFile
.
Name
(),
CS
:
"#"
,
openEditor
:
func
(
program
string
,
file
string
)
error
{
assert
.
Equal
(
t
,
"memory"
,
program
)
assert
.
Equal
(
t
,
tempFile
.
Name
(),
file
)
return
ioutil
.
WriteFile
(
file
,
[]
byte
(
""
),
0644
)
},
}
title
,
body
,
err
:=
editor
.
EditTitleAndBody
()
assert
.
Equal
(
t
,
nil
,
err
)
assert
.
Equal
(
t
,
""
,
title
)
assert
.
Equal
(
t
,
""
,
body
)
_
,
err
=
os
.
Stat
(
tempFile
.
Name
())
assert
.
T
(
t
,
os
.
IsNotExist
(
err
))
}
func
TestEditor_EditTitleAndBody
(
t
*
testing
.
T
)
{
tempDir
,
_
:=
ioutil
.
TempDir
(
""
,
"editor-test"
)
tempFile
:=
filepath
.
Join
(
tempDir
,
"PULLREQ"
)
tempFile
,
_
:=
ioutil
.
TempFile
(
""
,
"PULLREQ"
)
editor
:=
Editor
{
Program
:
"memory"
,
File
:
tempFile
,
File
:
tempFile
.
Name
()
,
CS
:
"#"
,
openEditor
:
func
(
program
string
,
file
string
)
error
{
assert
.
Equal
(
t
,
"memory"
,
program
)
assert
.
Equal
(
t
,
tempFile
,
file
)
assert
.
Equal
(
t
,
tempFile
.
Name
()
,
file
)
message
:=
`A title
A title continues
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录