From cddafc5589cc4a9b897b812117e1cce6903b2c00 Mon Sep 17 00:00:00 2001
From: JessYan <jessyan@foxmail.com>
Date: Tue, 3 Apr 2018 18:21:01 +0800
Subject: [PATCH] Improve OkHttpUrlLoader

---
 .../com/jess/arms/http/OkHttpUrlLoader.java   | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/arms/src/main/java/com/jess/arms/http/OkHttpUrlLoader.java b/arms/src/main/java/com/jess/arms/http/OkHttpUrlLoader.java
index b4b57ad..fa4b513 100644
--- a/arms/src/main/java/com/jess/arms/http/OkHttpUrlLoader.java
+++ b/arms/src/main/java/com/jess/arms/http/OkHttpUrlLoader.java
@@ -15,6 +15,8 @@
  */
 package com.jess.arms.http;
 
+import android.support.annotation.NonNull;
+
 import com.bumptech.glide.load.Options;
 import com.bumptech.glide.load.model.GlideUrl;
 import com.bumptech.glide.load.model.ModelLoader;
@@ -31,27 +33,31 @@ public class OkHttpUrlLoader implements ModelLoader<GlideUrl, InputStream> {
 
     private final Call.Factory client;
 
-    public OkHttpUrlLoader(Call.Factory client) {
+    // Public API.
+    @SuppressWarnings("WeakerAccess")
+    public OkHttpUrlLoader(@NonNull Call.Factory client) {
         this.client = client;
     }
 
     @Override
-    public boolean handles(GlideUrl url) {
+    public boolean handles(@NonNull GlideUrl url) {
         return true;
     }
 
     @Override
-    public LoadData<InputStream> buildLoadData(GlideUrl model, int width, int height,
-                                               Options options) {
+    public LoadData<InputStream> buildLoadData(@NonNull GlideUrl model, int width, int height,
+                                               @NonNull Options options) {
         return new LoadData<>(model, new OkHttpStreamFetcher(client, model));
     }
 
     /**
      * The default factory for {@link OkHttpUrlLoader}s.
      */
+    // Public API.
+    @SuppressWarnings("WeakerAccess")
     public static class Factory implements ModelLoaderFactory<GlideUrl, InputStream> {
         private static volatile Call.Factory internalClient;
-        private Call.Factory client;
+        private final Call.Factory client;
 
         private static Call.Factory getInternalClient() {
             if (internalClient == null) {
@@ -76,10 +82,11 @@ public class OkHttpUrlLoader implements ModelLoader<GlideUrl, InputStream> {
          *
          * @param client this is typically an instance of {@code OkHttpClient}.
          */
-        public Factory(Call.Factory client) {
+        public Factory(@NonNull Call.Factory client) {
             this.client = client;
         }
 
+        @NonNull
         @Override
         public ModelLoader<GlideUrl, InputStream> build(MultiModelLoaderFactory multiFactory) {
             return new OkHttpUrlLoader(client);
-- 
GitLab