diff --git a/apm-commons/apm-util/src/main/java/org/apache/skywalking/apm/util/PropertyPlaceholderHelper.java b/apm-commons/apm-util/src/main/java/org/apache/skywalking/apm/util/PropertyPlaceholderHelper.java index 4e985bafb9bace1375a6869686291c8cbe61c66a..c12661cb92cc451929a6b35270efcaadd46310d2 100644 --- a/apm-commons/apm-util/src/main/java/org/apache/skywalking/apm/util/PropertyPlaceholderHelper.java +++ b/apm-commons/apm-util/src/main/java/org/apache/skywalking/apm/util/PropertyPlaceholderHelper.java @@ -31,7 +31,11 @@ import java.util.Set; */ public enum PropertyPlaceholderHelper { - INSTANCE(PlaceholderConfigurerSupport.DEFAULT_PLACEHOLDER_PREFIX, PlaceholderConfigurerSupport.DEFAULT_PLACEHOLDER_SUFFIX, PlaceholderConfigurerSupport.DEFAULT_VALUE_SEPARATOR, true); + INSTANCE( + PlaceholderConfigurerSupport.DEFAULT_PLACEHOLDER_PREFIX, + PlaceholderConfigurerSupport.DEFAULT_PLACEHOLDER_SUFFIX, PlaceholderConfigurerSupport.DEFAULT_VALUE_SEPARATOR, + true + ); private final String placeholderPrefix; @@ -54,7 +58,7 @@ public enum PropertyPlaceholderHelper { * true}) or cause an exception ({@code false}) */ PropertyPlaceholderHelper(String placeholderPrefix, String placeholderSuffix, String valueSeparator, - boolean ignoreUnresolvablePlaceholders) { + boolean ignoreUnresolvablePlaceholders) { if (StringUtil.isEmpty(placeholderPrefix) || StringUtil.isEmpty(placeholderSuffix)) { throw new UnsupportedOperationException("'placeholderPrefix or placeholderSuffix' must not be null"); } @@ -89,17 +93,17 @@ public enum PropertyPlaceholderHelper { return replacePlaceholders(value, new PlaceholderResolver() { @Override public String resolvePlaceholder(String placeholderName) { - return PropertyPlaceholderHelper.this.getConfigValue(placeholderName, properties); + return getConfigValue(placeholderName, properties); } }); } private String getConfigValue(String key, final Properties properties) { String value = System.getProperty(key); - if (StringUtil.isEmpty(value)) { + if (value == null) { value = System.getenv(key); } - if (StringUtil.isEmpty(value)) { + if (value == null) { value = properties.getProperty(key); } return value; @@ -118,7 +122,7 @@ public enum PropertyPlaceholderHelper { } protected String parseStringValue(String value, PlaceholderResolver placeholderResolver, - Set visitedPlaceholders) { + Set visitedPlaceholders) { StringBuilder result = new StringBuilder(value); @@ -129,7 +133,8 @@ public enum PropertyPlaceholderHelper { String placeholder = result.substring(startIndex + this.placeholderPrefix.length(), endIndex); String originalPlaceholder = placeholder; if (!visitedPlaceholders.add(originalPlaceholder)) { - throw new IllegalArgumentException("Circular placeholder reference '" + originalPlaceholder + "' in property definitions"); + throw new IllegalArgumentException( + "Circular placeholder reference '" + originalPlaceholder + "' in property definitions"); } // Recursive invocation, parsing placeholders contained in the placeholder key. placeholder = parseStringValue(placeholder, placeholderResolver, visitedPlaceholders); @@ -156,7 +161,8 @@ public enum PropertyPlaceholderHelper { // Proceed with unprocessed value. startIndex = result.indexOf(this.placeholderPrefix, endIndex + this.placeholderSuffix.length()); } else { - throw new IllegalArgumentException("Could not resolve placeholder '" + placeholder + "'" + " in value \"" + value + "\""); + throw new IllegalArgumentException( + "Could not resolve placeholder '" + placeholder + "'" + " in value \"" + value + "\""); } visitedPlaceholders.remove(originalPlaceholder); } else { diff --git a/oap-server/server-bootstrap/src/main/java/org/apache/skywalking/oap/server/starter/config/ApplicationConfigLoader.java b/oap-server/server-bootstrap/src/main/java/org/apache/skywalking/oap/server/starter/config/ApplicationConfigLoader.java index cd612f374282f8987b3ea08e19c330c2c8e0700f..31c874dd1fc54a1af430485aaa4aeb8f6d19fab7 100644 --- a/oap-server/server-bootstrap/src/main/java/org/apache/skywalking/oap/server/starter/config/ApplicationConfigLoader.java +++ b/oap-server/server-bootstrap/src/main/java/org/apache/skywalking/oap/server/starter/config/ApplicationConfigLoader.java @@ -24,13 +24,12 @@ import java.util.HashSet; import java.util.Map; import java.util.Properties; import java.util.Set; +import lombok.extern.slf4j.Slf4j; import org.apache.skywalking.apm.util.PropertyPlaceholderHelper; import org.apache.skywalking.oap.server.library.module.ApplicationConfiguration; import org.apache.skywalking.oap.server.library.module.ProviderNotFoundException; import org.apache.skywalking.oap.server.library.util.CollectionUtils; import org.apache.skywalking.oap.server.library.util.ResourceUtils; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; import org.yaml.snakeyaml.Yaml; /** @@ -39,10 +38,8 @@ import org.yaml.snakeyaml.Yaml; *

* At last, override setting by system.properties and system.envs if the key matches moduleName.provideName.settingKey. */ +@Slf4j public class ApplicationConfigLoader implements ConfigLoader { - - private static final Logger logger = LoggerFactory.getLogger(ApplicationConfigLoader.class); - private static final String DISABLE_SELECTOR = "-"; private static final String SELECTOR = "selector"; @@ -65,10 +62,14 @@ public class ApplicationConfigLoader implements ConfigLoader { if (providerConfig.size() > 0) { - logger.info("Get a module define from application.yml, module name: {}", moduleName); - ApplicationConfiguration.ModuleConfiguration moduleConfiguration = configuration.addModule(moduleName); + log.info("Get a module define from application.yml, module name: {}", moduleName); + ApplicationConfiguration.ModuleConfiguration moduleConfiguration = configuration.addModule( + moduleName); providerConfig.forEach((providerName, config) -> { - logger.info("Get a provider define belong to {} module, provider name: {}", moduleName, providerName); + log.info( + "Get a provider define belong to {} module, provider name: {}", moduleName, + providerName + ); final Map propertiesConfig = (Map) config; final Properties properties = new Properties(); if (propertiesConfig != null) { @@ -89,7 +90,10 @@ public class ApplicationConfigLoader implements ConfigLoader 0) { - return otherMetricsDataTTL; - } - return minuteMetricsDataTTL; - } - - public int getHourMetricsDataTTL() { - if (otherMetricsDataTTL > 0) { - return otherMetricsDataTTL; - } - return hourMetricsDataTTL; - } - - public int getDayMetricsDataTTL() { - if (otherMetricsDataTTL > 0) { - return otherMetricsDataTTL; - } - return dayMetricsDataTTL; - } }