From e2fee2cd90816b6d99db11bda3dd4213fc6248ac Mon Sep 17 00:00:00 2001 From: rick Date: Thu, 3 Dec 2020 14:31:34 +0800 Subject: [PATCH] Fix two issues according to review opinions Signed-off-by: rick --- pkg/kapis/devops/v1alpha2/devops.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/kapis/devops/v1alpha2/devops.go b/pkg/kapis/devops/v1alpha2/devops.go index 62c587ee..fa8a8f51 100644 --- a/pkg/kapis/devops/v1alpha2/devops.go +++ b/pkg/kapis/devops/v1alpha2/devops.go @@ -62,7 +62,6 @@ func (h *ProjectPipelineHandler) getPipelinesByRequest(req *restful.Request) (ap // parse query from the request query := req.QueryParameter("q") - req.Request.PostForm.Set("limit", "1000") for _, val := range strings.Split(query, ";") { if strings.HasPrefix(val, "pipeline:") { namespace = strings.TrimLeft(val, "pipeline:") @@ -81,7 +80,7 @@ func (h *ProjectPipelineHandler) getPipelinesByRequest(req *restful.Request) (ap defer req.Request.Form.Set("limit", "10000") // assume the pipelines no more than 10k return h.devopsOperator.ListPipelineObj(namespace, func(list []*v1alpha3.Pipeline, i int, j int) bool { - return strings.Compare(list[i].Name, list[j].Name) < 0 + return strings.Compare(strings.ToUpper(list[i].Name), strings.ToUpper(list[j].Name)) < 0 }, limit, start) } -- GitLab