From d9450c906bc5cb27490521e3ae09692ee2c75bc3 Mon Sep 17 00:00:00 2001 From: Michael Herzog Date: Thu, 9 Sep 2021 18:33:47 +0200 Subject: [PATCH] ShapeGeometry: Make all parameters optional. (#22513) --- docs/api/en/geometries/ShapeGeometry.html | 2 +- docs/api/zh/geometries/ShapeGeometry.html | 2 +- src/geometries/ShapeGeometry.js | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/api/en/geometries/ShapeGeometry.html b/docs/api/en/geometries/ShapeGeometry.html index 390e995c0c..39e8ee9890 100644 --- a/docs/api/en/geometries/ShapeGeometry.html +++ b/docs/api/en/geometries/ShapeGeometry.html @@ -59,7 +59,7 @@

[name]([param:Array shapes], [param:Integer curveSegments])

- shapes — [page:Array] of shapes or a single [page:Shape shape].
+ shapes — [page:Array] of shapes or a single [page:Shape shape]. Default is a single triangle shape.
curveSegments - [page:Integer] - Number of segments per shape. Default is 12.

diff --git a/docs/api/zh/geometries/ShapeGeometry.html b/docs/api/zh/geometries/ShapeGeometry.html index b9b6742968..0cd5ac6667 100644 --- a/docs/api/zh/geometries/ShapeGeometry.html +++ b/docs/api/zh/geometries/ShapeGeometry.html @@ -59,7 +59,7 @@

[name]([param:Array shapes], [param:Integer curveSegments])

- shapes — 一个单独的[page:Shape shape],或者一个包含形状的[page:Array]。
+ shapes — 一个单独的[page:Shape shape],或者一个包含形状的[page:Array]。Default is a single triangle shape.
curveSegments - [page:Integer] - 每一个形状的分段数,默认值为12。

diff --git a/src/geometries/ShapeGeometry.js b/src/geometries/ShapeGeometry.js index a73943cdd8..fd884c7dde 100644 --- a/src/geometries/ShapeGeometry.js +++ b/src/geometries/ShapeGeometry.js @@ -1,10 +1,12 @@ import { BufferGeometry } from '../core/BufferGeometry.js'; import { Float32BufferAttribute } from '../core/BufferAttribute.js'; +import { Shape } from '../extras/core/Shape.js'; import { ShapeUtils } from '../extras/ShapeUtils.js'; +import { Vector2 } from '../math/Vector2.js'; class ShapeGeometry extends BufferGeometry { - constructor( shapes, curveSegments = 12 ) { + constructor( shapes = new Shape( [ new Vector2( 0, 0.5 ), new Vector2( - 0.5, - 0.5 ), new Vector2( 0.5, - 0.5 ) ] ), curveSegments = 12 ) { super(); this.type = 'ShapeGeometry'; -- GitLab