From 2b0b93b9123a5853b15f578a72b7f0d6e5fbbd42 Mon Sep 17 00:00:00 2001 From: songgg <1172417734@qq.com> Date: Tue, 7 Apr 2020 22:27:28 +0800 Subject: [PATCH] =?UTF-8?q?[optimization]=EF=BC=9Aremove=20duplicate=20cod?= =?UTF-8?q?e=20(#2377)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * sqlTask failed to run * remove duplicate code * remove duplicate code * remove duplicate code * remove duplicate code * remove duplicate code Co-authored-by: songqh --- .../apache/dolphinscheduler/api/service/ExecutorService.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ExecutorService.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ExecutorService.java index fe43f10b7..dda960d2e 100644 --- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ExecutorService.java +++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ExecutorService.java @@ -453,7 +453,7 @@ public class ExecutorService extends BaseService{ TaskDependType nodeDep, FailureStrategy failureStrategy, String startNodeList, String schedule, WarningType warningType, int excutorId, int warningGroupId, - RunMode runMode,Priority processInstancePriority, int workerGroupId) throws ParseException { + RunMode runMode,Priority processInstancePriority, int workerGroupId){ /** * instantiate command schedule instance @@ -496,6 +496,7 @@ public class ExecutorService extends BaseService{ } } + // determine whether to complement if(commandType == CommandType.COMPLEMENT_DATA){ runMode = (runMode == null) ? RunMode.RUN_MODE_SERIAL : runMode; if(null != start && null != end && start.before(end)){ @@ -540,7 +541,7 @@ public class ExecutorService extends BaseService{ processDefineId, schedule); } }else{ - command.setCommandParam(JSONUtils.toJson(cmdParam)); + return processService.createCommand(command); } -- GitLab