From 8e55bbd41725cd8c7f29a9e41993a22777ebdacf Mon Sep 17 00:00:00 2001 From: Greg Hogan Date: Fri, 12 Feb 2016 08:38:05 -0500 Subject: [PATCH] [FLINK-3393] [core] ExternalProcessRunner wait to finish copying error stream --- .../java/org/apache/flink/util/ExternalProcessRunner.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/flink-core/src/main/java/org/apache/flink/util/ExternalProcessRunner.java b/flink-core/src/main/java/org/apache/flink/util/ExternalProcessRunner.java index 8e4725c6c26..b7e388cfdf8 100644 --- a/flink-core/src/main/java/org/apache/flink/util/ExternalProcessRunner.java +++ b/flink-core/src/main/java/org/apache/flink/util/ExternalProcessRunner.java @@ -41,6 +41,8 @@ public class ExternalProcessRunner { private final Process process; + private final Thread pipeForwarder; + final StringWriter errorOutput = new StringWriter(); /** @@ -63,7 +65,7 @@ public class ExternalProcessRunner { process = new ProcessBuilder(commandList).start(); - new PipeForwarder(process.getErrorStream(), errorOutput); + pipeForwarder = new PipeForwarder(process.getErrorStream(), errorOutput); } /** @@ -83,6 +85,9 @@ public class ExternalProcessRunner { try { int returnCode = process.waitFor(); + // wait to finish copying standard error stream + pipeForwarder.join(); + if (returnCode != 0) { // determine whether we failed because of a ClassNotFoundException and forward that if (getErrorOutput().toString().contains("Error: Could not find or load main class " + entryPointClassName)) { -- GitLab