From 4bd0ef1b5208ff3a853fbb7c3d74edc5317d0245 Mon Sep 17 00:00:00 2001 From: Nico Kruber Date: Fri, 24 Nov 2017 14:54:41 +0100 Subject: [PATCH] [FLINK-8148][yarn/s3] fix test instability in YarnFileStageTestS3ITCase Remove a check for a deleted directory since we may not see our own delete yet with S3. This closes #5066. --- .../test/java/org/apache/flink/yarn/YarnFileStageTest.java | 2 +- .../java/org/apache/flink/yarn/YarnFileStageTestS3ITCase.java | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTest.java b/flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTest.java index 4d3825311ae..5cbe1be7eea 100644 --- a/flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTest.java +++ b/flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTest.java @@ -139,7 +139,7 @@ public class YarnFileStageTest extends TestLogger { * @param addSchemeToLocalPath * whether add the file:// scheme to the local path to copy from */ - public static void testCopyFromLocalRecursive( + static void testCopyFromLocalRecursive( FileSystem targetFileSystem, Path targetDir, TemporaryFolder tempFolder, diff --git a/flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTestS3ITCase.java b/flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTestS3ITCase.java index 74fb5963179..e1e95b1c379 100644 --- a/flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTestS3ITCase.java +++ b/flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTestS3ITCase.java @@ -42,7 +42,6 @@ import java.util.Map; import java.util.UUID; import static org.hamcrest.Matchers.greaterThan; -import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertThat; import static org.junit.Assume.assumeFalse; import static org.junit.Assume.assumeNoException; @@ -166,9 +165,6 @@ public class YarnFileStageTestS3ITCase extends TestLogger { YarnFileStageTest.testCopyFromLocalRecursive(fs.getHadoopFileSystem(), new org.apache.hadoop.fs.Path(directory.toUri()), tempFolder, true); - - // now directory must be gone - assertFalse(fs.exists(directory)); } finally { // clean up fs.delete(basePath, true); -- GitLab