From e130a89ceebdd542d9ae4821e4509ba494c6a24d Mon Sep 17 00:00:00 2001
From: Ankit Jain <radical@gmail.com>
Date: Thu, 25 Aug 2022 11:25:22 -0400
Subject: [PATCH] [wasm] Move all the wasm jobs from runtime-staging to runtime
 (#73596)

* [wasm] Move stable jobs from runtime-staging to runtime

- library tests: windows
- AOT tests: windows
- Debugger tests (chrome): windows, and linux
- Wasm.Build.Tests: windows

* Move last remaining wasm-firefox tests to runtime too

* Move firefox debugger tests to runtime-extra-platforms

* Fix browser-eventpipe build

```
src/mono/sample/wasm/browser-eventpipe/Program.cs(80,13): error IDE0074: (NETCORE_ENGINEERING_TELEMETRY=Build) Use compound assignment
```
---
 .../runtime-extra-platforms-wasm.yml          | 11 +++++
 eng/pipelines/runtime-staging.yml             | 47 -------------------
 eng/pipelines/runtime.yml                     | 28 +++++++++++
 .../sample/wasm/browser-eventpipe/Program.cs  |  4 +-
 4 files changed, 40 insertions(+), 50 deletions(-)

diff --git a/eng/pipelines/runtime-extra-platforms-wasm.yml b/eng/pipelines/runtime-extra-platforms-wasm.yml
index 70e862197fe..c4465c1194d 100644
--- a/eng/pipelines/runtime-extra-platforms-wasm.yml
+++ b/eng/pipelines/runtime-extra-platforms-wasm.yml
@@ -46,6 +46,17 @@ jobs:
       runAOT: true
       alwaysRun: true
 
+  # Wasm Debugger tests - firefox
+  - template: /eng/pipelines/common/templates/wasm-debugger-tests.yml
+    parameters:
+      platforms:
+        - Browser_wasm_firefox
+      browser: firefox
+      # ff tests are unstable currently
+      shouldContinueOnError: true
+      alwaysRun: true
+
+
   # Disabled for now
   #- template: /eng/pipelines/coreclr/perf-wasm-jobs.yml
     #parameters:
diff --git a/eng/pipelines/runtime-staging.yml b/eng/pipelines/runtime-staging.yml
index b5ce3e8bf43..0f6cf9fc191 100644
--- a/eng/pipelines/runtime-staging.yml
+++ b/eng/pipelines/runtime-staging.yml
@@ -58,53 +58,6 @@ jobs:
 - ${{ if eq(variables.dependOnEvaluatePaths, true) }}:
   - template: /eng/pipelines/common/evaluate-default-paths.yml
 
-#
-# WebAssembly legs - library tests, Wasm.Build.Tests, and debugger tests
-#
-- template: /eng/pipelines/common/templates/wasm-library-tests.yml
-  parameters:
-    platforms:
-      - Browser_wasm_win
-    shouldContinueOnError: forceFalse
-    alwaysRun: ${{ variables.isRollingBuild }}
-    scenarios:
-      - WasmTestOnBrowser
-
-# AOT Library tests
-- template: /eng/pipelines/common/templates/wasm-library-aot-tests.yml
-  parameters:
-    platforms:
-      - Browser_wasm_win
-    nameSuffix: _AOT
-    runSmokeOnlyArg: $(_runSmokeTestsOnlyArg)
-    runAOT: true
-    shouldContinueOnError: forceFalse
-    alwaysRun: ${{ variables.isRollingBuild }}
-
-- template: /eng/pipelines/common/templates/wasm-build-tests.yml
-  parameters:
-    platforms:
-      - Browser_wasm_win
-    shouldContinueOnError: forceFalse
-    alwaysRun: ${{ variables.isRollingBuild }}
-
-- template: /eng/pipelines/common/templates/wasm-debugger-tests.yml
-  parameters:
-    platforms:
-      - Browser_wasm
-      - Browser_wasm_win
-    shouldContinueOnError: forceFalse
-    alwaysRun: ${{ variables.isRollingBuild }}
-
-- template: /eng/pipelines/common/templates/wasm-debugger-tests.yml
-  parameters:
-    platforms:
-      - Browser_wasm_firefox
-    browser: firefox
-    # ff tests are unstable currently
-    shouldContinueOnError: true
-    alwaysRun: ${{ variables.isRollingBuild }}
-
 #
 # Build the whole product using Mono
 #
diff --git a/eng/pipelines/runtime.yml b/eng/pipelines/runtime.yml
index 882eddc4c2f..9dc55e45cc6 100644
--- a/eng/pipelines/runtime.yml
+++ b/eng/pipelines/runtime.yml
@@ -366,6 +366,14 @@ jobs:
       - normal
       - WasmTestOnBrowser
 
+- template: /eng/pipelines/common/templates/wasm-library-tests.yml
+  parameters:
+    platforms:
+      - Browser_wasm_win
+    alwaysRun: ${{ variables.isRollingBuild }}
+    scenarios:
+      - WasmTestOnBrowser
+
 # EAT Library tests - only run on linux
 - template: /eng/pipelines/common/templates/wasm-library-aot-tests.yml
   parameters:
@@ -385,12 +393,32 @@ jobs:
     runSmokeOnlyArg: $(_runSmokeTestsOnlyArg)
     alwaysRun: ${{ variables.isRollingBuild }}
 
+- template: /eng/pipelines/common/templates/wasm-library-aot-tests.yml
+  parameters:
+    platforms:
+      - Browser_wasm_win
+    nameSuffix: _AOT
+    runAOT: true
+    runSmokeOnlyArg: $(_runSmokeTestsOnlyArg)
+    alwaysRun: ${{ variables.isRollingBuild }}
+
+# Wasm.Build.Tests
 - template: /eng/pipelines/common/templates/wasm-build-tests.yml
   parameters:
     platforms:
       - Browser_wasm
+      - Browser_wasm_win
+    alwaysRun: ${{ variables.isRollingBuild }}
+
+# Wasm Debugger tests
+- template: /eng/pipelines/common/templates/wasm-debugger-tests.yml
+  parameters:
+    platforms:
+      - Browser_wasm
+      - Browser_wasm_win
     alwaysRun: ${{ variables.isRollingBuild }}
 
+# Wasm runtime tests
 - template: /eng/pipelines/common/templates/wasm-runtime-tests.yml
   parameters:
     platforms:
diff --git a/src/mono/sample/wasm/browser-eventpipe/Program.cs b/src/mono/sample/wasm/browser-eventpipe/Program.cs
index 3781b1e4b38..65248020f5d 100644
--- a/src/mono/sample/wasm/browser-eventpipe/Program.cs
+++ b/src/mono/sample/wasm/browser-eventpipe/Program.cs
@@ -77,9 +77,7 @@ public static void Main(string[] args)
 
         public static CancellationToken GetCancellationToken()
         {
-            if (cts == null) {
-                cts = new CancellationTokenSource ();
-            }
+            cts ??= new CancellationTokenSource ();
             return cts.Token;
         }
 
-- 
GitLab