From ce8043b0466a3e107d4ea0ab01500b5a516309dd Mon Sep 17 00:00:00 2001 From: Jan Vorlicek Date: Fri, 31 May 2019 18:46:12 +0200 Subject: [PATCH] Fix overlooked moduleIndex initial value (dotnet/coreclr#24881) When adding the signature copying some time ago, I have overlooked one place where the moduleIndex was set to -1 instead of MODULE_INDEX_NONE. I was using the -1 during the development and replaced it by creating MODULE_INDEX_NONE during final cleanup at all but one places. This caused issues during crossgen even without large version bubble enabled. Methods requiring generic constraint were not crossgen-ed due to this. Commit migrated from https://github.com/dotnet/coreclr/commit/795f2fd2a67047519b477cd1776626368c88e73c --- src/coreclr/src/vm/zapsig.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/src/vm/zapsig.cpp b/src/coreclr/src/vm/zapsig.cpp index 49142460375..08d9228c407 100644 --- a/src/coreclr/src/vm/zapsig.cpp +++ b/src/coreclr/src/vm/zapsig.cpp @@ -1530,7 +1530,7 @@ BOOL ZapSig::EncodeMethod( { _ASSERTE(pConstrainedResolvedToken->cbTypeSpec > 0); - DWORD moduleIndex = (DWORD)-1; + DWORD moduleIndex = MODULE_INDEX_NONE; if (IsReadyToRunCompilation() && pMethod->GetModule()->IsInCurrentVersionBubble() && pInfoModule != (Module *) pConstrainedResolvedToken->tokenScope) { moduleIndex = (*((EncodeModuleCallback)pfnEncodeModule))(pEncodeModuleContext, (Module *) pConstrainedResolvedToken->tokenScope); -- GitLab