From ae49f52e6bd29cd272e3a1c97e2c785ac83a9f1d Mon Sep 17 00:00:00 2001 From: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com> Date: Thu, 16 Jun 2022 23:19:35 +0200 Subject: [PATCH] [wasm] Enabled WriteToReadOnly tests - emscripten bug got fixed (#70814) Fixes #53021. Enabled tests from #53021 - they are passing now because issue reported by @radekdoulik got fixed: https://github.com/emscripten-core/emscripten/issues/14299. --- .../System.IO.FileSystem/tests/File/ReadWriteAllBytes.cs | 1 - .../System.IO.FileSystem/tests/File/ReadWriteAllBytesAsync.cs | 1 - .../System.IO.FileSystem/tests/File/ReadWriteAllLines.cs | 2 -- .../System.IO.FileSystem/tests/File/ReadWriteAllLinesAsync.cs | 1 - .../System.IO.FileSystem/tests/File/ReadWriteAllText.cs | 1 - .../System.IO.FileSystem/tests/File/ReadWriteAllTextAsync.cs | 1 - .../tests/MemoryMappedFile.CreateFromFile.Tests.cs | 2 -- 7 files changed, 9 deletions(-) diff --git a/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllBytes.cs b/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllBytes.cs index bcb3de4825c..a3abe231186 100644 --- a/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllBytes.cs +++ b/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllBytes.cs @@ -86,7 +86,6 @@ public void OpenFile_ThrowsIOException() /// file is allowed. /// [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/53021", TestPlatforms.Browser)] public void WriteToReadOnlyFile() { string path = GetTestFilePath(); diff --git a/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllBytesAsync.cs b/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllBytesAsync.cs index 2c6df24b702..8ae63fe3c9e 100644 --- a/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllBytesAsync.cs +++ b/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllBytesAsync.cs @@ -97,7 +97,6 @@ public async Task OpenFile_ThrowsIOExceptionAsync() /// file is allowed. /// [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/53021", TestPlatforms.Browser)] public async Task WriteToReadOnlyFileAsync() { string path = GetTestFilePath(); diff --git a/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllLines.cs b/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllLines.cs index 99de941c391..bbd5ceeed4c 100644 --- a/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllLines.cs +++ b/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllLines.cs @@ -118,7 +118,6 @@ public void Read_FileNotFound() /// file is allowed. /// [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/53021", TestPlatforms.Browser)] public void WriteToReadOnlyFile() { string path = GetTestFilePath(); @@ -307,7 +306,6 @@ public void Read_FileNotFound() /// file is allowed. /// [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/53021", TestPlatforms.Browser)] public void WriteToReadOnlyFile() { string path = GetTestFilePath(); diff --git a/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllLinesAsync.cs b/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllLinesAsync.cs index 44389dddc8e..17c6e565bc7 100644 --- a/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllLinesAsync.cs +++ b/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllLinesAsync.cs @@ -113,7 +113,6 @@ public async Task OpenFile_ThrowsIOExceptionAsync() /// file is allowed. /// [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/53021", TestPlatforms.Browser)] public async Task WriteToReadOnlyFile() { string path = GetTestFilePath(); diff --git a/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllText.cs b/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllText.cs index 8c9c1e66e72..fd4abc7b601 100644 --- a/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllText.cs +++ b/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllText.cs @@ -131,7 +131,6 @@ public void Read_FileNotFound() /// file is allowed. /// [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/53021", TestPlatforms.Browser)] public void WriteToReadOnlyFile() { string path = GetTestFilePath(); diff --git a/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllTextAsync.cs b/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllTextAsync.cs index 660daf3437e..0c9d7cb699c 100644 --- a/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllTextAsync.cs +++ b/src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllTextAsync.cs @@ -122,7 +122,6 @@ public async Task OpenFile_ThrowsIOExceptionAsync() /// file is allowed. /// [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/53021", TestPlatforms.Browser)] public async Task WriteToReadOnlyFileAsync() { string path = GetTestFilePath(); diff --git a/src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedFile.CreateFromFile.Tests.cs b/src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedFile.CreateFromFile.Tests.cs index e99b727ebec..5e92b74b94d 100644 --- a/src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedFile.CreateFromFile.Tests.cs +++ b/src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedFile.CreateFromFile.Tests.cs @@ -699,7 +699,6 @@ private void WriteToReadOnlyFile(MemoryMappedFileAccess access, bool succeeds) [Theory] [InlineData(MemoryMappedFileAccess.Read)] [InlineData(MemoryMappedFileAccess.ReadWrite)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/53021", TestPlatforms.Browser)] public void WriteToReadOnlyFile_ReadWrite(MemoryMappedFileAccess access) { WriteToReadOnlyFile(access, access == MemoryMappedFileAccess.Read || @@ -707,7 +706,6 @@ public void WriteToReadOnlyFile_ReadWrite(MemoryMappedFileAccess access) } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/53021", TestPlatforms.Browser)] public void WriteToReadOnlyFile_CopyOnWrite() { WriteToReadOnlyFile(MemoryMappedFileAccess.CopyOnWrite, PlatformDetection.IsSuperUser); -- GitLab