diff --git a/eng/Versions.props b/eng/Versions.props index 3588f19c0d159c40c844da280626912dfd736e04..20e000651fb20de98f3cedc869b03433c46f1d88 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -63,7 +63,7 @@ 5.0.0-beta.20261.9 5.0.0-beta.20261.9 5.0.0-beta.20261.9 - 2.5.1-beta.20261.9 + 2.5.1-beta.20264.3 5.0.0-beta.20261.9 5.0.0-beta.20261.9 5.0.0-beta.20261.9 diff --git a/src/coreclr/build-test.cmd b/src/coreclr/build-test.cmd index 9247e81cab9a907063ccbdb6764b368188217eb6..01a41c0a91118a4fcf4c2ac4fab90c268c7b99d5 100644 --- a/src/coreclr/build-test.cmd +++ b/src/coreclr/build-test.cmd @@ -652,15 +652,17 @@ for %%F in ("%CORE_ROOT%\System.*.dll";"%CORE_ROOT%\Microsoft.*.dll";%CORE_ROOT% ))))) ) -echo Composite response line^: %__CompositeResponseFile% -type "%__CompositeResponseFile%" +if defined __CompositeBuildMode ( + echo Composite response line^: %__CompositeResponseFile% + type "%__CompositeResponseFile%" +) if defined __CompositeBuildMode ( - set __CompositeCommandLine="%CORE_ROOT%\corerun" + set __CompositeCommandLine="%__RepoRootDir%\dotnet.cmd" set __CompositeCommandLine=!__CompositeCommandLine! "%CORE_ROOT%\crossgen2\crossgen2.dll" set __CompositeCommandLine=!__CompositeCommandLine! "@%__CompositeResponseFile%" echo Building composite R2R framework^: !__CompositeCommandLine! - !__CompositeCommandLine! + call !__CompositeCommandLine! set __FailedToPrecompile=!ERRORLEVEL! copy /Y "!__CompositeOutputDir!\*.*" "!CORE_ROOT!\" ) @@ -684,7 +686,7 @@ if /i "%__BuildArch%" == "arm64" ( set __CrossgenExe="%__BinDir%\x64\crossgen.ex set __CrossgenExe=%__CrossgenExe% if defined __DoCrossgen2 ( - set __CrossgenExe="%CORE_ROOT%\corerun" "%__BinDir%\crossgen2\crossgen2.dll" + set __CrossgenExe="%__RepoRootDir%\dotnet.cmd" "%CORE_ROOT%\crossgen2\crossgen2.dll" ) REM Intentionally avoid using the .dll extension to prevent @@ -694,12 +696,14 @@ set __CrossgenCmd= if defined __DoCrossgen ( set __CrossgenCmd=!__CrossgenExe! /Platform_Assemblies_Paths "!CORE_ROOT!" /in !AssemblyPath! /out !__CrossgenOutputFile! + echo !__CrossgenCmd! + !__CrossgenCmd! ) else ( set __CrossgenCmd=!__CrossgenExe! -r:"!CORE_ROOT!\System.*.dll" -r:"!CORE_ROOT!\Microsoft.*.dll" -r:"!CORE_ROOT!\mscorlib.dll" -r:"!CORE_ROOT!\netstandard.dll" -O --inputbubble --out:!__CrossgenOutputFile! !AssemblyPath! + echo !__CrossgenCmd! + call !__CrossgenCmd! ) -echo %__CrossgenCmd% -%__CrossgenCmd% set /a __exitCode = !errorlevel! set /a "%~3+=1" diff --git a/src/coreclr/build-test.sh b/src/coreclr/build-test.sh index 46675133e1f0a97772ffac964652031511fc0ab5..78d294bd83564f466ee9382cfb1ef5dc4cb49abd 100755 --- a/src/coreclr/build-test.sh +++ b/src/coreclr/build-test.sh @@ -180,8 +180,8 @@ precompile_coreroot_fx() local totalPrecompiled=0 local failedToPrecompile=0 - local compositeCommandLine="$overlayDir/corerun" - compositeCommandLine+=" ${__BinDir}/crossgen2/crossgen2.dll" + local compositeCommandLine="${__DotNetCli}" + compositeCommandLine+=" $__BinDir/crossgen2/crossgen2.dll" compositeCommandLine+=" --composite" compositeCommandLine+=" -O" compositeCommandLine+=" --out:$outputDir/framework-r2r.dll" @@ -206,7 +206,7 @@ precompile_coreroot_fx() fi if [[ "$__DoCrossgen2" != 0 ]]; then - commandLine="$overlayDir/corerun $overlayDir/crossgen2/crossgen2.dll $crossgen2References -O --inputbubble --out $outputDir/$(basename $filename) $filename" + commandLine="${__DotNetCli} $overlayDir/crossgen2/crossgen2.dll $crossgen2References -O --inputbubble --out $outputDir/$(basename $filename) $filename" fi echo Precompiling "$filename" diff --git a/src/coreclr/tests/helixpublishwitharcade.proj b/src/coreclr/tests/helixpublishwitharcade.proj index c7aa3174852f925a783773342d213e13efa0066d..6d46021c28e838fa37973478b5c9c3e6073545f4 100644 --- a/src/coreclr/tests/helixpublishwitharcade.proj +++ b/src/coreclr/tests/helixpublishwitharcade.proj @@ -5,7 +5,7 @@ to send test jobs to helix. --> - + @@ -33,10 +33,14 @@ RunInUnloadableContext=$(_RunInUnloadableContext); TimeoutPerTestCollectionInMinutes=$(_TimeoutPerTestCollectionInMinutes); TimeoutPerTestInMinutes=$(_TimeoutPerTestInMinutes); - RuntimeMode=$(_RuntimeMode) + RuntimeMode=$(_RuntimeMode); + BundledNETCoreAppPackageVersion=$(BundledNETCoreAppPackageVersion) + + + @@ -59,12 +63,24 @@ + + + win-$(TargetArchitecture) + osx-$(TargetArchitecture) + linux-$(TargetArchitecture) + + $([MSBuild]::NormalizeDirectory($(TestWorkingDir))) $(BinDir)Tests\Core_Root\ $(BinDir)Payloads\ SetStressModes_$(Scenario).cmd SetStressModes_$(Scenario).sh + + true + runtime + $(BundledNETCoreAppPackageVersion) + $(HelixRuntimeRid) @@ -236,12 +252,10 @@ - %CORE_ROOT%\CoreRun.exe %CORE_ROOT%\xunit.console.dll - $CORE_ROOT/corerun $CORE_ROOT/xunit.console.dll @@ -263,12 +277,13 @@ %(PayloadDirectory) - $(CoreRun) $(XUnitRunnerDll) %(XUnitWrapperDlls) $(XUnitRunnerArgs) - $(CoreRun) $(XUnitRunnerDll) %(XUnitWrapperDlls) $(XUnitRunnerArgs) -trait TestGroup=%(TestGroup) + dotnet $(XUnitRunnerDll) %(XUnitWrapperDlls) $(XUnitRunnerArgs) + dotnet $(XUnitRunnerDll) %(XUnitWrapperDlls) $(XUnitRunnerArgs) -trait TestGroup=%(TestGroup) $([System.TimeSpan]::FromMinutes($(TimeoutPerTestCollectionInMinutes))) + diff --git a/src/coreclr/tests/runtest.py b/src/coreclr/tests/runtest.py index 68444d5d440890cccb27063ec365e6537490ffcf..e5ef2b0528ed1fae777de7c62af790505a4093ba 100755 --- a/src/coreclr/tests/runtest.py +++ b/src/coreclr/tests/runtest.py @@ -934,6 +934,9 @@ def run_tests(args, print("Setting CORE_ROOT=%s" % args.core_root) os.environ["CORE_ROOT"] = args.core_root + # Set __TestDotNetCmd so tests which need to run dotnet can use the repo-local script on dev boxes + os.environ["__TestDotNetCmd"] = args.dotnetcli_script_path + # Set test env script path if it is set. if test_env_script_path is not None: print("Setting __TestEnv=%s" % test_env_script_path) diff --git a/src/coreclr/tests/src/CLRTest.CrossGen.targets b/src/coreclr/tests/src/CLRTest.CrossGen.targets index 00c9990b19d2781e307c6dd7cb17b40a2f618d81..0dcc732202f752fb1185ac2d899f0ae0aa4b157a 100644 --- a/src/coreclr/tests/src/CLRTest.CrossGen.targets +++ b/src/coreclr/tests/src/CLRTest.CrossGen.targets @@ -83,7 +83,12 @@ if [ ! -z ${RunCrossGen2+x} ]%3B then rm $__ResponseFile __Command=$_DebuggerFullPath - __Command+=" $CORE_ROOT/corerun" + # Tests run locally need __TestDotNetCmd (set by runtest.py) or a compatible 5.0 dotnet runtime in the path + if [ ! -z ${__TestDotNetCmd+x} ] %3B then + __Command+=" $__TestDotNetCmd" + else + __Command+=" dotnet" + fi __Command+=" $CORE_ROOT/crossgen2/crossgen2.dll" __Command+=" @$__ResponseFile" __Command+=" $ExtraCrossGen2Args" @@ -178,7 +183,12 @@ if defined RunCrossGen2 ( del /Q !__ResponseFile! set __Command=!_DebuggerFullPath! - set __Command=!__Command! "!CORE_ROOT!\CoreRun.exe" + REM Tests run locally need __TestDotNetCmd (set by runtest.py) or a compatible 5.0 dotnet runtime in the path + if defined __TestDotNetCmd ( + set __Command=!__Command! "!__TestDotNetCmd!" + ) else ( + set __Command=!__Command! "dotnet" + ) set __Command=!__Command! "!CORE_ROOT!\crossgen2\crossgen2.dll" set __Command=!__Command! @"!__ResponseFile!" set __Command=!__Command! !ExtraCrossGen2Args! diff --git a/src/coreclr/tests/src/Common/Directory.Build.targets b/src/coreclr/tests/src/Common/Directory.Build.targets index c4e3b79c5eddb9bf69c0ecd0267778bbb6b3a5b9..65ff6bd2759461b148175b6538ebaa24f4aa8680 100644 --- a/src/coreclr/tests/src/Common/Directory.Build.targets +++ b/src/coreclr/tests/src/Common/Directory.Build.targets @@ -58,26 +58,37 @@ - + + True + - + + True + + +