From 684fe413df1ebd7695e2c07ae4c6202ab0d59a39 Mon Sep 17 00:00:00 2001
From: Maxim Lipnin <v-maxlip@microsoft.com>
Date: Thu, 3 Feb 2022 20:13:52 +0300
Subject: [PATCH] Disable some library tests on ARMv6 architecture due to
 failures (#64733)

Related issues:

[mono][arm6][linux] System.Net.Ping.Functional.Tests failed #64673
[mono][arm6][linux] System.Net.Tests.ServicePointManagerTest.FindServicePoint_Collectible failed. #64674
[mono][arm6][linux] System.Reflection.Tests.ModuleTests.GetField failed #64675

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
---
 .../Common/tests/TestUtilities/System/PlatformDetection.cs   | 1 +
 .../System.Net.ServicePoint/tests/ServicePointManagerTest.cs | 1 +
 .../System.Runtime/tests/System/Reflection/ModuleTests.cs    | 1 +
 src/libraries/tests.proj                                     | 5 +++++
 4 files changed, 8 insertions(+)

diff --git a/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs b/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
index db1af4f4fba..b35772c86df 100644
--- a/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
+++ b/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
@@ -51,6 +51,7 @@ public static partial class PlatformDetection
         public static bool IsNotArm64Process => !IsArm64Process;
         public static bool IsArmOrArm64Process => IsArmProcess || IsArm64Process;
         public static bool IsNotArmNorArm64Process => !IsArmOrArm64Process;
+        public static bool IsArmv6Process => (int)RuntimeInformation.ProcessArchitecture == 7; // Architecture.Armv6
         public static bool IsX86Process => RuntimeInformation.ProcessArchitecture == Architecture.X86;
         public static bool IsNotX86Process => !IsX86Process;
         public static bool IsArgIteratorSupported => IsMonoRuntime || (IsWindows && IsNotArmProcess && !IsNativeAot);
diff --git a/src/libraries/System.Net.ServicePoint/tests/ServicePointManagerTest.cs b/src/libraries/System.Net.ServicePoint/tests/ServicePointManagerTest.cs
index fac9de7a8e8..b132ae14edf 100644
--- a/src/libraries/System.Net.ServicePoint/tests/ServicePointManagerTest.cs
+++ b/src/libraries/System.Net.ServicePoint/tests/ServicePointManagerTest.cs
@@ -284,6 +284,7 @@ public static void FindServicePoint_ReturnsCachedServicePoint()
 
         [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
         [ActiveIssue("https://github.com/dotnet/runtime/issues/36217", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoInterpreter))]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/64674", typeof(PlatformDetection), nameof(PlatformDetection.IsArmv6Process))]
         public static void FindServicePoint_Collectible()
         {
             RemoteExecutor.Invoke(() =>
diff --git a/src/libraries/System.Runtime/tests/System/Reflection/ModuleTests.cs b/src/libraries/System.Runtime/tests/System/Reflection/ModuleTests.cs
index cbc795b9af3..05b4c65cf29 100644
--- a/src/libraries/System.Runtime/tests/System/Reflection/ModuleTests.cs
+++ b/src/libraries/System.Runtime/tests/System/Reflection/ModuleTests.cs
@@ -164,6 +164,7 @@ public void GetField_NullName()
 
         [Fact]
         [ActiveIssue("https://github.com/dotnet/runtime/issues/60558", TestPlatforms.Android)]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/64675", typeof(PlatformDetection), nameof(PlatformDetection.IsArmv6Process))]
         public void GetField()
         {
             FieldInfo testInt = TestModule.GetField("TestInt", BindingFlags.Public | BindingFlags.Static);
diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj
index 2e5554df5bc..7ae2f5547fe 100644
--- a/src/libraries/tests.proj
+++ b/src/libraries/tests.proj
@@ -47,6 +47,11 @@ Roslyn4.0.Tests.csproj" />
     <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Transactions.Local\tests\System.Transactions.Local.Tests.csproj" />
   </ItemGroup>
 
+  <ItemGroup Condition="'$(TargetArchitecture)' == 'ARMv6'">
+    <!-- https://github.com/dotnet/runtime/issues/64673 -->
+    <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Net.Ping\tests\FunctionalTests\System.Net.Ping.Functional.Tests.csproj" />
+  </ItemGroup>
+
   <ItemGroup Condition="'$(TargetsMobile)' == 'true' or '$(TargetArchitecture)' == 'ARMv6'">
     <!-- DllImportGenerator runtime tests depend on DNNE, which does not support mobile platforms. -->
     <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.InteropServices\tests\DllImportGenerator.Tests\DllImportGenerator.Tests.csproj" />
-- 
GitLab