diff --git a/eng/pipelines/libraries/.azure-ci.yml b/eng/pipelines/libraries/.azure-ci.yml index de5c4e809703eee09271de45ebaad5d948f57fc7..4a4e9aa8ccea5a1e2f1361773ddcf30a11095ee5 100644 --- a/eng/pipelines/libraries/.azure-ci.yml +++ b/eng/pipelines/libraries/.azure-ci.yml @@ -8,11 +8,20 @@ trigger: include: - master - release/3.0 + paths: + exclude: + - Documentation/* + - /*.md -# TODO: add paths to exclude CI when modifying docs or stuff not affecting the build pr: -- master -- release/3.0 + branches: + include: + - master + - release/3.0 + paths: + exclude: + - Documentation/* + - /*.md resources: containers: diff --git a/eng/pipelines/libraries/corefx-base.yml b/eng/pipelines/libraries/corefx-base.yml index 4db5f431197e575db0390ad612e0c364024f8ca7..9c23a1fb7db10a3180162e15f3e2c6b57a4d6953 100644 --- a/eng/pipelines/libraries/corefx-base.yml +++ b/eng/pipelines/libraries/corefx-base.yml @@ -198,19 +198,14 @@ jobs: msbuildScript: $(_msbuildCommand) framework: $(_framework) outerloop: $(_outerloop) - enableAzurePipelinesReporter: false ${{ if eq(parameters.isOfficialBuild, 'true') }}: - isExternal: false - waitForCompletion: false officialBuildId: $(Build.BuildNumber) helixToken: $(HelixApiAccessToken) ${{ if eq(parameters.isOfficialBuild, 'false') }}: # TODO: SET Creator to the PR owner whenever Azure DevOps supports a good way to retrieve it. creator: dotnet-bot - isExternal: true - waitForCompletion: true helixToken: '' - ${{ if eq(parameters.isOfficialBuild, 'true') }}: diff --git a/eng/pipelines/libraries/helix.yml b/eng/pipelines/libraries/helix.yml index cf1bf9d838229a420a85a59da4baedf536a766cc..68073f8983e5cb9068bd60eb06e49e388864f29d 100644 --- a/eng/pipelines/libraries/helix.yml +++ b/eng/pipelines/libraries/helix.yml @@ -5,12 +5,9 @@ parameters: framework: '' helixQueues: '' helixToken: '' - isExternal: '' # true | false msbuildScript: '' targetOS: '' - waitForCompletion: '' # true | false officialBuildId: '' - enableAzurePipelinesReporter: '' # true | false outerloop: '' # true | false condition: always() @@ -26,11 +23,8 @@ steps: /p:HelixTargetQueues=${{ parameters.helixQueues }} /p:HelixBuild=$(Build.BuildNumber) /p:HelixAccessToken=${{ parameters.helixToken }} - /p:WaitForWorkItemCompletion=${{ parameters.waitForCompletion }} - /p:IsExternal=${{ parameters.isExternal }} /p:Creator=${{ parameters.creator }} /p:OfficialBuildId=${{ parameters.officialBuildId }} - /p:EnableAzurePipelinesReporter=${{ parameters.enableAzurePipelinesReporter }} /bl:$(Build.SourcesDirectory)/artifacts/log/$(_BuildConfig)/SendToHelix.binlog displayName: Send to Helix condition: and(succeeded(), ${{ parameters.condition }}) diff --git a/eng/pipelines/libraries/windows.yml b/eng/pipelines/libraries/windows.yml index 09610eac20e02d42c82fad4265fe26fb52f75a37..c6bca6c1f9182b26e928328a0c3653fb323a27ad 100644 --- a/eng/pipelines/libraries/windows.yml +++ b/eng/pipelines/libraries/windows.yml @@ -167,8 +167,6 @@ jobs: submitToHelix: true buildExtraArguments: /p:RuntimeOS=win10 - # azure pipelines reporter only supports xunit results based tests. - enableAzurePipelinesReporter: false variables: - _outerloop: false diff --git a/eng/sendtohelix.proj b/eng/sendtohelix.proj index 32e88f15099269df76dfd1efcd5216a462b1f05d..5b07f7fe4da7ac392b64d2c577fe88b9f62faf70 100644 --- a/eng/sendtohelix.proj +++ b/eng/sendtohelix.proj @@ -32,19 +32,7 @@ $(BuildConfiguration)- PackageTests-$(ConfigurationGroup)-$(ArchGroup) - 4 - - - - - true - false - - - - - true - false + $(WaitForWorkItemCompletion) diff --git a/src/libraries/Microsoft.VisualBasic.Core/tests/Configurations.props b/src/libraries/Microsoft.VisualBasic.Core/tests/Configurations.props index 0ea07aa8f9a7bc22a77474953a62736b3d78e5ec..acf56fa2750edf0a2ee74cb48b217910d70f50eb 100644 --- a/src/libraries/Microsoft.VisualBasic.Core/tests/Configurations.props +++ b/src/libraries/Microsoft.VisualBasic.Core/tests/Configurations.props @@ -3,7 +3,6 @@ netcoreapp; uap; - netfx; \ No newline at end of file diff --git a/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs b/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs index 191830beb5c2911808c8753d48744a02274a9f1b..2f19b9141713c1de2743317ebe5db79cf0919eca 100644 --- a/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs +++ b/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs @@ -1471,6 +1471,7 @@ public void TestHandleCount_OSX() } } + [ActiveIssue(37325)] [Fact] [PlatformSpecific(TestPlatforms.Linux | TestPlatforms.Windows)] // Expected process HandleCounts differs on OSX [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Handle count change is not reliable, but seems less robust on NETFX")] diff --git a/src/libraries/System.Drawing.Common/tests/Printing/PrintDocumentTests.cs b/src/libraries/System.Drawing.Common/tests/Printing/PrintDocumentTests.cs index ec531646b8f17dd7de11538739b1bfab8fa0d817..ab6a7c3dc5ad3d9ec86d74753ec2e38e2d3edb01 100644 --- a/src/libraries/System.Drawing.Common/tests/Printing/PrintDocumentTests.cs +++ b/src/libraries/System.Drawing.Common/tests/Printing/PrintDocumentTests.cs @@ -169,6 +169,7 @@ public void BeginPrint_SetValue_ReturnsExpected() } [ActiveIssue(20884, TestPlatforms.AnyUnix)] + [ActiveIssue(30223)] [ConditionalFact(Helpers.AnyInstalledPrinters, Helpers.IsDrawingSupported)] public void EndPrint_SetValue_ReturnsExpected() { diff --git a/src/libraries/System.IO.Pipelines/tests/PipeWriterTests.cs b/src/libraries/System.IO.Pipelines/tests/PipeWriterTests.cs index 0ae5110673bb786e2c8b55f40b73e00cb5053829..68ad54fae7e407cf286ef456dae70135a0c9c24c 100644 --- a/src/libraries/System.IO.Pipelines/tests/PipeWriterTests.cs +++ b/src/libraries/System.IO.Pipelines/tests/PipeWriterTests.cs @@ -233,6 +233,7 @@ public async Task WritesUsingGetMemoryWorks() pipe.Reader.Complete(); } + [ActiveIssue(37239)] [Fact] public async Task CompleteWithLargeWriteThrows() { diff --git a/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http2.cs b/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http2.cs index 176b4093e8b6c1bb848df7e124c0dfe441fac19c..bb5fc03d8a1bcb1d8ea3188281d61f27512db941 100644 --- a/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http2.cs +++ b/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http2.cs @@ -194,6 +194,7 @@ public async Task Http2_ServerSendsValidSettingsValues_Success() } } + [ActiveIssue(35466)] [ConditionalTheory(nameof(SupportsAlpn))] [InlineData(SettingId.MaxFrameSize, 16383, ProtocolErrors.PROTOCOL_ERROR, true)] [InlineData(SettingId.MaxFrameSize, 162777216, ProtocolErrors.PROTOCOL_ERROR, true)] diff --git a/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs b/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs index daaa2c1e14b07b8b45a411c8fbc2cdffc8e40123..09fb6005c319dcb5f399c219bd658adeb7c0bf18 100644 --- a/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs +++ b/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs @@ -65,6 +65,7 @@ public void MulticastOption_CreateSocketSetGetOption_GroupAndInterfaceIndex_SetS } } + [ActiveIssue(31609, TargetFrameworkMonikers.Uap)] [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))] // Skip on Nano: dotnet/corefx #29929 public async Task MulticastInterface_Set_AnyInterface_Succeeds() { @@ -129,6 +130,7 @@ public void MulticastInterface_Set_InvalidIndex_Throws() } } + [ActiveIssue(31609, TargetFrameworkMonikers.Uap)] [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))] // Skip on Nano: dotnet/corefx #29929 [PlatformSpecific(~TestPlatforms.OSX)] public async Task MulticastInterface_Set_IPv6_AnyInterface_Succeeds()