Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
dotNET Platform
fsharp
提交
c8acf2ac
F
fsharp
项目概览
dotNET Platform
/
fsharp
11 个月 前同步成功
通知
0
Star
1
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
F
fsharp
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
c8acf2ac
编写于
12月 20, 2022
作者:
R
Ross Kuehl
提交者:
GitHub
12月 20, 2022
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Use logical operator name to check for logical ternary operator (#14495)
上级
85543b5b
变更
3
显示空白变更内容
内联
并排
Showing
3 changed file
with
29 addition
and
6 deletion
+29
-6
src/Compiler/Checking/CheckExpressions.fs
src/Compiler/Checking/CheckExpressions.fs
+7
-6
tests/FSharp.Compiler.ComponentTests/FSharp.Compiler.ComponentTests.fsproj
...iler.ComponentTests/FSharp.Compiler.ComponentTests.fsproj
+1
-0
tests/FSharp.Compiler.ComponentTests/Language/DynamicAssignmentOperatorTests.fs
...ComponentTests/Language/DynamicAssignmentOperatorTests.fs
+21
-0
未找到文件。
src/Compiler/Checking/CheckExpressions.fs
浏览文件 @
c8acf2ac
...
@@ -1015,15 +1015,16 @@ let MakeMemberDataAndMangledNameForMemberVal(g, tcref, isExtrinsic, attrs, implS
...
@@ -1015,15 +1015,16 @@ let MakeMemberDataAndMangledNameForMemberVal(g, tcref, isExtrinsic, attrs, implS
if not isCompGen && IsLogicalInfixOpName id.idText then
if not isCompGen && IsLogicalInfixOpName id.idText then
let m = id.idRange
let m = id.idRange
let name = ConvertValLogicalNameToDisplayNameCore id.idText
let logicalName = id.idText
let displayName = ConvertValLogicalNameToDisplayNameCore logicalName
// Check symbolic members. Expect valSynData implied arity to be [[2]].
// Check symbolic members. Expect valSynData implied arity to be [[2]].
match SynInfo.AritiesOfArgs valSynData with
match SynInfo.AritiesOfArgs valSynData with
| [] | [0] -> warning(Error(FSComp.SR.memberOperatorDefinitionWithNoArguments
n
ame, m))
| [] | [0] -> warning(Error(FSComp.SR.memberOperatorDefinitionWithNoArguments
displayN
ame, m))
| n :: otherArgs ->
| n :: otherArgs ->
let opTakesThreeArgs = IsLogicalTernaryOperator
n
ame
let opTakesThreeArgs = IsLogicalTernaryOperator
logicalN
ame
if n<>2 && not opTakesThreeArgs then warning(Error(FSComp.SR.memberOperatorDefinitionWithNonPairArgument(
n
ame, n), m))
if n<>2 && not opTakesThreeArgs then warning(Error(FSComp.SR.memberOperatorDefinitionWithNonPairArgument(
displayN
ame, n), m))
if n<>3 && opTakesThreeArgs then warning(Error(FSComp.SR.memberOperatorDefinitionWithNonTripleArgument(
n
ame, n), m))
if n<>3 && opTakesThreeArgs then warning(Error(FSComp.SR.memberOperatorDefinitionWithNonTripleArgument(
displayN
ame, n), m))
if not (isNil otherArgs) then warning(Error(FSComp.SR.memberOperatorDefinitionWithCurriedArguments
n
ame, m))
if not (isNil otherArgs) then warning(Error(FSComp.SR.memberOperatorDefinitionWithCurriedArguments
displayN
ame, m))
if isExtrinsic && IsLogicalOpName id.idText then
if isExtrinsic && IsLogicalOpName id.idText then
warning(Error(FSComp.SR.tcMemberOperatorDefinitionInExtrinsic(), id.idRange))
warning(Error(FSComp.SR.tcMemberOperatorDefinitionInExtrinsic(), id.idRange))
...
...
tests/FSharp.Compiler.ComponentTests/FSharp.Compiler.ComponentTests.fsproj
浏览文件 @
c8acf2ac
...
@@ -173,6 +173,7 @@
...
@@ -173,6 +173,7 @@
<Compile
Include=
"Language\CodeQuotationTests.fs"
/>
<Compile
Include=
"Language\CodeQuotationTests.fs"
/>
<Compile
Include=
"Language\InterpolatedStringsTests.fs"
/>
<Compile
Include=
"Language\InterpolatedStringsTests.fs"
/>
<Compile
Include=
"Language\ComputationExpressionTests.fs"
/>
<Compile
Include=
"Language\ComputationExpressionTests.fs"
/>
<Compile
Include=
"Language\DynamicAssignmentOperatorTests.fs"
/>
<Compile
Include=
"Language\CastingTests.fs"
/>
<Compile
Include=
"Language\CastingTests.fs"
/>
<Compile
Include=
"Language\NameofTests.fs"
/>
<Compile
Include=
"Language\NameofTests.fs"
/>
<Compile
Include=
"Language\ExtensionMethodTests.fs"
/>
<Compile
Include=
"Language\ExtensionMethodTests.fs"
/>
...
...
tests/FSharp.Compiler.ComponentTests/Language/DynamicAssignmentOperatorTests.fs
0 → 100644
浏览文件 @
c8acf2ac
// Copyright (c) Microsoft Corporation. All Rights Reserved. See License.txt in the project root for license information.
namespace
FSharp
.
Compiler
.
ComponentTests
.
Language
open
System
open
Xunit
open
FSharp
.
Test
.
Compiler
module
DynamicAssignmentOperatorTests
=
[<
Theory
>]
[<
InlineData
(
"6.0"
)>]
[<
InlineData
(
"7.0"
)>]
let
``Implementing dynamic assignment operator does not produce a warning``
version
=
Fsx
"""
type T = T with
static member inline (?<-) (f, x, y) = f x y
"""
|>
withLangVersion
version
|>
compile
|>
shouldSucceed
\ No newline at end of file
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录