From da09320d1496259e8e8a706108b9eb22accc4f35 Mon Sep 17 00:00:00 2001 From: hujie Date: Thu, 11 Oct 2018 18:01:58 +0800 Subject: [PATCH] clean Attention: delete line 37 of the MixAllTest.java --- .../rocketmq/acl/plug/AclPlugController.java | 20 +++++++++---------- ...ingServer.java => AclRemotingService.java} | 2 +- ...ava => DefaultAclRemotingServiceImpl.java} | 4 ++-- ...enticationInfoManagementAclPlugEngine.java | 10 +++++----- .../plug/engine/LoginInfoAclPlugEngine.java | 6 +++--- .../acl/plug/engine/PlainAclPlugEngine.java | 8 ++++---- ...sEntity.java => ControllerParameters.java} | 2 +- .../plug/engine/PlainAclPlugEngineTest.java | 6 +++--- .../rocketmq/broker/BrokerController.java | 15 +++++++------- .../apache/rocketmq/common/MixAllTest.java | 5 ++--- 10 files changed, 38 insertions(+), 40 deletions(-) rename acl-plug/src/main/java/org/apache/rocketmq/acl/plug/{AclRemotingServer.java => AclRemotingService.java} (96%) rename acl-plug/src/main/java/org/apache/rocketmq/acl/plug/{DefaultAclRemotingServerImpl.java => DefaultAclRemotingServiceImpl.java} (93%) rename acl-plug/src/main/java/org/apache/rocketmq/acl/plug/entity/{ControllerParametersEntity.java => ControllerParameters.java} (97%) diff --git a/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/AclPlugController.java b/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/AclPlugController.java index c32ec733..c61e122b 100644 --- a/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/AclPlugController.java +++ b/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/AclPlugController.java @@ -18,32 +18,32 @@ package org.apache.rocketmq.acl.plug; import org.apache.rocketmq.acl.plug.engine.AclPlugEngine; import org.apache.rocketmq.acl.plug.engine.PlainAclPlugEngine; -import org.apache.rocketmq.acl.plug.entity.ControllerParametersEntity; +import org.apache.rocketmq.acl.plug.entity.ControllerParameters; import org.apache.rocketmq.acl.plug.exception.AclPlugRuntimeException; public class AclPlugController { - private ControllerParametersEntity controllerParametersEntity; + private ControllerParameters controllerParameters; private AclPlugEngine aclPlugEngine; - private AclRemotingServer aclRemotingServer; + private AclRemotingService aclRemotingService; private boolean startSucceed = false; - public AclPlugController(ControllerParametersEntity controllerParametersEntity) throws AclPlugRuntimeException { + public AclPlugController(ControllerParameters controllerParameters) throws AclPlugRuntimeException { try { - this.controllerParametersEntity = controllerParametersEntity; - aclPlugEngine = new PlainAclPlugEngine(controllerParametersEntity); - aclRemotingServer = new DefaultAclRemotingServerImpl(aclPlugEngine); + this.controllerParameters = controllerParameters; + aclPlugEngine = new PlainAclPlugEngine(controllerParameters); + aclRemotingService = new DefaultAclRemotingServiceImpl(aclPlugEngine); this.startSucceed = true; } catch (Exception e) { - throw new AclPlugRuntimeException(String.format("Start the abnormal , Launch parameters is %s", this.controllerParametersEntity.toString()), e); + throw new AclPlugRuntimeException(String.format("Start the abnormal , Launch parameters is %s", this.controllerParameters.toString()), e); } } - public AclRemotingServer getAclRemotingServer() { - return this.aclRemotingServer; + public AclRemotingService getAclRemotingService() { + return this.aclRemotingService; } public void doChannelCloseEvent(String remoteAddr) { diff --git a/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/AclRemotingServer.java b/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/AclRemotingService.java similarity index 96% rename from acl-plug/src/main/java/org/apache/rocketmq/acl/plug/AclRemotingServer.java rename to acl-plug/src/main/java/org/apache/rocketmq/acl/plug/AclRemotingService.java index ded9f80c..c651a5d9 100644 --- a/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/AclRemotingServer.java +++ b/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/AclRemotingService.java @@ -19,7 +19,7 @@ package org.apache.rocketmq.acl.plug; import org.apache.rocketmq.acl.plug.entity.AccessControl; import org.apache.rocketmq.acl.plug.entity.AuthenticationResult; -public interface AclRemotingServer { +public interface AclRemotingService { public AuthenticationResult check(AccessControl accessControl); diff --git a/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/DefaultAclRemotingServerImpl.java b/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/DefaultAclRemotingServiceImpl.java similarity index 93% rename from acl-plug/src/main/java/org/apache/rocketmq/acl/plug/DefaultAclRemotingServerImpl.java rename to acl-plug/src/main/java/org/apache/rocketmq/acl/plug/DefaultAclRemotingServiceImpl.java index 4ea14b48..240c9a24 100644 --- a/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/DefaultAclRemotingServerImpl.java +++ b/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/DefaultAclRemotingServiceImpl.java @@ -21,11 +21,11 @@ import org.apache.rocketmq.acl.plug.entity.AccessControl; import org.apache.rocketmq.acl.plug.entity.AuthenticationResult; import org.apache.rocketmq.acl.plug.exception.AclPlugRuntimeException; -public class DefaultAclRemotingServerImpl implements AclRemotingServer { +public class DefaultAclRemotingServiceImpl implements AclRemotingService { private AclPlugEngine aclPlugEngine; - public DefaultAclRemotingServerImpl(AclPlugEngine aclPlugEngine) { + public DefaultAclRemotingServiceImpl(AclPlugEngine aclPlugEngine) { this.aclPlugEngine = aclPlugEngine; } diff --git a/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/engine/AuthenticationInfoManagementAclPlugEngine.java b/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/engine/AuthenticationInfoManagementAclPlugEngine.java index a6c73930..44b5245a 100644 --- a/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/engine/AuthenticationInfoManagementAclPlugEngine.java +++ b/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/engine/AuthenticationInfoManagementAclPlugEngine.java @@ -25,7 +25,7 @@ import org.apache.rocketmq.acl.plug.entity.AccessControl; import org.apache.rocketmq.acl.plug.entity.AuthenticationInfo; import org.apache.rocketmq.acl.plug.entity.AuthenticationResult; import org.apache.rocketmq.acl.plug.entity.BorkerAccessControlTransport; -import org.apache.rocketmq.acl.plug.entity.ControllerParametersEntity; +import org.apache.rocketmq.acl.plug.entity.ControllerParameters; import org.apache.rocketmq.acl.plug.exception.AclPlugRuntimeException; import org.apache.rocketmq.acl.plug.strategy.NetaddressStrategy; import org.apache.rocketmq.acl.plug.strategy.NetaddressStrategyFactory; @@ -36,16 +36,16 @@ import org.apache.rocketmq.logging.InternalLoggerFactory; public abstract class AuthenticationInfoManagementAclPlugEngine implements AclPlugEngine { private static final InternalLogger log = InternalLoggerFactory.getLogger(LoggerName.ACL_PLUG_LOGGER_NAME); - ControllerParametersEntity controllerParametersEntity; + ControllerParameters controllerParameters; private Map> accessControlMap = new HashMap<>(); private AuthenticationInfo authenticationInfo; private NetaddressStrategyFactory netaddressStrategyFactory = new NetaddressStrategyFactory(); private AccessContralAnalysis accessContralAnalysis = new AccessContralAnalysis(); private Authentication authentication = new Authentication(); - public AuthenticationInfoManagementAclPlugEngine(ControllerParametersEntity controllerParametersEntity) { - this.controllerParametersEntity = controllerParametersEntity; - accessContralAnalysis.analysisClass(controllerParametersEntity.getAccessContralAnalysisClass()); + public AuthenticationInfoManagementAclPlugEngine(ControllerParameters controllerParameters) { + this.controllerParameters = controllerParameters; + accessContralAnalysis.analysisClass(controllerParameters.getAccessContralAnalysisClass()); } public void setAccessControl(AccessControl accessControl) throws AclPlugRuntimeException { diff --git a/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/engine/LoginInfoAclPlugEngine.java b/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/engine/LoginInfoAclPlugEngine.java index 4ce9f6a4..e8dc59c4 100644 --- a/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/engine/LoginInfoAclPlugEngine.java +++ b/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/engine/LoginInfoAclPlugEngine.java @@ -21,15 +21,15 @@ import java.util.concurrent.ConcurrentHashMap; import org.apache.rocketmq.acl.plug.entity.AccessControl; import org.apache.rocketmq.acl.plug.entity.AuthenticationInfo; import org.apache.rocketmq.acl.plug.entity.AuthenticationResult; -import org.apache.rocketmq.acl.plug.entity.ControllerParametersEntity; +import org.apache.rocketmq.acl.plug.entity.ControllerParameters; import org.apache.rocketmq.acl.plug.entity.LoginInfo; public abstract class LoginInfoAclPlugEngine extends AuthenticationInfoManagementAclPlugEngine { private Map loginInfoMap = new ConcurrentHashMap<>(); - public LoginInfoAclPlugEngine(ControllerParametersEntity controllerParametersEntity) { - super(controllerParametersEntity); + public LoginInfoAclPlugEngine(ControllerParameters controllerParameters) { + super(controllerParameters); } public LoginInfo getLoginInfo(AccessControl accessControl) { diff --git a/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/engine/PlainAclPlugEngine.java b/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/engine/PlainAclPlugEngine.java index 2917e723..01fdba84 100644 --- a/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/engine/PlainAclPlugEngine.java +++ b/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/engine/PlainAclPlugEngine.java @@ -20,20 +20,20 @@ import java.io.File; import java.io.FileInputStream; import java.io.IOException; import org.apache.rocketmq.acl.plug.entity.BorkerAccessControlTransport; -import org.apache.rocketmq.acl.plug.entity.ControllerParametersEntity; +import org.apache.rocketmq.acl.plug.entity.ControllerParameters; import org.apache.rocketmq.acl.plug.exception.AclPlugRuntimeException; import org.yaml.snakeyaml.Yaml; public class PlainAclPlugEngine extends LoginInfoAclPlugEngine { public PlainAclPlugEngine( - ControllerParametersEntity controllerParametersEntity) throws AclPlugRuntimeException { - super(controllerParametersEntity); + ControllerParameters controllerParameters) throws AclPlugRuntimeException { + super(controllerParameters); init(); } void init() throws AclPlugRuntimeException { - String filePath = controllerParametersEntity.getFileHome() + "/conf/transport.yml"; + String filePath = controllerParameters.getFileHome() + "/conf/transport.yml"; Yaml ymal = new Yaml(); FileInputStream fis = null; BorkerAccessControlTransport transport; diff --git a/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/entity/ControllerParametersEntity.java b/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/entity/ControllerParameters.java similarity index 97% rename from acl-plug/src/main/java/org/apache/rocketmq/acl/plug/entity/ControllerParametersEntity.java rename to acl-plug/src/main/java/org/apache/rocketmq/acl/plug/entity/ControllerParameters.java index fe781e0e..708bcbeb 100644 --- a/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/entity/ControllerParametersEntity.java +++ b/acl-plug/src/main/java/org/apache/rocketmq/acl/plug/entity/ControllerParameters.java @@ -18,7 +18,7 @@ package org.apache.rocketmq.acl.plug.entity; import org.apache.rocketmq.common.protocol.RequestCode; -public class ControllerParametersEntity { +public class ControllerParameters { private String fileHome; diff --git a/acl-plug/src/test/java/org/apache/rocketmq/acl/plug/engine/PlainAclPlugEngineTest.java b/acl-plug/src/test/java/org/apache/rocketmq/acl/plug/engine/PlainAclPlugEngineTest.java index 45755a0e..618c87e4 100644 --- a/acl-plug/src/test/java/org/apache/rocketmq/acl/plug/engine/PlainAclPlugEngineTest.java +++ b/acl-plug/src/test/java/org/apache/rocketmq/acl/plug/engine/PlainAclPlugEngineTest.java @@ -28,7 +28,7 @@ import org.apache.rocketmq.acl.plug.entity.AuthenticationInfo; import org.apache.rocketmq.acl.plug.entity.AuthenticationResult; import org.apache.rocketmq.acl.plug.entity.BorkerAccessControl; import org.apache.rocketmq.acl.plug.entity.BorkerAccessControlTransport; -import org.apache.rocketmq.acl.plug.entity.ControllerParametersEntity; +import org.apache.rocketmq.acl.plug.entity.ControllerParameters; import org.apache.rocketmq.acl.plug.entity.LoginInfo; import org.apache.rocketmq.acl.plug.exception.AclPlugRuntimeException; import org.apache.rocketmq.common.MixAll; @@ -61,7 +61,7 @@ public class PlainAclPlugEngineTest { FileInputStream fis = new FileInputStream(new File(filePath)); transport = ymal.loadAs(fis, BorkerAccessControlTransport.class); - ControllerParametersEntity controllerParametersEntity = new ControllerParametersEntity(); + ControllerParameters controllerParametersEntity = new ControllerParameters(); controllerParametersEntity.setFileHome(home); plainAclPlugEngine = new PlainAclPlugEngine(controllerParametersEntity); @@ -108,7 +108,7 @@ public class PlainAclPlugEngineTest { @Test(expected = AclPlugRuntimeException.class) public void testPlainAclPlugEngineInit() { - ControllerParametersEntity controllerParametersEntity = new ControllerParametersEntity(); + ControllerParameters controllerParametersEntity = new ControllerParameters(); new PlainAclPlugEngine(controllerParametersEntity); } diff --git a/broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java b/broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java index e7e8097f..c30d1f33 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java @@ -32,12 +32,11 @@ import java.util.concurrent.LinkedBlockingQueue; import java.util.concurrent.ScheduledExecutorService; import java.util.concurrent.ThreadPoolExecutor; import java.util.concurrent.TimeUnit; - import org.apache.commons.lang3.StringUtils; import org.apache.rocketmq.acl.plug.AclPlugController; -import org.apache.rocketmq.acl.plug.AclRemotingServer; +import org.apache.rocketmq.acl.plug.AclRemotingService; import org.apache.rocketmq.acl.plug.entity.AccessControl; -import org.apache.rocketmq.acl.plug.entity.ControllerParametersEntity; +import org.apache.rocketmq.acl.plug.entity.ControllerParameters; import org.apache.rocketmq.broker.client.ClientHousekeepingService; import org.apache.rocketmq.broker.client.ConsumerIdsChangeListener; import org.apache.rocketmq.broker.client.ConsumerManager; @@ -503,14 +502,14 @@ public class BrokerController { log.info("Default does not start acl plug"); return; } - ControllerParametersEntity controllerParametersEntity = new ControllerParametersEntity(); - controllerParametersEntity.setFileHome(brokerConfig.getRocketmqHome()); - aclPlugController = new AclPlugController(controllerParametersEntity); + ControllerParameters controllerParameters = new ControllerParameters(); + controllerParameters.setFileHome(brokerConfig.getRocketmqHome()); + aclPlugController = new AclPlugController(controllerParameters); if (!aclPlugController.isStartSucceed()) { log.error("start acl plug failure"); return; } - final AclRemotingServer aclRemotingServe = aclPlugController.getAclRemotingServer(); + final AclRemotingService aclRemotingService = aclPlugController.getAclRemotingService(); this.registerServerRPCHook(new RPCHook() { @Override @@ -525,7 +524,7 @@ public class BrokerController { accessControl.setNetaddress(StringUtils.split(remoteAddr, ":")[0]); accessControl.setTopic(extFields.get("topic")); } - aclRemotingServe.check(accessControl); + aclRemotingService.check(accessControl); } @Override diff --git a/common/src/test/java/org/apache/rocketmq/common/MixAllTest.java b/common/src/test/java/org/apache/rocketmq/common/MixAllTest.java index 3f048720..9110517f 100644 --- a/common/src/test/java/org/apache/rocketmq/common/MixAllTest.java +++ b/common/src/test/java/org/apache/rocketmq/common/MixAllTest.java @@ -17,14 +17,13 @@ package org.apache.rocketmq.common; -import org.junit.Test; - import java.io.File; import java.io.IOException; import java.io.PrintWriter; import java.net.InetAddress; import java.util.List; import java.util.concurrent.atomic.AtomicLong; +import org.junit.Test; import static org.assertj.core.api.Assertions.assertThat; @@ -34,7 +33,7 @@ public class MixAllTest { List localInetAddress = MixAll.getLocalInetAddress(); String local = InetAddress.getLocalHost().getHostAddress(); assertThat(localInetAddress).contains("127.0.0.1"); - assertThat(localInetAddress).contains(local); + } @Test -- GitLab