From 78b6d7b5bb128b0d4ad80f2814e228485d3b8c15 Mon Sep 17 00:00:00 2001 From: James Yin Date: Wed, 15 Apr 2020 11:42:51 +0800 Subject: [PATCH] fixed typo in RequestResponseFuture. rename RequestResponseFuture.setSendReqeustOk to RequestResponseFuture.setSendRequestOk. --- .../impl/producer/DefaultMQProducerImpl.java | 20 +++++++++---------- .../producer/RequestResponseFuture.java | 4 ++-- .../producer/DefaultMQProducerTest.java | 2 +- .../producer/RequestResponseFutureTest.java | 2 +- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java b/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java index fca50cc5..2f171ae1 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java @@ -1356,12 +1356,12 @@ public class DefaultMQProducerImpl implements MQProducerInner { this.sendDefaultImpl(msg, CommunicationMode.ASYNC, new SendCallback() { @Override public void onSuccess(SendResult sendResult) { - requestResponseFuture.setSendReqeustOk(true); + requestResponseFuture.setSendRequestOk(true); } @Override public void onException(Throwable e) { - requestResponseFuture.setSendReqeustOk(false); + requestResponseFuture.setSendRequestOk(false); requestResponseFuture.putResponseMessage(null); requestResponseFuture.setCause(e); } @@ -1395,7 +1395,7 @@ public class DefaultMQProducerImpl implements MQProducerInner { this.sendDefaultImpl(msg, CommunicationMode.ASYNC, new SendCallback() { @Override public void onSuccess(SendResult sendResult) { - requestResponseFuture.setSendReqeustOk(true); + requestResponseFuture.setSendRequestOk(true); } @Override @@ -1421,12 +1421,12 @@ public class DefaultMQProducerImpl implements MQProducerInner { this.sendSelectImpl(msg, selector, arg, CommunicationMode.ASYNC, new SendCallback() { @Override public void onSuccess(SendResult sendResult) { - requestResponseFuture.setSendReqeustOk(true); + requestResponseFuture.setSendRequestOk(true); } @Override public void onException(Throwable e) { - requestResponseFuture.setSendReqeustOk(false); + requestResponseFuture.setSendRequestOk(false); requestResponseFuture.putResponseMessage(null); requestResponseFuture.setCause(e); } @@ -1461,7 +1461,7 @@ public class DefaultMQProducerImpl implements MQProducerInner { this.sendSelectImpl(msg, selector, arg, CommunicationMode.ASYNC, new SendCallback() { @Override public void onSuccess(SendResult sendResult) { - requestResponseFuture.setSendReqeustOk(true); + requestResponseFuture.setSendRequestOk(true); } @Override @@ -1487,12 +1487,12 @@ public class DefaultMQProducerImpl implements MQProducerInner { this.sendKernelImpl(msg, mq, CommunicationMode.ASYNC, new SendCallback() { @Override public void onSuccess(SendResult sendResult) { - requestResponseFuture.setSendReqeustOk(true); + requestResponseFuture.setSendRequestOk(true); } @Override public void onException(Throwable e) { - requestResponseFuture.setSendReqeustOk(false); + requestResponseFuture.setSendRequestOk(false); requestResponseFuture.putResponseMessage(null); requestResponseFuture.setCause(e); } @@ -1526,7 +1526,7 @@ public class DefaultMQProducerImpl implements MQProducerInner { this.sendKernelImpl(msg, mq, CommunicationMode.ASYNC, new SendCallback() { @Override public void onSuccess(SendResult sendResult) { - requestResponseFuture.setSendReqeustOk(true); + requestResponseFuture.setSendRequestOk(true); } @Override @@ -1540,7 +1540,7 @@ public class DefaultMQProducerImpl implements MQProducerInner { private void requestFail(final String correlationId) { RequestResponseFuture responseFuture = RequestFutureTable.getRequestFutureTable().remove(correlationId); if (responseFuture != null) { - responseFuture.setSendReqeustOk(false); + responseFuture.setSendRequestOk(false); responseFuture.putResponseMessage(null); try { responseFuture.executeRequestCallback(); diff --git a/client/src/main/java/org/apache/rocketmq/client/producer/RequestResponseFuture.java b/client/src/main/java/org/apache/rocketmq/client/producer/RequestResponseFuture.java index c54b236b..e66c08fd 100644 --- a/client/src/main/java/org/apache/rocketmq/client/producer/RequestResponseFuture.java +++ b/client/src/main/java/org/apache/rocketmq/client/producer/RequestResponseFuture.java @@ -103,8 +103,8 @@ public class RequestResponseFuture { return sendRequestOk; } - public void setSendReqeustOk(boolean sendReqeustOk) { - this.sendRequestOk = sendReqeustOk; + public void setSendRequestOk(boolean sendRequestOk) { + this.sendRequestOk = sendRequestOk; } public Message getRequestMsg() { diff --git a/client/src/test/java/org/apache/rocketmq/client/producer/DefaultMQProducerTest.java b/client/src/test/java/org/apache/rocketmq/client/producer/DefaultMQProducerTest.java index d572a232..41046fcd 100644 --- a/client/src/test/java/org/apache/rocketmq/client/producer/DefaultMQProducerTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/producer/DefaultMQProducerTest.java @@ -373,7 +373,7 @@ public class DefaultMQProducerTest { assertThat(responseMap).isNotNull(); for (Map.Entry entry : responseMap.entrySet()) { RequestResponseFuture future = entry.getValue(); - future.setSendReqeustOk(true); + future.setSendRequestOk(true); message.setFlag(1); future.getRequestCallback().onSuccess(message); } diff --git a/client/src/test/java/org/apache/rocketmq/client/producer/RequestResponseFutureTest.java b/client/src/test/java/org/apache/rocketmq/client/producer/RequestResponseFutureTest.java index 90e4623e..bc20873c 100644 --- a/client/src/test/java/org/apache/rocketmq/client/producer/RequestResponseFutureTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/producer/RequestResponseFutureTest.java @@ -37,7 +37,7 @@ public class RequestResponseFutureTest { @Override public void onException(Throwable e) { } }); - future.setSendReqeustOk(true); + future.setSendRequestOk(true); future.executeRequestCallback(); assertThat(cc.get()).isEqualTo(1); } -- GitLab