From ad8465b5ceb49fbc98f8411a36fe258fd61df12c Mon Sep 17 00:00:00 2001 From: xc Date: Wed, 16 Jun 2021 14:26:40 +0800 Subject: [PATCH] fix pointer print issue when response_result fail, it will try to print row value. When the failure is caused by ctrl+c, neteasy memory is released in response_result function and row memory is invalid. --- src/observer/mysql/ob_sync_cmd_driver.cpp | 2 +- src/observer/mysql/ob_sync_plan_driver.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/observer/mysql/ob_sync_cmd_driver.cpp b/src/observer/mysql/ob_sync_cmd_driver.cpp index 9cebc6b858..edbcf4d25c 100644 --- a/src/observer/mysql/ob_sync_cmd_driver.cpp +++ b/src/observer/mysql/ob_sync_cmd_driver.cpp @@ -256,7 +256,7 @@ int ObSyncCmdDriver::response_query_result(ObMySQLResultSet& result) ctx_.schema_guard_, tmp_session->get_effective_tenant_id())); if (OB_FAIL(sender_.response_packet(rp))) { - LOG_WARN("response packet fail", K(ret), K(*row)); + LOG_WARN("response packet fail", K(ret), KP(row)); } } } diff --git a/src/observer/mysql/ob_sync_plan_driver.cpp b/src/observer/mysql/ob_sync_plan_driver.cpp index aaf36a3817..ab4c0b9114 100644 --- a/src/observer/mysql/ob_sync_plan_driver.cpp +++ b/src/observer/mysql/ob_sync_plan_driver.cpp @@ -264,7 +264,7 @@ int ObSyncPlanDriver::response_query_result( ctx_.schema_guard_, session_.get_effective_tenant_id())); if (OB_FAIL(sender_.response_packet(rp))) { - LOG_WARN("response packet fail", K(ret), K(*row), K(row_num), K(can_retry)); + LOG_WARN("response packet fail", K(ret), KP(row), K(row_num), K(can_retry)); // break; } else { // LOG_DEBUG("response row succ", K(*row)); -- GitLab