diff --git a/libavformat/oggdec.c b/libavformat/oggdec.c index 1a3acbb55e4621eecf62da7a141118ec94a5e03f..b4ba00df61bf17d93e4e51041285151fee9ff193 100644 --- a/libavformat/oggdec.c +++ b/libavformat/oggdec.c @@ -877,14 +877,12 @@ retry: } if (os->new_metadata) { - uint8_t *side_data = av_packet_new_side_data(pkt, - AV_PKT_DATA_METADATA_UPDATE, - os->new_metadata_size); - if(!side_data) - return AVERROR(ENOMEM); + ret = av_packet_add_side_data(pkt, AV_PKT_DATA_METADATA_UPDATE, + os->new_metadata, os->new_metadata_size); + if (ret < 0) + return ret; - memcpy(side_data, os->new_metadata, os->new_metadata_size); - av_freep(&os->new_metadata); + os->new_metadata = NULL; os->new_metadata_size = 0; } diff --git a/libavformat/oggparsevorbis.c b/libavformat/oggparsevorbis.c index 246ba8fe75352e4c66836de23857073d62b79116..0e8c25c030b908653c87775db3e4d3637a6b8b9d 100644 --- a/libavformat/oggparsevorbis.c +++ b/libavformat/oggparsevorbis.c @@ -287,7 +287,7 @@ static int vorbis_update_metadata(AVFormatContext *s, int idx) os->new_metadata = av_packet_pack_dictionary(st->metadata, &os->new_metadata_size); /* Send an empty dictionary to indicate that metadata has been cleared. */ } else { - os->new_metadata = av_malloc(1); + os->new_metadata = av_mallocz(1); os->new_metadata_size = 0; }