From 9d5e81d3b160cd6688a6c382e816d4b7db071f66 Mon Sep 17 00:00:00 2001 From: James Almer Date: Wed, 5 Jul 2017 10:28:03 -0300 Subject: [PATCH] Revert "x86/sbrdsp: remove unnecessary sign extend instruction in apply_noise_main" This reverts commit 24bb7db4037876c5722b0eecf7412502e7225634. noise has to after all be sign extended, not zero extended, on tests other than checkasm. Fixes most aac tests broken by the now reverted commit. --- libavcodec/x86/sbrdsp.asm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/x86/sbrdsp.asm b/libavcodec/x86/sbrdsp.asm index 51680f048b..62bbe512ec 100644 --- a/libavcodec/x86/sbrdsp.asm +++ b/libavcodec/x86/sbrdsp.asm @@ -382,7 +382,8 @@ apply_noise_main: %else DEFINE_ARGS Y, s_m, q_filt, noise, kx, count %endif - dec noised + movsxdifnidn noiseq, noised + dec noiseq shl countd, 2 %ifdef PIC lea NOISE_TABLE, [sbr_noise_table] -- GitLab