From 46f3b40eb3bcb377054804631844923de9a9b45f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Reimar=20D=C3=B6ffinger?= Date: Wed, 9 Sep 2009 21:00:51 +0000 Subject: [PATCH] Add warnings to av_strlcat and av_strlcpy doxygen that the input strings already must be properly 0-terminated strings. Unlike strncpy it cannot be used on raw data read from a file. Originally committed as revision 19800 to svn://svn.ffmpeg.org/ffmpeg/trunk --- libavutil/avstring.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/libavutil/avstring.h b/libavutil/avstring.h index 97c2f38715..d716c3a282 100644 --- a/libavutil/avstring.h +++ b/libavutil/avstring.h @@ -56,6 +56,10 @@ int av_stristart(const char *str, const char *pfx, const char **ptr); * @param src source string * @param size size of destination buffer * @return the length of src + * + * WARNING: since the return value is the length of src, src absolutely + * _must_ be a properly 0-terminated string, otherwise this will read beyond + * the end of the buffer and possibly crash. */ size_t av_strlcpy(char *dst, const char *src, size_t size); @@ -70,6 +74,10 @@ size_t av_strlcpy(char *dst, const char *src, size_t size); * @param src source string * @param size size of destination buffer * @return the total length of src and dst + * + * WARNING: since the return value use the length of src and dst, these absolutely + * _must_ be a properly 0-terminated strings, otherwise this will read beyond + * the end of the buffer and possibly crash. */ size_t av_strlcat(char *dst, const char *src, size_t size); -- GitLab