From 2d96c945312d3f62e3f872bfb51a593afb40e09a Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Tue, 30 Jun 2020 21:32:53 +0200 Subject: [PATCH] avcodec/hcadec: Check total_band_count against imdct_in size Fixes: index 128 out of bounds for type 'float [128]' Fixes: 23465/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HCA_fuzzer-5089866596745216 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/hcadec.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libavcodec/hcadec.c b/libavcodec/hcadec.c index 28e7d07cec..11cb157277 100644 --- a/libavcodec/hcadec.c +++ b/libavcodec/hcadec.c @@ -157,6 +157,10 @@ static av_cold int decode_init(AVCodecContext *avctx) } else return AVERROR_INVALIDDATA; + if (c->total_band_count > FF_ARRAY_ELEMS(c->ch->imdct_in)) + return AVERROR_INVALIDDATA; + + while (get_bits_left(gb) >= 32) { chunk = get_bits_long(gb, 32); if (chunk == MKBETAG('v', 'b', 'r', 0)) { -- GitLab