• D
    sparc: fix build · eaeb1688
    David Rientjes 提交于
    Fix build failure on sparc:
    
    	In file included from include/linux/mm.h:39,
    	                from include/linux/memcontrol.h:24,
    	                from include/linux/swap.h:8,
    	                from include/linux/suspend.h:7,
    	                from init/do_mounts.c:6:
    	include/asm/pgtable.h:344: warning: parameter names (without
    		types) in function declaration
    	include/asm/pgtable.h:345: warning: parameter names (without
    		types) in function declaration
    	include/asm/pgtable.h:346: error: expected '=', ',', ';', 'asm' or
    		'__attribute__' before '___f___swp_entry'
    
    viro sayeth:
    
      I've run allmodconfig builds on a bunch of target, FWIW (essentially the
      same patch).  Note that these includes are recent addition caused by added
      inline function that had since then become a define.  So while I agree with
      your comments in general, in _this_ case it's pretty safe.
    
      The commit that had done it is 3062fc67
      ("memcontrol: move mm_cgroup to header file") and the switch to #define
      is in commit 60c12b12 ("memcontrol: add
      vm_match_cgroup()") (BTW, that probably warranted mentioning in the
      changelog of the latter).
    
    Cc: Adrian Bunk <bunk@kernel.org>
    Cc: Robert Reif <reif@earthlink.net>
    Signed-off-by: NDavid Rientjes <rientjes@google.com>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
    eaeb1688
memcontrol.h 4.8 KB