diff --git a/crypto/ec/ec_25519.c b/crypto/ec/ec_25519.c index 539a8e1af77c7588ee6afa5fca0deed46f833eee..3e6609ad9c16aa72f42b5e3992cb6e553f0f5e12 100644 --- a/crypto/ec/ec_25519.c +++ b/crypto/ec/ec_25519.c @@ -326,7 +326,7 @@ static int x25519_compute_key(void *out, size_t outlen, const EC_METHOD *ec_x25519_meth(void) { static const EC_METHOD ret = { - EC_FLAGS_CUSTOM_CURVE, + EC_FLAGS_CUSTOM_CURVE | EC_FLAGS_NO_SIGN, NID_undef, x25519_group_init, /* group_init */ 0, /* group_finish */ diff --git a/crypto/ec/ec_key.c b/crypto/ec/ec_key.c index f09edbbc05df79b143b693b02d047e9995cafdbc..e59d2c6d6a665dd7d53a8b0096f99d9cc3b17519 100644 --- a/crypto/ec/ec_key.c +++ b/crypto/ec/ec_key.c @@ -631,3 +631,11 @@ size_t EC_KEY_priv2buf(const EC_KEY *eckey, unsigned char **pbuf) *pbuf = buf; return len; } + +int EC_KEY_can_sign(const EC_KEY *eckey) +{ + if (eckey->group == NULL || eckey->group->meth == NULL + || (eckey->group->meth->flags & EC_FLAGS_NO_SIGN)) + return 0; + return 1; +} diff --git a/crypto/ec/ec_lcl.h b/crypto/ec/ec_lcl.h index efdfabe1e1d4cbee43aaaec222d79dfaad066b41..42cf07961ea87c774cfd6e9a8d05930df786e7ac 100644 --- a/crypto/ec/ec_lcl.h +++ b/crypto/ec/ec_lcl.h @@ -86,6 +86,9 @@ /* Use custom formats for EC_GROUP, EC_POINT and EC_KEY */ #define EC_FLAGS_CUSTOM_CURVE 0x2 +/* Curve does not support signing operations */ +#define EC_FLAGS_NO_SIGN 0x4 + /* * Structure details are not part of the exported interface, so all this may * change in future versions. diff --git a/crypto/ec/ecdsa_ossl.c b/crypto/ec/ecdsa_ossl.c index 3e755fbafac0506dbd098910eab6d4d7bc7e9ade..113bcdfa20f9149e50c242546540a85d0eb63d90 100644 --- a/crypto/ec/ecdsa_ossl.c +++ b/crypto/ec/ecdsa_ossl.c @@ -95,6 +95,11 @@ static int ecdsa_sign_setup(EC_KEY *eckey, BN_CTX *ctx_in, return 0; } + if (!EC_KEY_can_sign(eckey)) { + ECerr(EC_F_ECDSA_SIGN_SETUP, EC_R_CURVE_DOES_NOT_SUPPORT_SIGNING); + return 0; + } + if (ctx_in == NULL) { if ((ctx = BN_CTX_new()) == NULL) { ECerr(EC_F_ECDSA_SIGN_SETUP, ERR_R_MALLOC_FAILURE); @@ -254,6 +259,11 @@ ECDSA_SIG *ossl_ecdsa_sign_sig(const unsigned char *dgst, int dgst_len, return NULL; } + if (!EC_KEY_can_sign(eckey)) { + ECerr(EC_F_OSSL_ECDSA_SIGN_SIG, EC_R_CURVE_DOES_NOT_SUPPORT_SIGNING); + return NULL; + } + ret = ECDSA_SIG_new(); if (ret == NULL) { ECerr(EC_F_OSSL_ECDSA_SIGN_SIG, ERR_R_MALLOC_FAILURE); @@ -391,6 +401,11 @@ int ossl_ecdsa_verify_sig(const unsigned char *dgst, int dgst_len, return -1; } + if (!EC_KEY_can_sign(eckey)) { + ECerr(EC_F_OSSL_ECDSA_VERIFY_SIG, EC_R_CURVE_DOES_NOT_SUPPORT_SIGNING); + return -1; + } + ctx = BN_CTX_new(); if (ctx == NULL) { ECerr(EC_F_OSSL_ECDSA_VERIFY_SIG, ERR_R_MALLOC_FAILURE); diff --git a/include/openssl/ec.h b/include/openssl/ec.h index 8530c569a49994f17a4ef430fd08946beb34c46b..ccd410f772ba1885c485da0d9b8d5886106ec2a0 100644 --- a/include/openssl/ec.h +++ b/include/openssl/ec.h @@ -901,6 +901,12 @@ int EC_KEY_generate_key(EC_KEY *key); */ int EC_KEY_check_key(const EC_KEY *key); +/** Indicates if an EC_KEY can be used for signing. + * \param key the EC_KEY object + * \return 1 if can can sign and 0 otherwise. + */ +int EC_KEY_can_sign(const EC_KEY *eckey); + /** Sets a public key from affine coordindates performing * necessary NIST PKV tests. * \param key the EC_KEY object