From 339638b586e77c189e8294f931b99b03d1f08dbd Mon Sep 17 00:00:00 2001 From: Rich Salz Date: Tue, 7 Jan 2020 15:50:20 -0500 Subject: [PATCH] Make generated copyright year be "now" Always use the current year in generating output files, rather than trying to base is on the modtime of the script or input, as that can vary depending on the ability of the local OS to keep those accurate. Fixes #10744 Reviewed-by: Shane Lontis Reviewed-by: Richard Levitte (Merged from https://github.com/openssl/openssl/pull/10776) --- crypto/asn1/charmap.pl | 4 ++-- crypto/bn/bn_prime.pl | 4 ++-- crypto/conf/keysets.pl | 5 ++--- crypto/objects/obj_dat.pl | 6 ++---- crypto/objects/objects.pl | 8 ++------ crypto/objects/objxref.pl | 8 ++------ fuzz/mkfuzzoids.pl | 6 ++---- 7 files changed, 14 insertions(+), 27 deletions(-) diff --git a/crypto/asn1/charmap.pl b/crypto/asn1/charmap.pl index d29a21b3a7..8130c826ad 100644 --- a/crypto/asn1/charmap.pl +++ b/crypto/asn1/charmap.pl @@ -82,8 +82,8 @@ $arr[ord("?")] |= $PSTRING_CHAR; # Now generate the C code -# Output year depends on the year of the script. -my $YEAR = [localtime([stat($0)]->[9])]->[5] + 1900; +# Year the file was generated. +my $YEAR = [localtime()]->[5] + 1900; print <[9])]->[5] + 1900; +# The year the output file is generated. +my $YEAR = [localtime()]->[5] + 1900; print <<"EOF"; /* * WARNING: do not edit! diff --git a/crypto/conf/keysets.pl b/crypto/conf/keysets.pl index b0e2249364..42c1988345 100644 --- a/crypto/conf/keysets.pl +++ b/crypto/conf/keysets.pl @@ -57,9 +57,8 @@ foreach (0 .. 127) { push(@V_w32, $v); } -# Output year depends on the year of the script. -my $YEAR = [localtime([stat($0)]->[9])]->[5] + 1900; - +# The year the output file is generated. +my $YEAR = [localtime()]->[5] + 1900; print <<"EOF"; /* * WARNING: do not edit! diff --git a/crypto/objects/obj_dat.pl b/crypto/objects/obj_dat.pl index 24f09b49e5..2cee3e19ea 100644 --- a/crypto/objects/obj_dat.pl +++ b/crypto/objects/obj_dat.pl @@ -36,10 +36,8 @@ sub der_it return $ret; } -# Output year depends on the year of the script and the input file. -my $YEAR = [localtime([stat($0)]->[9])]->[5] + 1900; -my $iYEAR = [localtime([stat($ARGV[0])]->[9])]->[5] + 1900; -$YEAR = $iYEAR if $iYEAR > $YEAR; +# The year the output file is generated. +my $YEAR = [localtime()]->[5] + 1900; # Read input, parse all #define's into OID name and value. # Populate %ln and %sn with long and short names (%dupln and %dupsn) diff --git a/crypto/objects/objects.pl b/crypto/objects/objects.pl index 62d6b44bab..f4f11fa452 100644 --- a/crypto/objects/objects.pl +++ b/crypto/objects/objects.pl @@ -11,12 +11,8 @@ use Getopt::Std; our($opt_n); getopts('n'); -# Output year depends on the year of the script and the input file. -my $YEAR = [localtime([stat($0)]->[9])]->[5] + 1900; -my $iYEAR = [localtime([stat($ARGV[0])]->[9])]->[5] + 1900; -$YEAR = $iYEAR if $iYEAR > $YEAR; -$iYEAR = [localtime([stat($ARGV[1])]->[9])]->[5] + 1900; -$YEAR = $iYEAR if $iYEAR > $YEAR; +# The year the output file is generated. +my $YEAR = [localtime()]->[5] + 1900; open (NUMIN,"$ARGV[1]") || die "Can't open number file $ARGV[1]"; $max_nid=0; diff --git a/crypto/objects/objxref.pl b/crypto/objects/objxref.pl index e6b69a8309..01ecf438f0 100644 --- a/crypto/objects/objxref.pl +++ b/crypto/objects/objxref.pl @@ -14,12 +14,8 @@ my %oid_tbl; my ($mac_file, $xref_file) = @ARGV; -# Output year depends on the year of the script and the input file. -my $YEAR = [localtime([stat($0)]->[9])]->[5] + 1900; -my $iYEAR = [localtime([stat($mac_file)]->[9])]->[5] + 1900; -$YEAR = $iYEAR if $iYEAR > $YEAR; -$iYEAR = [localtime([stat($xref_file)]->[9])]->[5] + 1900; -$YEAR = $iYEAR if $iYEAR > $YEAR; +# The year the output file is generated. +my $YEAR = [localtime()]->[5] + 1900; open(IN, $mac_file) || die "Can't open $mac_file, $!\n"; diff --git a/fuzz/mkfuzzoids.pl b/fuzz/mkfuzzoids.pl index 89cf7bb583..050b5b7047 100755 --- a/fuzz/mkfuzzoids.pl +++ b/fuzz/mkfuzzoids.pl @@ -8,10 +8,8 @@ my $obj_dat_h = $ARGV[0]; -# Output year depends on the date on the input file and the script. -my $YEAR = [localtime([stat($0)]->[9])]->[5] + 1900; -my $iYEAR = [localtime([stat($obj_dat_h)]->[9])]->[5] + 1900; -$YEAR = $iYEAR if $iYEAR > $YEAR; +# The year the output file is generated. +my $YEAR = [localtime()]->[5] + 1900; open IN, '<', $obj_dat_h || die "Couldn't open $obj_dat_h : $!\n"; -- GitLab