From baaebb402e7c242bfc937b6b522d0408fe4da233 Mon Sep 17 00:00:00 2001 From: Eugene Pankov Date: Mon, 16 Mar 2020 22:30:11 +0100 Subject: [PATCH] private service constructors --- terminus-core/src/components/baseTab.component.ts | 2 +- terminus-core/src/components/startPage.component.ts | 2 +- terminus-core/src/components/windowControls.component.ts | 2 +- terminus-core/src/services/app.service.ts | 2 +- terminus-core/src/services/config.service.ts | 2 +- terminus-core/src/services/docking.service.ts | 2 +- terminus-core/src/services/electron.service.ts | 2 +- terminus-core/src/services/homeBase.service.ts | 2 +- terminus-core/src/services/log.service.ts | 2 +- terminus-core/src/services/shellIntegration.service.ts | 2 +- terminus-core/src/services/tabRecovery.service.ts | 2 +- terminus-core/src/services/tabs.service.ts | 2 +- terminus-core/src/services/themes.service.ts | 2 +- terminus-core/src/services/touchbar.service.ts | 2 +- terminus-core/src/services/updater.service.ts | 2 +- terminus-plugin-manager/src/services/pluginManager.service.ts | 2 +- terminus-terminal/src/index.ts | 2 +- terminus-terminal/src/services/sessions.service.ts | 2 +- terminus-terminal/src/services/terminal.service.ts | 2 +- terminus-terminal/src/services/terminalFrontend.service.ts | 2 +- terminus-terminal/src/services/uac.service.ts | 2 +- 21 files changed, 21 insertions(+), 21 deletions(-) diff --git a/terminus-core/src/components/baseTab.component.ts b/terminus-core/src/components/baseTab.component.ts index 436f5e67..b67ddadc 100644 --- a/terminus-core/src/components/baseTab.component.ts +++ b/terminus-core/src/components/baseTab.component.ts @@ -63,7 +63,7 @@ export abstract class BaseTabComponent { get destroyed$ (): Observable { return this.destroyed } get recoveryStateChangedHint$ (): Observable { return this.recoveryStateChangedHint } - constructor () { + protected constructor () { this.focused$.subscribe(() => { this.hasFocus = true }) diff --git a/terminus-core/src/components/startPage.component.ts b/terminus-core/src/components/startPage.component.ts index 4a437433..32a577e3 100644 --- a/terminus-core/src/components/startPage.component.ts +++ b/terminus-core/src/components/startPage.component.ts @@ -13,7 +13,7 @@ import { ToolbarButton, ToolbarButtonProvider } from '../api' export class StartPageComponent { version: string - constructor ( + private constructor ( private config: ConfigService, private domSanitizer: DomSanitizer, public homeBase: HomeBaseService, diff --git a/terminus-core/src/components/windowControls.component.ts b/terminus-core/src/components/windowControls.component.ts index 22994bcb..bd215b6e 100644 --- a/terminus-core/src/components/windowControls.component.ts +++ b/terminus-core/src/components/windowControls.component.ts @@ -10,7 +10,7 @@ import { AppService } from '../services/app.service' styles: [require('./windowControls.component.scss')], }) export class WindowControlsComponent { - constructor (public hostApp: HostAppService, public app: AppService) { } + private constructor (public hostApp: HostAppService, public app: AppService) { } async closeWindow () { this.app.closeWindow() diff --git a/terminus-core/src/services/app.service.ts b/terminus-core/src/services/app.service.ts index 550ecff7..52c0848e 100644 --- a/terminus-core/src/services/app.service.ts +++ b/terminus-core/src/services/app.service.ts @@ -67,7 +67,7 @@ export class AppService { get ready$ (): Observable { return this.ready } /** @hidden */ - constructor ( + private constructor ( private config: ConfigService, private hostApp: HostAppService, private tabRecovery: TabRecoveryService, diff --git a/terminus-core/src/services/config.service.ts b/terminus-core/src/services/config.service.ts index f1f66cc7..17725f6e 100644 --- a/terminus-core/src/services/config.service.ts +++ b/terminus-core/src/services/config.service.ts @@ -102,7 +102,7 @@ export class ConfigService { get changed$ (): Observable { return this.changed } /** @hidden */ - constructor ( + private constructor ( electron: ElectronService, private hostApp: HostAppService, @Inject(ConfigProvider) configProviders: ConfigProvider[], diff --git a/terminus-core/src/services/docking.service.ts b/terminus-core/src/services/docking.service.ts index d52593a1..a015ebfc 100644 --- a/terminus-core/src/services/docking.service.ts +++ b/terminus-core/src/services/docking.service.ts @@ -6,7 +6,7 @@ import { HostAppService, Bounds } from '../services/hostApp.service' @Injectable({ providedIn: 'root' }) export class DockingService { /** @hidden */ - constructor ( + private constructor ( private electron: ElectronService, private config: ConfigService, private hostApp: HostAppService, diff --git a/terminus-core/src/services/electron.service.ts b/terminus-core/src/services/electron.service.ts index de46211f..32576e1d 100644 --- a/terminus-core/src/services/electron.service.ts +++ b/terminus-core/src/services/electron.service.ts @@ -25,7 +25,7 @@ export class ElectronService { private electron: any /** @hidden */ - constructor () { + private constructor () { this.electron = require('electron') this.remote = this.electron.remote this.app = this.remote.app diff --git a/terminus-core/src/services/homeBase.service.ts b/terminus-core/src/services/homeBase.service.ts index 6e6bd8b5..356322b3 100644 --- a/terminus-core/src/services/homeBase.service.ts +++ b/terminus-core/src/services/homeBase.service.ts @@ -11,7 +11,7 @@ export class HomeBaseService { mixpanel: any /** @hidden */ - constructor ( + private constructor ( private electron: ElectronService, private config: ConfigService, ) { diff --git a/terminus-core/src/services/log.service.ts b/terminus-core/src/services/log.service.ts index aacc10de..025e32ab 100644 --- a/terminus-core/src/services/log.service.ts +++ b/terminus-core/src/services/log.service.ts @@ -65,7 +65,7 @@ export class LogService { private log: any /** @hidden */ - constructor (electron: ElectronService) { + private constructor (electron: ElectronService) { this.log = initializeWinston(electron) } diff --git a/terminus-core/src/services/shellIntegration.service.ts b/terminus-core/src/services/shellIntegration.service.ts index a9b78da0..9e19f8d1 100644 --- a/terminus-core/src/services/shellIntegration.service.ts +++ b/terminus-core/src/services/shellIntegration.service.ts @@ -33,7 +33,7 @@ export class ShellIntegrationService { command: 'paste "%V"', }, ] - constructor ( + private constructor ( private electron: ElectronService, private hostApp: HostAppService, ) { diff --git a/terminus-core/src/services/tabRecovery.service.ts b/terminus-core/src/services/tabRecovery.service.ts index 34a97fdb..9d183300 100644 --- a/terminus-core/src/services/tabRecovery.service.ts +++ b/terminus-core/src/services/tabRecovery.service.ts @@ -10,7 +10,7 @@ export class TabRecoveryService { logger: Logger enabled = false - constructor ( + private constructor ( @Inject(TabRecoveryProvider) private tabRecoveryProviders: TabRecoveryProvider[], private config: ConfigService, log: LogService diff --git a/terminus-core/src/services/tabs.service.ts b/terminus-core/src/services/tabs.service.ts index 28c8ff5f..17c2986f 100644 --- a/terminus-core/src/services/tabs.service.ts +++ b/terminus-core/src/services/tabs.service.ts @@ -8,7 +8,7 @@ export type TabComponentType = new (...args: any[]) => BaseTabComponent @Injectable({ providedIn: 'root' }) export class TabsService { /** @hidden */ - constructor ( + private constructor ( private componentFactoryResolver: ComponentFactoryResolver, private injector: Injector, private tabRecovery: TabRecoveryService, diff --git a/terminus-core/src/services/themes.service.ts b/terminus-core/src/services/themes.service.ts index 1a5ee765..93e95f12 100644 --- a/terminus-core/src/services/themes.service.ts +++ b/terminus-core/src/services/themes.service.ts @@ -7,7 +7,7 @@ export class ThemesService { private styleElement: HTMLElement|null = null /** @hidden */ - constructor ( + private constructor ( private config: ConfigService, @Inject(Theme) private themes: Theme[], ) { diff --git a/terminus-core/src/services/touchbar.service.ts b/terminus-core/src/services/touchbar.service.ts index c8431966..4ea8462b 100644 --- a/terminus-core/src/services/touchbar.service.ts +++ b/terminus-core/src/services/touchbar.service.ts @@ -14,7 +14,7 @@ export class TouchbarService { private tabSegments: SegmentedControlSegment[] = [] private nsImageCache: {[id: string]: Electron.NativeImage} = {} - constructor ( + private constructor ( private app: AppService, private hostApp: HostAppService, @Inject(ToolbarButtonProvider) private toolbarButtonProviders: ToolbarButtonProvider[], diff --git a/terminus-core/src/services/updater.service.ts b/terminus-core/src/services/updater.service.ts index 05febfc8..300bc9d2 100644 --- a/terminus-core/src/services/updater.service.ts +++ b/terminus-core/src/services/updater.service.ts @@ -21,7 +21,7 @@ export class UpdaterService { private updateURL: string private autoUpdater: AppUpdater - constructor ( + private constructor ( log: LogService, private electron: ElectronService, private config: ConfigService, diff --git a/terminus-plugin-manager/src/services/pluginManager.service.ts b/terminus-plugin-manager/src/services/pluginManager.service.ts index 18cb683d..ed21e8d8 100644 --- a/terminus-plugin-manager/src/services/pluginManager.service.ts +++ b/terminus-plugin-manager/src/services/pluginManager.service.ts @@ -34,7 +34,7 @@ export class PluginManagerService { private npmReady: Promise private npm: any - constructor ( + private constructor ( log: LogService, ) { this.logger = log.create('pluginManager') diff --git a/terminus-terminal/src/index.ts b/terminus-terminal/src/index.ts index fd924002..25134a22 100644 --- a/terminus-terminal/src/index.ts +++ b/terminus-terminal/src/index.ts @@ -127,7 +127,7 @@ import { XTermFrontend, XTermWebGLFrontend } from './frontends/xtermFrontend' ], }) export default class TerminalModule { // eslint-disable-line @typescript-eslint/no-extraneous-class - constructor ( + private constructor ( app: AppService, config: ConfigService, hotkeys: HotkeysService, diff --git a/terminus-terminal/src/services/sessions.service.ts b/terminus-terminal/src/services/sessions.service.ts index 844a9f71..383b3459 100644 --- a/terminus-terminal/src/services/sessions.service.ts +++ b/terminus-terminal/src/services/sessions.service.ts @@ -332,7 +332,7 @@ export class SessionsService { logger: Logger private lastID = 0 - constructor ( + private constructor ( log: LogService, ) { require('../bufferizedPTY')(nodePTY) // eslint-disable-line @typescript-eslint/no-var-requires diff --git a/terminus-terminal/src/services/terminal.service.ts b/terminus-terminal/src/services/terminal.service.ts index f1fea4ff..249eb965 100644 --- a/terminus-terminal/src/services/terminal.service.ts +++ b/terminus-terminal/src/services/terminal.service.ts @@ -19,7 +19,7 @@ export class TerminalService { get shells$ (): Observable { return this.shells } /** @hidden */ - constructor ( + private constructor ( private app: AppService, private config: ConfigService, private uac: UACService, diff --git a/terminus-terminal/src/services/terminalFrontend.service.ts b/terminus-terminal/src/services/terminalFrontend.service.ts index 748b1a6e..1ab46b1c 100644 --- a/terminus-terminal/src/services/terminalFrontend.service.ts +++ b/terminus-terminal/src/services/terminalFrontend.service.ts @@ -10,7 +10,7 @@ export class TerminalFrontendService { private containers = new WeakMap() /** @hidden */ - constructor ( + private constructor ( private config: ConfigService, private themes: ThemesService, private hotkeys: HotkeysService, diff --git a/terminus-terminal/src/services/uac.service.ts b/terminus-terminal/src/services/uac.service.ts index eabb3f27..79518dfe 100644 --- a/terminus-terminal/src/services/uac.service.ts +++ b/terminus-terminal/src/services/uac.service.ts @@ -8,7 +8,7 @@ import { SessionOptions } from '../api/interfaces' export class UACService { isAvailable = false - constructor ( + private constructor ( private electron: ElectronService, ) { this.isAvailable = isWindowsBuild(WIN_BUILD_CONPTY_SUPPORTED) -- GitLab