From d2f601a9748e1389ea6f3c16513869a90688e0e6 Mon Sep 17 00:00:00 2001 From: Calvin Date: Tue, 6 Mar 2012 11:10:10 +0800 Subject: [PATCH] =?UTF-8?q?Issue=20#16=20=E5=9C=A8Sonar=202.13=E9=BB=98?= =?UTF-8?q?=E8=AE=A4Profile=E7=9A=84=E5=9F=BA=E7=A1=80=E4=B8=8A=E6=8C=87?= =?UTF-8?q?=E5=AE=9ASpringSide=E7=9A=84=E4=BB=A3=E7=A0=81=E6=A3=80?= =?UTF-8?q?=E6=9F=A5=E8=A7=84=E5=88=99,=E5=90=8C=E6=97=B6=E9=A1=BA?= =?UTF-8?q?=E6=89=8B=E4=BF=AE=E6=94=B9=E4=BB=A3=E7=A0=81?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .gitignore | 1 + .../miniservice/dao/AccountDaoTest.java | 4 +- .../functional/BaseFunctionalTestCase.java | 4 +- .../examples/miniweb/dao/JpaMappingTest.java | 4 +- .../miniweb/dao/account/GroupDaoTest.java | 4 +- .../miniweb/dao/account/UserDaoTest.java | 4 +- .../functional/BaseFunctionalTestCase.java | 4 +- .../showcase/utilities/json/JsonDemo.java | 18 +- .../showcase/common/JpaMappingTest.java | 4 +- .../functional/BaseFunctionalTestCase.java | 4 +- .../showcase/schedule/JdkExecutorJobTest.java | 4 +- .../schedule/QuartzClusterableJobTest.java | 4 +- .../org/springside/modules/orm/jpa/Jpas.java | 3 + .../data/{Fixtures.java => H2Fixtures.java} | 6 +- .../springside/modules/utils/Exceptions.java | 3 + .../modules/test/data/FixturesTest.java | 14 +- modules/parent/pom.xml | 13 +- support/sonar/README.txt | 2 + .../{checkstyle.xml => sonar-checkstyle.xml} | 0 .../{findbugs.xml => sonar-findbugs.xml} | 0 support/sonar/{pmd.xml => sonar-pmd.xml} | 0 support/sonar/{sonarway.xml => sonar-way.xml} | 0 support/sonar/springside-checkstyle.xml | 1 + support/sonar/springside-findbugs.xml | 1120 +++++++++++++++++ support/sonar/springside-pmd.xml | 259 ++++ support/sonar/springside-way.xml | 1 + 26 files changed, 1439 insertions(+), 42 deletions(-) rename modules/core/src/main/java/org/springside/modules/test/data/{Fixtures.java => H2Fixtures.java} (98%) create mode 100644 support/sonar/README.txt rename support/sonar/{checkstyle.xml => sonar-checkstyle.xml} (100%) rename support/sonar/{findbugs.xml => sonar-findbugs.xml} (100%) rename support/sonar/{pmd.xml => sonar-pmd.xml} (100%) rename support/sonar/{sonarway.xml => sonar-way.xml} (100%) create mode 100644 support/sonar/springside-checkstyle.xml create mode 100644 support/sonar/springside-findbugs.xml create mode 100644 support/sonar/springside-pmd.xml create mode 100644 support/sonar/springside-way.xml diff --git a/.gitignore b/.gitignore index 39f27d76..a0b99f70 100644 --- a/.gitignore +++ b/.gitignore @@ -38,6 +38,7 @@ /support/maven-archetype/.settings/ /support/maven-archetype/.project /support/sonar/target/ +/support/script /logs /target /TODO.txt diff --git a/examples/mini-service/src/test/java/org/springside/examples/miniservice/dao/AccountDaoTest.java b/examples/mini-service/src/test/java/org/springside/examples/miniservice/dao/AccountDaoTest.java index e96825f8..4d939999 100644 --- a/examples/mini-service/src/test/java/org/springside/examples/miniservice/dao/AccountDaoTest.java +++ b/examples/mini-service/src/test/java/org/springside/examples/miniservice/dao/AccountDaoTest.java @@ -12,7 +12,7 @@ import org.springframework.test.context.ContextConfiguration; import org.springside.examples.miniservice.data.AccountData; import org.springside.examples.miniservice.entity.Department; import org.springside.examples.miniservice.entity.User; -import org.springside.modules.test.data.Fixtures; +import org.springside.modules.test.data.H2Fixtures; import org.springside.modules.test.spring.SpringTxTestCase; import com.google.common.collect.Maps; @@ -35,7 +35,7 @@ public class AccountDaoTest extends SpringTxTestCase { */ @Before public void reloadSampleData() throws Exception { - Fixtures.reloadAllTable(dataSource, "/data/sample-data.xml"); + H2Fixtures.reloadAllTable(dataSource, "/data/sample-data.xml"); } @Test diff --git a/examples/mini-service/src/test/java/org/springside/examples/miniservice/functional/BaseFunctionalTestCase.java b/examples/mini-service/src/test/java/org/springside/examples/miniservice/functional/BaseFunctionalTestCase.java index d709ffe0..e64caeef 100644 --- a/examples/mini-service/src/test/java/org/springside/examples/miniservice/functional/BaseFunctionalTestCase.java +++ b/examples/mini-service/src/test/java/org/springside/examples/miniservice/functional/BaseFunctionalTestCase.java @@ -6,7 +6,7 @@ import org.eclipse.jetty.server.Server; import org.junit.BeforeClass; import org.junit.Ignore; import org.springside.examples.miniservice.Start; -import org.springside.modules.test.data.Fixtures; +import org.springside.modules.test.data.H2Fixtures; import org.springside.modules.test.functional.JettyFactory; import org.springside.modules.test.spring.SpringContextHolder; @@ -49,6 +49,6 @@ public class BaseFunctionalTestCase { * 载入测试数据. */ protected static void reloadSampleData() throws Exception { - Fixtures.reloadAllTable(dataSource, "/data/sample-data.xml"); + H2Fixtures.reloadAllTable(dataSource, "/data/sample-data.xml"); } } diff --git a/examples/mini-web/src/test/java/org/springside/examples/miniweb/dao/JpaMappingTest.java b/examples/mini-web/src/test/java/org/springside/examples/miniweb/dao/JpaMappingTest.java index 14288054..6a8ffbe4 100644 --- a/examples/mini-web/src/test/java/org/springside/examples/miniweb/dao/JpaMappingTest.java +++ b/examples/mini-web/src/test/java/org/springside/examples/miniweb/dao/JpaMappingTest.java @@ -10,7 +10,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.test.context.ContextConfiguration; import org.springframework.test.context.transaction.TransactionConfiguration; -import org.springside.modules.test.data.Fixtures; +import org.springside.modules.test.data.H2Fixtures; import org.springside.modules.test.spring.SpringTxTestCase; @ContextConfiguration(locations = { "/applicationContext.xml" }) @@ -24,7 +24,7 @@ public class JpaMappingTest extends SpringTxTestCase { @Test public void allClassMapping() throws Exception { - Fixtures.reloadAllTable(dataSource, "/data/sample-data.xml"); + H2Fixtures.reloadAllTable(dataSource, "/data/sample-data.xml"); Metamodel model = em.getEntityManagerFactory().getMetamodel(); for (EntityType entityType : model.getEntities()) { String entityName = entityType.getName(); diff --git a/examples/mini-web/src/test/java/org/springside/examples/miniweb/dao/account/GroupDaoTest.java b/examples/mini-web/src/test/java/org/springside/examples/miniweb/dao/account/GroupDaoTest.java index 9b7a61fc..083083b3 100644 --- a/examples/mini-web/src/test/java/org/springside/examples/miniweb/dao/account/GroupDaoTest.java +++ b/examples/mini-web/src/test/java/org/springside/examples/miniweb/dao/account/GroupDaoTest.java @@ -13,7 +13,7 @@ import org.springframework.test.context.ContextConfiguration; import org.springside.examples.miniweb.data.AccountData; import org.springside.examples.miniweb.entity.account.Group; import org.springside.examples.miniweb.entity.account.User; -import org.springside.modules.test.data.Fixtures; +import org.springside.modules.test.data.H2Fixtures; import org.springside.modules.test.spring.SpringTxTestCase; /** @@ -39,7 +39,7 @@ public class GroupDaoTest extends SpringTxTestCase { */ @Before public void reloadSampleData() throws Exception { - Fixtures.reloadAllTable(dataSource, "/data/sample-data.xml"); + H2Fixtures.reloadAllTable(dataSource, "/data/sample-data.xml"); } /** diff --git a/examples/mini-web/src/test/java/org/springside/examples/miniweb/dao/account/UserDaoTest.java b/examples/mini-web/src/test/java/org/springside/examples/miniweb/dao/account/UserDaoTest.java index f8ad76dc..636561a9 100644 --- a/examples/mini-web/src/test/java/org/springside/examples/miniweb/dao/account/UserDaoTest.java +++ b/examples/mini-web/src/test/java/org/springside/examples/miniweb/dao/account/UserDaoTest.java @@ -8,7 +8,7 @@ import org.springframework.beans.factory.annotation.Autowired; import org.springframework.test.context.ContextConfiguration; import org.springside.examples.miniweb.data.AccountData; import org.springside.examples.miniweb.entity.account.User; -import org.springside.modules.test.data.Fixtures; +import org.springside.modules.test.data.H2Fixtures; import org.springside.modules.test.spring.SpringTxTestCase; /** @@ -26,7 +26,7 @@ public class UserDaoTest extends SpringTxTestCase { @Before public void reloadSampleData() throws Exception { - Fixtures.reloadAllTable(dataSource, "/data/sample-data.xml"); + H2Fixtures.reloadAllTable(dataSource, "/data/sample-data.xml"); } @Test diff --git a/examples/mini-web/src/test/java/org/springside/examples/miniweb/functional/BaseFunctionalTestCase.java b/examples/mini-web/src/test/java/org/springside/examples/miniweb/functional/BaseFunctionalTestCase.java index 10a79702..6e8196c3 100644 --- a/examples/mini-web/src/test/java/org/springside/examples/miniweb/functional/BaseFunctionalTestCase.java +++ b/examples/mini-web/src/test/java/org/springside/examples/miniweb/functional/BaseFunctionalTestCase.java @@ -11,7 +11,7 @@ import org.junit.Ignore; import org.openqa.selenium.By; import org.openqa.selenium.WebDriver; import org.springside.examples.miniweb.Start; -import org.springside.modules.test.data.Fixtures; +import org.springside.modules.test.data.H2Fixtures; import org.springside.modules.test.functional.JettyFactory; import org.springside.modules.test.functional.Selenium2; import org.springside.modules.test.functional.WebDriverFactory; @@ -63,7 +63,7 @@ public class BaseFunctionalTestCase { * 载入测试数据. */ protected static void reloadSampleData() throws Exception { - Fixtures.reloadAllTable(dataSource, "/data/sample-data.xml"); + H2Fixtures.reloadAllTable(dataSource, "/data/sample-data.xml"); } /** diff --git a/examples/showcase/src/main/java/org/springside/examples/showcase/utilities/json/JsonDemo.java b/examples/showcase/src/main/java/org/springside/examples/showcase/utilities/json/JsonDemo.java index 4761d6e3..699d9ab1 100644 --- a/examples/showcase/src/main/java/org/springside/examples/showcase/utilities/json/JsonDemo.java +++ b/examples/showcase/src/main/java/org/springside/examples/showcase/utilities/json/JsonDemo.java @@ -1,7 +1,6 @@ package org.springside.examples.showcase.utilities.json; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertNull; +import static org.junit.Assert.*; import java.io.IOException; import java.util.Date; @@ -10,7 +9,6 @@ import java.util.List; import java.util.Map; import java.util.Map.Entry; -import org.codehaus.jackson.JsonGenerationException; import org.codehaus.jackson.JsonGenerator; import org.codehaus.jackson.JsonParser; import org.codehaus.jackson.JsonProcessingException; @@ -132,7 +130,7 @@ public class JsonDemo { //打印全部属性 JsonMapper normalMapper = JsonMapper.buildNormalMapper(); - assertEquals("{\"nullValue\":null,\"name\":\"A\",\"defaultValue\":\"hello\"}", normalMapper.toJson(bean)); + assertEquals("{\"name\":\"A\",\"defaultValue\":\"hello\",\"nullValue\":null}", normalMapper.toJson(bean)); //不打印nullValue属性 JsonMapper nonNullMapper = JsonMapper.buildNonNullMapper(); @@ -212,7 +210,7 @@ public class JsonDemo { @Override public String toString() { - return new Integer(index).toString(); + return String.valueOf(index); } } @@ -262,7 +260,7 @@ public class JsonDemo { child2.setParent(parent); parent.getChilds().add(child2); - String jsonString = "{\"childs\":[{\"name\":\"child1\"},{\"name\":\"child2\"}],\"name\":\"parent\"}"; + String jsonString = "{\"name\":\"parent\",\"childs\":[{\"name\":\"child1\"},{\"name\":\"child2\"}]}"; //打印parent的json输出，json字符串裡childs中的child1/child2都不包含到parent的屬性 assertEquals(jsonString, mapper.toJson(parent)); @@ -281,7 +279,7 @@ public class JsonDemo { private String name; private ParentChildBean parent; - public List childs = Lists.newArrayList(); + private List childs = Lists.newArrayList(); public ParentChildBean() { } @@ -339,7 +337,7 @@ public class JsonDemo { public static class ExtensibleBean { private String name; // we always have name - private HashMap properties = Maps.newHashMap(); + private Map properties = Maps.newHashMap(); public ExtensibleBean() { } @@ -367,7 +365,7 @@ public class JsonDemo { * 測試序列化Bean时使用不同的View序列化不同的属性组, 及@JsonIgnore標註的屬性. */ @Test - public void viewBean() throws JsonGenerationException, JsonMappingException, IOException { + public void viewBean() throws IOException { ViewBean viewBean = new ViewBean(); viewBean.setName("Foo"); viewBean.setAge(16); @@ -375,7 +373,7 @@ public class JsonDemo { viewBean.setIgnoreValue("ignored"); ObjectWriter publicWriter = mapper.getMapper().writerWithView(Views.Public.class); - assertEquals("{\"otherValue\":\"others\",\"name\":\"Foo\"}", publicWriter.writeValueAsString(viewBean)); + assertEquals("{\"name\":\"Foo\",\"otherValue\":\"others\"}", publicWriter.writeValueAsString(viewBean)); ObjectWriter internalWriter = mapper.getMapper().writerWithView(Views.Internal.class); assertEquals("{\"age\":16,\"otherValue\":\"others\"}", internalWriter.writeValueAsString(viewBean)); diff --git a/examples/showcase/src/test/java/org/springside/examples/showcase/common/JpaMappingTest.java b/examples/showcase/src/test/java/org/springside/examples/showcase/common/JpaMappingTest.java index b31448f1..afc3fe63 100644 --- a/examples/showcase/src/test/java/org/springside/examples/showcase/common/JpaMappingTest.java +++ b/examples/showcase/src/test/java/org/springside/examples/showcase/common/JpaMappingTest.java @@ -10,7 +10,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.test.context.ContextConfiguration; import org.springframework.test.context.transaction.TransactionConfiguration; -import org.springside.modules.test.data.Fixtures; +import org.springside.modules.test.data.H2Fixtures; import org.springside.modules.test.spring.SpringTxTestCase; @ContextConfiguration(locations = { "/applicationContext.xml" }) @@ -24,7 +24,7 @@ public class JpaMappingTest extends SpringTxTestCase { @Test public void allClassMapping() throws Exception { - Fixtures.reloadAllTable(dataSource, "/data/sample-data.xml"); + H2Fixtures.reloadAllTable(dataSource, "/data/sample-data.xml"); Metamodel model = em.getEntityManagerFactory().getMetamodel(); for (EntityType entityType : model.getEntities()) { String entityName = entityType.getName(); diff --git a/examples/showcase/src/test/java/org/springside/examples/showcase/functional/BaseFunctionalTestCase.java b/examples/showcase/src/test/java/org/springside/examples/showcase/functional/BaseFunctionalTestCase.java index 873c4ef0..d46c90ab 100644 --- a/examples/showcase/src/test/java/org/springside/examples/showcase/functional/BaseFunctionalTestCase.java +++ b/examples/showcase/src/test/java/org/springside/examples/showcase/functional/BaseFunctionalTestCase.java @@ -6,7 +6,7 @@ import org.eclipse.jetty.server.Server; import org.junit.BeforeClass; import org.junit.Ignore; import org.springside.examples.showcase.Start; -import org.springside.modules.test.data.Fixtures; +import org.springside.modules.test.data.H2Fixtures; import org.springside.modules.test.functional.JettyFactory; import org.springside.modules.test.spring.SpringContextHolder; @@ -45,6 +45,6 @@ public class BaseFunctionalTestCase { * 载入默认数据. */ protected static void reloadSampleData() throws Exception { - Fixtures.reloadAllTable(dataSource, "/data/sample-data.xml"); + H2Fixtures.reloadAllTable(dataSource, "/data/sample-data.xml"); } } diff --git a/examples/showcase/src/test/java/org/springside/examples/showcase/schedule/JdkExecutorJobTest.java b/examples/showcase/src/test/java/org/springside/examples/showcase/schedule/JdkExecutorJobTest.java index 3130ae7d..96c17e60 100644 --- a/examples/showcase/src/test/java/org/springside/examples/showcase/schedule/JdkExecutorJobTest.java +++ b/examples/showcase/src/test/java/org/springside/examples/showcase/schedule/JdkExecutorJobTest.java @@ -8,7 +8,7 @@ import org.springframework.test.annotation.DirtiesContext; import org.springframework.test.context.ContextConfiguration; import org.springframework.test.context.transaction.TransactionConfiguration; import org.springside.modules.log.MockLog4jAppender; -import org.springside.modules.test.data.Fixtures; +import org.springside.modules.test.data.H2Fixtures; import org.springside.modules.test.spring.SpringTxTestCase; import org.springside.modules.utils.Threads; @@ -20,7 +20,7 @@ public class JdkExecutorJobTest extends SpringTxTestCase { @Test public void scheduleJob() throws Exception { - Fixtures.reloadAllTable(dataSource, "/data/sample-data.xml"); + H2Fixtures.reloadAllTable(dataSource, "/data/sample-data.xml"); //加载测试用logger appender MockLog4jAppender appender = new MockLog4jAppender(); diff --git a/examples/showcase/src/test/java/org/springside/examples/showcase/schedule/QuartzClusterableJobTest.java b/examples/showcase/src/test/java/org/springside/examples/showcase/schedule/QuartzClusterableJobTest.java index 7d0fda5e..dd4d7b85 100644 --- a/examples/showcase/src/test/java/org/springside/examples/showcase/schedule/QuartzClusterableJobTest.java +++ b/examples/showcase/src/test/java/org/springside/examples/showcase/schedule/QuartzClusterableJobTest.java @@ -8,7 +8,7 @@ import org.springframework.test.annotation.DirtiesContext; import org.springframework.test.context.ContextConfiguration; import org.springframework.test.context.transaction.TransactionConfiguration; import org.springside.modules.log.MockLog4jAppender; -import org.springside.modules.test.data.Fixtures; +import org.springside.modules.test.data.H2Fixtures; import org.springside.modules.test.spring.SpringTxTestCase; import org.springside.modules.utils.Threads; @@ -25,7 +25,7 @@ public class QuartzClusterableJobTest extends SpringTxTestCase { @Test public void scheduleJob() throws Exception { - Fixtures.reloadAllTable(dataSource, "/data/sample-data.xml"); + H2Fixtures.reloadAllTable(dataSource, "/data/sample-data.xml"); //加载测试用logger appender MockLog4jAppender appender = new MockLog4jAppender(); diff --git a/modules/core/src/main/java/org/springside/modules/orm/jpa/Jpas.java b/modules/core/src/main/java/org/springside/modules/orm/jpa/Jpas.java index bb5c681d..4460842a 100644 --- a/modules/core/src/main/java/org/springside/modules/orm/jpa/Jpas.java +++ b/modules/core/src/main/java/org/springside/modules/orm/jpa/Jpas.java @@ -3,6 +3,9 @@ package org.springside.modules.orm.jpa; import org.hibernate.Hibernate; public class Jpas { + private Jpas() { + + } public static void initLazyProperty(Object proxyed) { Hibernate.initialize(proxyed); diff --git a/modules/core/src/main/java/org/springside/modules/test/data/Fixtures.java b/modules/core/src/main/java/org/springside/modules/test/data/H2Fixtures.java similarity index 98% rename from modules/core/src/main/java/org/springside/modules/test/data/Fixtures.java rename to modules/core/src/main/java/org/springside/modules/test/data/H2Fixtures.java index e1b376d1..ece6f265 100644 --- a/modules/core/src/main/java/org/springside/modules/test/data/Fixtures.java +++ b/modules/core/src/main/java/org/springside/modules/test/data/H2Fixtures.java @@ -32,12 +32,12 @@ import org.springside.modules.utils.PropertiesLoader; /** * 基于DBUnit初始化测试数据到H2数据库的工具类. */ -public class Fixtures { +public class H2Fixtures { private static Logger logger = LoggerFactory.getLogger(PropertiesLoader.class); private static ResourceLoader resourceLoader = new DefaultResourceLoader(); - private Fixtures() { + private H2Fixtures() { } /** @@ -116,6 +116,8 @@ public class Fixtures { } } + rs.close(); + deleteTable(h2DataSource, tableNames.toArray(new String[tableNames.size()])); } catch (SQLException e) { Exceptions.unchecked(e); diff --git a/modules/core/src/main/java/org/springside/modules/utils/Exceptions.java b/modules/core/src/main/java/org/springside/modules/utils/Exceptions.java index 8cfef88f..2c7a0db6 100644 --- a/modules/core/src/main/java/org/springside/modules/utils/Exceptions.java +++ b/modules/core/src/main/java/org/springside/modules/utils/Exceptions.java @@ -15,6 +15,9 @@ import java.io.StringWriter; */ public class Exceptions { + private Exceptions() { + } + /** * 将CheckedException转换为UncheckedException. */ diff --git a/modules/core/src/test/java/org/springside/modules/test/data/FixturesTest.java b/modules/core/src/test/java/org/springside/modules/test/data/FixturesTest.java index 27875c16..ac3abb9a 100644 --- a/modules/core/src/test/java/org/springside/modules/test/data/FixturesTest.java +++ b/modules/core/src/test/java/org/springside/modules/test/data/FixturesTest.java @@ -7,7 +7,7 @@ import javax.sql.DataSource; import org.junit.Test; import org.springframework.beans.BeansException; import org.springframework.test.context.ContextConfiguration; -import org.springside.modules.test.data.Fixtures; +import org.springside.modules.test.data.H2Fixtures; import org.springside.modules.test.spring.SpringTxTestCase; @ContextConfiguration(locations = { "/applicationContext-core-test.xml" }) @@ -20,20 +20,20 @@ public class FixturesTest extends SpringTxTestCase { executeSqlScript("classpath:/schema.sql", false); DataSource ds = (DataSource) applicationContext.getBean("dataSource"); - Fixtures.loadData(ds, "classpath:/test-data.xml"); + H2Fixtures.loadData(ds, "classpath:/test-data.xml"); assertEquals(6, countRowsInTable("SS_USER")); - Fixtures.reloadData(ds, "classpath:/test-data.xml"); + H2Fixtures.reloadData(ds, "classpath:/test-data.xml"); assertEquals(6, countRowsInTable("SS_USER")); - Fixtures.deleteData(ds, "classpath:/test-data.xml"); + H2Fixtures.deleteData(ds, "classpath:/test-data.xml"); assertEquals(0, countRowsInTable("SS_USER")); - Fixtures.loadData(ds, "classpath:/test-data.xml"); - Fixtures.deleteAllTable(ds); + H2Fixtures.loadData(ds, "classpath:/test-data.xml"); + H2Fixtures.deleteAllTable(ds); assertEquals(0, countRowsInTable("SS_USER")); - Fixtures.reloadAllTable(ds, "classpath:/test-data.xml"); + H2Fixtures.reloadAllTable(ds, "classpath:/test-data.xml"); assertEquals(6, countRowsInTable("SS_USER")); } diff --git a/modules/parent/pom.xml b/modules/parent/pom.xml index c4061730..d1d8de92 100644 --- a/modules/parent/pom.xml +++ b/modules/parent/pom.xml @@ -939,7 +939,7 @@ maven-checkstyle-plugin 2.9.1 - ../../support/sonar/checkstyle.xml + ../../support/sonar/springside-checkstyle.xml @@ -948,7 +948,8 @@ 2.7.1 ${jdk.version} - ../../support/sonar/pmd.xml + ../../support/sonar/springside-pmd.xml + html @@ -964,13 +965,19 @@ findbugs-maven-plugin 2.4.0 - ../../support/sonar/findbugs.xml + ../../support/sonar/springside-findbugs.xml html + + + org.codehaus.mojo + sonar-maven-plugin + 2.0 + diff --git a/support/sonar/README.txt b/support/sonar/README.txt new file mode 100644 index 00000000..04592b49 --- /dev/null +++ b/support/sonar/README.txt @@ -0,0 +1,2 @@ +sonar-*.xml are backup from sonar-2.13.1 +springside-*.xml is a springside version, please see the wiki for changes. \ No newline at end of file diff --git a/support/sonar/checkstyle.xml b/support/sonar/sonar-checkstyle.xml similarity index 100% rename from support/sonar/checkstyle.xml rename to support/sonar/sonar-checkstyle.xml diff --git a/support/sonar/findbugs.xml b/support/sonar/sonar-findbugs.xml similarity index 100% rename from support/sonar/findbugs.xml rename to support/sonar/sonar-findbugs.xml diff --git a/support/sonar/pmd.xml b/support/sonar/sonar-pmd.xml similarity index 100% rename from support/sonar/pmd.xml rename to support/sonar/sonar-pmd.xml diff --git a/support/sonar/sonarway.xml b/support/sonar/sonar-way.xml similarity index 100% rename from support/sonar/sonarway.xml rename to support/sonar/sonar-way.xml diff --git a/support/sonar/springside-checkstyle.xml b/support/sonar/springside-checkstyle.xml new file mode 100644 index 00000000..7c790b80 --- /dev/null +++ b/support/sonar/springside-checkstyle.xml @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/support/sonar/springside-findbugs.xml b/support/sonar/springside-findbugs.xml new file mode 100644 index 00000000..6fcf8e7b --- /dev/null +++ b/support/sonar/springside-findbugs.xml @@ -0,0 +1,1120 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/support/sonar/springside-pmd.xml b/support/sonar/springside-pmd.xml new file mode 100644 index 00000000..7c5b25d6 --- /dev/null +++ b/support/sonar/springside-pmd.xml @@ -0,0 +1,259 @@ + + + + 3 + + + 3 + + + 3 + + + 3 + + + 3 + + + 3 + + + 3 + + + 3 + + + 3 + + + 3 + + + 3 + + + 3 + + + 3 + + + 3 + + + 3 + + + 4 + + + 3 + + + 2 + + + 3 + + + 3 + + + 3 + + + 3 + + + 4 + + + 2 + + + 4 + + + 3 + + + 3 + + + 2 + + + 2 + + + 4 + + + 2 + + + 3 + + + 3 + + + 5 + + + 3 + + + 3 + + + 2 + + + 2 + + + 2 + + + 3 + + + 3 + + + 2 + + + 3 + + + 3 + + + 4 + + + 4 + + + 3 + + + 3 + + + 3 + + + 3 + + + 3 + + + 3 + + + 3 + + + 3 + + + + + + 3 + + + 3 + + + 3 + + + 3 + + + + + + 4 + + + 2 + + + 3 + + + 4 + + + 3 + + + 3 + + + 3 + + + 3 + + + 2 + + + 3 + + + 3 + + + 3 + + + 3 + + + 3 + + + 3 + + + 3 + + + 3 + + + 3 + + + 3 + + + 4 + + + 3 + + + 3 + + + 3 + + + 4 + + + 3 + + + diff --git a/support/sonar/springside-way.xml b/support/sonar/springside-way.xml new file mode 100644 index 00000000..68f901b9 --- /dev/null +++ b/support/sonar/springside-way.xml @@ -0,0 +1 @@ +SpringSide wayjavafindbugsUWF_NULL_FIELDCRITICALfindbugsOS_OPEN_STREAMCRITICALfindbugsHE_USE_OF_UNHASHABLE_CLASSCRITICALfindbugsEQ_ABSTRACT_SELFMAJORfindbugsNM_SAME_SIMPLE_NAME_AS_SUPERCLASSMAJORfindbugsJ2EE_STORE_OF_NON_SERIALIZABLE_OBJECT_INTO_SESSIONCRITICALfindbugsTQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINKCRITICALfindbugsRCN_REDUNDANT_COMPARISON_TWO_NULL_VALUESCRITICALfindbugsSIC_INNER_SHOULD_BE_STATIC_ANONMAJORfindbugsJCIP_FIELD_ISNT_FINAL_IN_IMMUTABLE_CLASSMINORfindbugsEQ_SELF_USE_OBJECTMAJORfindbugsNM_CLASS_NOT_EXCEPTIONMAJORfindbugsQBA_QUESTIONABLE_BOOLEAN_ASSIGNMENTCRITICALfindbugsRCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUECRITICALfindbugsSE_METHOD_MUST_BE_PRIVATEMAJORfindbugsBC_IMPOSSIBLE_INSTANCEOFCRITICALfindbugsEC_ARRAY_AND_NONARRAYCRITICALfindbugsFI_EXPLICIT_INVOCATIONMAJORfindbugsSS_SHOULD_BE_STATICMAJORfindbugsBIT_IORCRITICALfindbugsSE_NONFINAL_SERIALVERSIONIDCRITICALfindbugsMS_SHOULD_BE_FINALMAJORfindbugsEQ_DONT_DEFINE_EQUALS_FOR_ENUMMAJORfindbugsSE_TRANSIENT_FIELD_NOT_RESTOREDMAJORfindbugsVA_FORMAT_STRING_EXTRA_ARGUMENTS_PASSEDMAJORfindbugsEQ_ALWAYS_FALSECRITICALfindbugsRV_REM_OF_RANDOM_INTCRITICALfindbugsINT_VACUOUS_BIT_OPERATIONCRITICALfindbugsSF_SWITCH_NO_DEFAULTMAJORfindbugsIL_INFINITE_LOOPCRITICALfindbugsNP_NULL_PARAM_DEREFCRITICALfindbugsAM_CREATES_EMPTY_JAR_FILE_ENTRYMAJORfindbugsEQ_COMPARING_CLASS_NAMESMAJORfindbugsNP_ALWAYS_NULL_EXCEPTIONCRITICALfindbugsDB_DUPLICATE_BRANCHESCRITICALfindbugsIMSE_DONT_CATCH_IMSEMAJORfindbugsXSS_REQUEST_PARAMETER_TO_SERVLET_WRITERCRITICALfindbugsDM_STRING_CTORMAJORfindbugsSE_NO_SERIALVERSIONIDMAJORfindbugsSE_BAD_FIELD_STORECRITICALfindbugsEC_UNRELATED_TYPES_USING_POINTER_EQUALITYCRITICALfindbugsSE_NO_SUITABLE_CONSTRUCTOR_FOR_EXTERNALIZATIONMAJORfindbugsDMI_HARDCODED_ABSOLUTE_FILENAMECRITICALfindbugsRU_INVOKE_RUNMAJORfindbugsSQL_BAD_RESULTSET_ACCESSCRITICALfindbugsIJU_ASSERT_METHOD_INVOKED_FROM_RUN_METHODCRITICALfindbugsBX_BOXING_IMMEDIATELY_UNBOXEDMAJORfindbugsVA_FORMAT_STRING_BAD_CONVERSION_FROM_ARRAYMAJORfindbugsHE_HASHCODE_NO_EQUALSCRITICALfindbugsSI_INSTANCE_BEFORE_FINALS_ASSIGNEDCRITICALfindbugsUI_INHERITANCE_UNSAFE_GETRESOURCEMAJORfindbugsNP_SYNC_AND_NULL_CHECK_FIELDMAJORfindbugsRpC_REPEATED_CONDITIONAL_TESTMAJORfindbugsDLS_DEAD_LOCAL_STORE_IN_RETURNCRITICALfindbugsEC_UNRELATED_CLASS_AND_INTERFACECRITICALfindbugsRE_CANT_USE_FILE_SEPARATOR_AS_REGULAR_EXPRESSIONCRITICALfindbugsHE_INHERITS_EQUALS_USE_HASHCODECRITICALfindbugsNP_DEREFERENCE_OF_READLINE_VALUECRITICALfindbugsWA_NOT_IN_LOOPCRITICALfindbugsBC_IMPOSSIBLE_CASTCRITICALfindbugsOS_OPEN_STREAM_EXCEPTION_PATHCRITICALfindbugsICAST_QUESTIONABLE_UNSIGNED_RIGHT_SHIFTCRITICALfindbugsNP_NULL_ON_SOME_PATH_EXCEPTIONCRITICALfindbugsDMI_ANNOTATION_IS_NOT_VISIBLE_TO_REFLECTIONMAJORfindbugsIC_INIT_CIRCULARITYCRITICALfindbugsUM_UNNECESSARY_MATHCRITICALfindbugsNM_CLASS_NAMING_CONVENTIONMAJORfindbugsSTCAL_STATIC_CALENDAR_INSTANCECRITICALfindbugsNP_ALWAYS_NULLCRITICALfindbugsRCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPECRITICALfindbugsNP_GUARANTEED_DEREF_ON_EXCEPTION_PATHCRITICALfindbugsUUF_UNUSED_FIELDMAJORfindbugsEQ_DOESNT_OVERRIDE_EQUALSMAJORfindbugsINT_BAD_COMPARISON_WITH_SIGNED_BYTECRITICALfindbugsNP_CLONE_COULD_RETURN_NULLCRITICALfindbugsHE_EQUALS_NO_HASHCODEMAJORfindbugsIS_FIELD_NOT_GUARDEDCRITICALfindbugsNM_LCASE_TOSTRINGMAJORfindbugsNM_WRONG_PACKAGEMAJORfindbugsUCF_USELESS_CONTROL_FLOWCRITICALfindbugsDM_USELESS_THREADMAJORfindbugsDMI_USING_REMOVEALL_TO_CLEAR_COLLECTIONCRITICALfindbugsSQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRINGCRITICALfindbugsNP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENTCRITICALfindbugsICAST_BAD_SHIFT_AMOUNTCRITICALfindbugsICAST_IDIV_CAST_TO_DOUBLECRITICALfindbugsFI_NULLIFY_SUPERCRITICALfindbugsMS_MUTABLE_HASHTABLEMAJORfindbugsSE_READ_RESOLVE_MUST_RETURN_OBJECTMAJORfindbugsSIO_SUPERFLUOUS_INSTANCEOFCRITICALfindbugsBOA_BADLY_OVERRIDDEN_ADAPTERCRITICALfindbugsIM_AVERAGE_COMPUTATION_COULD_OVERFLOWCRITICALfindbugsDM_NEW_FOR_GETCLASSMAJORfindbugsNM_CONFUSINGMAJORfindbugsWMI_WRONG_MAP_ITERATORCRITICALfindbugsNP_UNWRITTEN_FIELDMAJORfindbugsSE_BAD_FIELD_INNER_CLASSMINORfindbugsRV_RETURN_VALUE_IGNORED_BAD_PRACTICEMAJORfindbugsUCF_USELESS_CONTROL_FLOW_NEXT_LINECRITICALfindbugsNP_GUARANTEED_DEREFCRITICALfindbugsEI_EXPOSE_STATIC_REP2MAJORfindbugsNM_FUTURE_KEYWORD_USED_AS_MEMBER_IDENTIFIERMAJORfindbugsWA_AWAIT_NOT_IN_LOOPCRITICALfindbugsRC_REF_COMPARISONCRITICALfindbugsSC_START_IN_CTORCRITICALfindbugsMF_CLASS_MASKS_FIELDMAJORfindbugsDMI_INVOKING_HASHCODE_ON_ARRAYCRITICALfindbugsPS_PUBLIC_SEMAPHORESCRITICALfindbugsPZLA_PREFER_ZERO_LENGTH_ARRAYSMAJORfindbugsSKIPPED_CLASS_TOO_BIGMINORfindbugsHSC_HUGE_SHARED_STRING_CONSTANTCRITICALfindbugsUR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTORMAJORfindbugsVA_FORMAT_STRING_ILLEGALCRITICALfindbugsSA_LOCAL_SELF_COMPUTATIONCRITICALfindbugsSE_NO_SUITABLE_CONSTRUCTORMAJORfindbugsMWN_MISMATCHED_NOTIFYCRITICALfindbugsNP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUSCRITICALfindbugsSTCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCECRITICALfindbugsSE_READ_RESOLVE_IS_STATICMAJORfindbugsSA_LOCAL_DOUBLE_ASSIGNMENTCRITICALfindbugsRV_RETURN_VALUE_IGNORED2MAJORfindbugsRI_REDUNDANT_INTERFACESMAJORfindbugsMTIA_SUSPECT_SERVLET_INSTANCE_FIELDCRITICALfindbugsFI_FINALIZER_ONLY_NULLS_FIELDSMAJORfindbugsIO_APPENDING_TO_OBJECT_OUTPUT_STREAMCRITICALfindbugsVA_FORMAT_STRING_NO_PREVIOUS_ARGUMENTCRITICALfindbugsNM_VERY_CONFUSINGMAJORfindbugsDM_RUN_FINALIZERS_ON_EXITMAJORfindbugsSTCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCECRITICALfindbugsFE_TEST_IF_EQUAL_TO_NOT_A_NUMBERCRITICALfindbugsFI_FINALIZER_NULLS_FIELDSMAJORfindbugsDMI_UNSUPPORTED_METHODMAJORfindbugsDMI_CONSTANT_DB_PASSWORDCRITICALfindbugsTLW_TWO_LOCK_WAITMAJORfindbugsRV_01_TO_INTMAJORfindbugsIA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHODMAJORfindbugsDMI_COLLECTION_OF_URLSCRITICALfindbugsBIT_AND_ZZCRITICALfindbugsDM_STRING_VOID_CTORMAJORfindbugsNM_METHOD_NAMING_CONVENTIONMAJORfindbugsUL_UNRELEASED_LOCKCRITICALfindbugsHRS_REQUEST_PARAMETER_TO_HTTP_HEADERMAJORfindbugsCN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLEMAJORfindbugsSIC_THREADLOCAL_DEADLY_EMBRACEMAJORfindbugsMF_METHOD_MASKS_FIELDMAJORfindbugsDL_SYNCHRONIZATION_ON_SHARED_CONSTANTCRITICALfindbugsINT_BAD_REM_BY_1CRITICALfindbugsNM_WRONG_PACKAGE_INTENTIONALMAJORfindbugsES_COMPARING_STRINGS_WITH_EQMAJORfindbugsSA_FIELD_SELF_COMPARISONCRITICALfindbugsVA_FORMAT_STRING_BAD_CONVERSION_TO_BOOLEANMAJORfindbugsQF_QUESTIONABLE_FOR_LOOPCRITICALfindbugsXFB_XML_FACTORY_BYPASSCRITICALfindbugsCI_CONFUSED_INHERITANCEMINORfindbugsSE_INNER_CLASSMAJORfindbugsUWF_UNWRITTEN_FIELDMINORfindbugsBC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTSCRITICALfindbugsDLS_DEAD_STORE_OF_CLASS_LITERALCRITICALfindbugsCN_IDIOM_NO_SUPER_CALLMAJORfindbugsWS_WRITEOBJECT_SYNCCRITICALfindbugsFI_USELESSMINORfindbugsML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELDMAJORfindbugsNM_METHOD_CONSTRUCTOR_CONFUSIONMAJORfindbugsMWN_MISMATCHED_WAITCRITICALfindbugsDM_NEXTINT_VIA_NEXTDOUBLEMAJORfindbugsFL_MATH_USING_FLOAT_PRECISIONCRITICALfindbugsML_SYNC_ON_UPDATED_FIELDMAJORfindbugsVA_FORMAT_STRING_EXPECTED_MESSAGE_FORMAT_SUPPLIEDMAJORfindbugsDMI_NONSERIALIZABLE_OBJECT_WRITTENCRITICALfindbugsMTIA_SUSPECT_STRUTS_INSTANCE_FIELDCRITICALfindbugsEQ_OTHER_USE_OBJECTMAJORfindbugsRCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUECRITICALfindbugsDLS_DEAD_LOCAL_STORE_OF_NULLCRITICALfindbugsDMI_BLOCKING_METHODS_ON_URLCRITICALfindbugsNP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLECRITICALfindbugsMS_CANNOT_BE_FINALMAJORfindbugsIM_BAD_CHECK_FOR_ODDCRITICALfindbugsDMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAYCRITICALfindbugsNP_STORE_INTO_NONNULL_FIELDCRITICALfindbugsSP_SPIN_ON_FIELDMAJORfindbugsNM_VERY_CONFUSING_INTENTIONALMAJORfindbugsICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEILCRITICALfindbugsIS2_INCONSISTENT_SYNCCRITICALfindbugsODR_OPEN_DATABASE_RESOURCE_EXCEPTION_PATHCRITICALfindbugsXSS_REQUEST_PARAMETER_TO_SEND_ERRORCRITICALfindbugsDMI_SCHEDULED_THREAD_POOL_EXECUTOR_WITH_ZERO_CORE_THREADSMINORfindbugsCN_IDIOMMAJORfindbugsGC_UNCHECKED_TYPE_IN_GENERIC_CALLCRITICALfindbugsSE_PRIVATE_READ_RESOLVE_NOT_INHERITEDMAJORfindbugsDMI_INVOKING_TOSTRING_ON_ARRAYCRITICALfindbugsSW_SWING_METHODS_INVOKED_IN_SWING_THREADMAJORfindbugsDL_SYNCHRONIZATION_ON_BOOLEANCRITICALfindbugsSF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH_TO_THROWCRITICALfindbugsNP_NULL_ON_SOME_PATH_FROM_RETURN_VALUECRITICALfindbugsNP_ARGUMENT_MIGHT_BE_NULLMAJORfindbugsDM_EXITMAJORfindbugsCO_ABSTRACT_SELFMAJORfindbugsRV_RETURN_VALUE_OF_PUTIFABSENT_IGNOREDMAJORfindbugsDC_DOUBLECHECKMAJORfindbugsUL_UNRELEASED_LOCK_EXCEPTION_PATHCRITICALfindbugsEC_BAD_ARRAY_COMPARECRITICALfindbugsSE_BAD_FIELDMAJORfindbugsSA_LOCAL_SELF_ASSIGNMENTCRITICALfindbugsREC_CATCH_EXCEPTIONMAJORfindbugsTQ_NEVER_VALUE_USED_WHERE_ALWAYS_REQUIREDCRITICALfindbugsDMI_VACUOUS_SELF_COLLECTION_CALLCRITICALfindbugsUR_UNINIT_READMAJORfindbugsDMI_FUTILE_ATTEMPT_TO_CHANGE_MAXPOOL_SIZE_OF_SCHEDULED_THREAD_POOL_EXECUTORMINORfindbugsBIT_ANDCRITICALfindbugsRR_NOT_CHECKEDMAJORfindbugsST_WRITE_TO_STATIC_FROM_INSTANCE_METHODCRITICALfindbugsDMI_COLLECTIONS_SHOULD_NOT_CONTAIN_THEMSELVESCRITICALfindbugsNP_TOSTRING_COULD_RETURN_NULLCRITICALfindbugsEQ_SELF_NO_OBJECTMAJORfindbugsGC_UNRELATED_TYPESCRITICALfindbugsEC_NULL_ARGCRITICALfindbugsHE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASSCRITICALfindbugsNP_NONNULL_RETURN_VIOLATIONCRITICALfindbugsIL_INFINITE_RECURSIVE_LOOPCRITICALfindbugsDM_STRING_TOSTRINGINFOfindbugsVA_PRIMITIVE_ARRAY_PASSED_TO_OBJECT_VARARGCRITICALfindbugsAM_CREATES_EMPTY_ZIP_FILE_ENTRYMAJORfindbugsNS_NON_SHORT_CIRCUITMAJORfindbugsDLS_DEAD_LOCAL_STORECRITICALfindbugsDM_BOOLEAN_CTORMAJORfindbugsBC_BAD_CAST_TO_CONCRETE_COLLECTIONCRITICALfindbugsSIC_INNER_SHOULD_BE_STATIC_NEEDS_THISMAJORfindbugsLI_LAZY_INIT_STATICCRITICALfindbugsHE_EQUALS_USE_HASHCODECRITICALfindbugsRV_ABSOLUTE_VALUE_OF_RANDOM_INTCRITICALfindbugsFE_FLOATING_POINT_EQUALITYCRITICALfindbugsNM_FUTURE_KEYWORD_USED_AS_IDENTIFIERMAJORfindbugsICAST_INTEGER_MULTIPLY_CAST_TO_LONGCRITICALfindbugsSTI_INTERRUPTED_ON_UNKNOWNTHREADCRITICALfindbugsNM_SAME_SIMPLE_NAME_AS_INTERFACEMAJORfindbugsSA_FIELD_SELF_ASSIGNMENTCRITICALfindbugsDMI_EMPTY_DB_PASSWORDCRITICALfindbugsIJU_BAD_SUITE_METHODCRITICALfindbugsVA_FORMAT_STRING_MISSING_ARGUMENTCRITICALfindbugsWL_USING_GETCLASS_RATHER_THAN_CLASS_LITERALCRITICALfindbugsSBSC_USE_STRINGBUFFER_CONCATENATIONCRITICALfindbugsBIT_ADD_OF_SIGNED_BYTECRITICALfindbugsTQ_ALWAYS_VALUE_USED_WHERE_NEVER_REQUIREDCRITICALfindbugsSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTECRITICALfindbugsRE_BAD_SYNTAX_FOR_REGULAR_EXPRESSIONCRITICALfindbugsNP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLECRITICALfindbugsEQ_ALWAYS_TRUECRITICALfindbugsSTCAL_INVOKE_ON_STATIC_CALENDAR_INSTANCECRITICALfindbugsBC_BAD_CAST_TO_ABSTRACT_COLLECTIONMAJORfindbugsISC_INSTANTIATE_STATIC_CLASSMAJORfindbugsIT_NO_SUCH_ELEMENTMINORfindbugsINT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUECRITICALfindbugsEI_EXPOSE_REPMAJORfindbugsJLM_JSR166_LOCK_MONITORENTERCRITICALfindbugsBIT_IOR_OF_SIGNED_BYTECRITICALfindbugsMSF_MUTABLE_SERVLET_FIELDMAJORfindbugsIS_INCONSISTENT_SYNCMAJORfindbugsRV_REM_OF_HASHCODECRITICALfindbugsLG_LOST_LOGGER_DUE_TO_WEAK_REFERENCEINFOfindbugsICAST_INT_CAST_TO_FLOAT_PASSED_TO_ROUNDCRITICALfindbugsSE_NONSTATIC_SERIALVERSIONIDMAJORfindbugsBC_VACUOUS_INSTANCEOFCRITICALfindbugsRV_ABSOLUTE_VALUE_OF_HASHCODECRITICALfindbugsRC_REF_COMPARISON_BAD_PRACTICE_BOOLEANMAJORfindbugsDMI_CALLING_NEXT_FROM_HASNEXTCRITICALfindbugsNP_NULL_ON_SOME_PATHCRITICALfindbugsRS_READOBJECT_SYNCCRITICALfindbugsEC_INCOMPATIBLE_ARRAY_COMPARECRITICALfindbugsBC_IMPOSSIBLE_DOWNCAST_OF_TOARRAYCRITICALfindbugsNS_DANGEROUS_NON_SHORT_CIRCUITCRITICALfindbugsBC_UNCONFIRMED_CASTCRITICALfindbugsSA_FIELD_DOUBLE_ASSIGNMENTCRITICALfindbugsEQ_GETCLASS_AND_CLASS_CONSTANTCRITICALfindbugsVA_FORMAT_STRING_ARG_MISMATCHCRITICALfindbugsMS_OOI_PKGPROTECTMAJORfindbugsEC_UNRELATED_TYPESCRITICALfindbugsMS_EXPOSE_REPCRITICALfindbugsBX_UNBOXED_AND_COERCED_FOR_TERNARY_OPERATORMAJORfindbugsSF_SWITCH_FALLTHROUGHCRITICALfindbugsDMI_LONG_BITS_TO_DOUBLE_INVOKED_ON_INTCRITICALfindbugsHRS_REQUEST_PARAMETER_TO_COOKIEMAJORfindbugsESync_EMPTY_SYNCMAJORfindbugsNP_IMMEDIATE_DEREFERENCE_OF_READLINECRITICALfindbugsIJU_NO_TESTSCRITICALfindbugsUMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASSCRITICALfindbugsRE_POSSIBLE_UNINTENDED_PATTERNCRITICALfindbugsDLS_OVERWRITTEN_INCREMENTCRITICALcheckstylecom.puppycrawl.tools.checkstyle.checks.coding.ParameterAssignmentCheckMAJORcheckstylecom.puppycrawl.tools.checkstyle.checks.design.HideUtilityClassConstructorCheckMAJORcheckstylecom.puppycrawl.tools.checkstyle.checks.coding.SimplifyBooleanExpressionCheckMAJORcheckstylecom.puppycrawl.tools.checkstyle.checks.naming.StaticVariableNameCheckMAJORformat^[a-z][a-zA-Z0-9]*$applyToPublictrueapplyToProtectedtrueapplyToPackagetrueapplyToPrivatetruecheckstylecom.puppycrawl.tools.checkstyle.checks.modifier.ModifierOrderCheckMINORcheckstylecom.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheckMAJORformat^[a-z][a-zA-Z0-9]*$allowClassNamefalsecheckstylecom.puppycrawl.tools.checkstyle.checks.coding.EmptyStatementCheckMINORcheckstylecom.puppycrawl.tools.checkstyle.checks.coding.InnerAssignmentCheckMAJORcheckstylecom.puppycrawl.tools.checkstyle.checks.coding.DoubleCheckedLockingCheckMAJORcheckstylecom.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckINFOprocessJavadocfalsecheckstylecom.puppycrawl.tools.checkstyle.checks.coding.StringLiteralEqualityCheckMAJORcheckstylecom.puppycrawl.tools.checkstyle.checks.modifier.RedundantModifierCheckMINORcheckstylecom.puppycrawl.tools.checkstyle.checks.coding.RedundantThrowsCheckMINORcheckstylecom.puppycrawl.tools.checkstyle.checks.coding.IllegalThrowsCheckMAJORcheckstylecom.puppycrawl.tools.checkstyle.checks.sizes.AnonInnerLengthCheckMAJORcheckstylecom.puppycrawl.tools.checkstyle.checks.naming.MemberNameCheckMAJORformat^[a-z][a-zA-Z0-9]*$applyToPublictrueapplyToProtectedtrueapplyToPackagetrueapplyToPrivatetruecheckstylecom.puppycrawl.tools.checkstyle.checks.naming.ConstantNameCheckMINORformat^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$applyToPublictrueapplyToProtectedtrueapplyToPackagetrueapplyToPrivatetruecheckstylecom.puppycrawl.tools.checkstyle.checks.naming.PackageNameCheckMAJORformat^[a-z]+(\.[a-zA-Z_][a-zA-Z0-9_]*)*$checkstylecom.puppycrawl.tools.checkstyle.checks.coding.DefaultComesLastCheckMAJORcheckstylecom.puppycrawl.tools.checkstyle.checks.coding.EqualsHashCodeCheckCRITICALcheckstylecom.puppycrawl.tools.checkstyle.checks.coding.SimplifyBooleanReturnCheckMAJORcheckstylecom.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheckMAJORtokensVARIABLE_DEFignoreConstructorParametertrueignoreSettertrueignoreAbstractMethodstruecheckstylecom.puppycrawl.tools.checkstyle.checks.naming.LocalFinalVariableNameCheckMAJORformat^[a-z][a-zA-Z0-9]*$checkstylecom.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheckMAJORprotectedAllowedtruecheckstylecom.puppycrawl.tools.checkstyle.checks.coding.MagicNumberCheckINFOignoreHashCodeMethodfalseignoreAnnotationfalsecheckstylecom.puppycrawl.tools.checkstyle.checks.naming.LocalVariableNameCheckMAJORformat^[a-z][a-zA-Z0-9]*$checkstylecom.puppycrawl.tools.checkstyle.checks.naming.ParameterNameCheckMAJORformat^[a-z][a-zA-Z0-9]*$checkstylecom.puppycrawl.tools.checkstyle.checks.metrics.BooleanExpressionComplexityCheckMAJORcheckstylecom.puppycrawl.tools.checkstyle.checks.metrics.CyclomaticComplexityCheckMAJORmax10pmdUnusedNullCheckInEqualsMAJORpmdStringInstantiationMAJORpmdConstructorCallsOverridableMethodMAJORpmdAvoidCatchingNPEMAJORpmdAvoidRethrowingExceptionMAJORpmdReplaceEnumerationWithIteratorMAJORpmdAvoidArrayLoopsMAJORpmdUnusedFormalParameterMAJORpmdEmptySwitchStatementsMAJORpmdClassCastExceptionWithToArrayMAJORpmdAvoidThrowingNullPointerExceptionMAJORpmdUnusedPrivateFieldMAJORpmdCompareObjectsWithEqualsMAJORpmdUseIndexOfCharMAJORpmdBigIntegerInstantiationMAJORpmdFinalFieldCouldBeStaticMINORpmdIfStmtsMustUseBracesMAJORpmdSuspiciousEqualsMethodNameCRITICALpmdInstantiationToGetClassMAJORpmdSuspiciousHashcodeMethodNameMAJORpmdLooseCouplingMAJORpmdUnusedLocalVariableMAJORpmdUnnecessaryCaseChangeMINORpmdEmptySynchronizedBlockCRITICALpmdSingularFieldMINORpmdUnusedPrivateMethodMAJORpmdCloseResourceMAJORpmdAvoidCatchingThrowableCRITICALpmdEmptyWhileStmtCRITICALpmdCollapsibleIfStatementsMINORpmdUselessOperationOnImmutableCRITICALpmdCloneMethodMustImplementCloneableMAJORpmdUselessOverridingMethodMAJORpmdUnusedModifierINFOpmdPreserveStackTraceMAJORpmdUseArraysAsListMAJORpmdEmptyIfStmtCRITICALpmdEqualsNullCRITICALpmdBrokenNullCheckCRITICALpmdUseCorrectExceptionLoggingMAJORpmdInefficientStringBufferingMAJORpmdArrayIsStoredDirectlyCRITICALpmdFinalizeOverloadedMAJORpmdClassNamingConventionsMAJORpmdDontImportSunMINORpmdDontImportJavaLangMINORpmdMissingStaticMethodInNonInstantiatableClassMAJORpmdStringBufferInstantiationWithCharMAJORpmdUseArrayListInsteadOfVectorMAJORpmdWhileLoopsMustUseBracesMAJORpmdStringToStringMAJORpmdSimplifyConditionalMAJORpmdReplaceVectorWithListMAJORpmdNcssMethodCountMAJORminimum50pmdAvoidPrintStackTraceMAJORpmdMethodWithSameNameAsEnclosingClassMAJORpmdSuspiciousConstantFieldNameMAJORpmdNcssTypeCountMAJORminimum800pmdAvoidInstanceofChecksInCatchClauseMINORpmdEmptyFinallyBlockCRITICALpmdIntegerInstantiationMAJORpmdAvoidDollarSignsMINORpmdAvoidAssertAsIdentifierMAJORpmdUnnecessaryLocalBeforeReturnMAJORpmdAvoidCallingFinalizeMAJORpmdBooleanInstantiationMAJORpmdUnconditionalIfStatementCRITICALpmdCloneThrowsCloneNotSupportedExceptionMAJORpmdReplaceHashtableWithMapMAJORpmdAvoidDecimalLiteralsInBigDecimalConstructorMAJORpmdForLoopsMustUseBracesMAJORpmdEmptyTryBlockMAJORpmdEmptyFinalizerMAJORpmdIdempotentOperationsMAJORpmdExceptionAsFlowControlMAJORpmdEmptyStaticInitializerMAJORpmdFinalizeDoesNotCallSuperFinalizeMAJORpmdUseStringBufferLengthMINORpmdAvoidEnumAsIdentifierMAJORpmdIfElseStmtsMustUseBracesMAJORpmdSystemPrintlnMAJORpmdUselessStringValueOfMINORpmdAvoidDuplicateLiteralsMAJORfindbugsSA_LOCAL_SELF_COMPARISONCRITICALfindbugsUG_SYNC_SET_UNSYNC_GETMAJORfindbugsIC_SUPERCLASS_USES_SUBCLASS_DURING_INITIALIZATIONMAJORfindbugsNM_FIELD_NAMING_CONVENTIONMAJORfindbugsBC_IMPOSSIBLE_DOWNCASTCRITICALfindbugsSA_FIELD_SELF_COMPUTATIONCRITICALfindbugsEQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THISMAJORfindbugsTQ_MAYBE_SOURCE_VALUE_REACHES_NEVER_SINKCRITICALfindbugsNO_NOTIFY_NOT_NOTIFYALLCRITICALfindbugsVA_FORMAT_STRING_BAD_ARGUMENTCRITICALfindbugsUPM_UNCALLED_PRIVATE_METHODCRITICALfindbugsSF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGHCRITICALfindbugsEQ_COMPARETO_USE_OBJECT_EQUALSCRITICALfindbugsLI_LAZY_INIT_UPDATE_STATICCRITICALfindbugsDMI_THREAD_PASSED_WHERE_RUNNABLE_EXPECTEDMAJORfindbugsSE_NONLONG_SERIALVERSIONIDMAJORfindbugsODR_OPEN_DATABASE_RESOURCECRITICALfindbugsRC_REF_COMPARISON_BAD_PRACTICEMAJORfindbugsNM_LCASE_HASHCODECRITICALfindbugsVO_VOLATILE_REFERENCE_TO_ARRAYMAJORfindbugsITA_INEFFICIENT_TO_ARRAYCRITICALfindbugsDM_NUMBER_CTORCRITICALfindbugsXSS_REQUEST_PARAMETER_TO_JSP_WRITERCRITICALfindbugsRCN_REDUNDANT_NULLCHECK_OF_NULL_VALUECRITICALfindbugsIJU_TEARDOWN_NO_SUPERCRITICALfindbugsSIC_INNER_SHOULD_BE_STATICMAJORfindbugsNM_BAD_EQUALCRITICALfindbugsDM_BOXED_PRIMITIVE_TOSTRINGMAJORfindbugsIJU_SUITE_NOT_STATICCRITICALfindbugsIM_MULTIPLYING_RESULT_OF_IREMCRITICALfindbugsHE_HASHCODE_USE_OBJECT_EQUALSCRITICALfindbugsIL_CONTAINER_ADDED_TO_ITSELFCRITICALfindbugsES_COMPARING_PARAMETER_STRING_WITH_EQMAJORfindbugsVA_FORMAT_STRING_BAD_CONVERSIONCRITICALfindbugsSR_NOT_CHECKEDMAJORfindbugsDB_DUPLICATE_SWITCH_CLAUSESCRITICALfindbugsNP_NULL_PARAM_DEREF_NONVIRTUALCRITICALfindbugsIP_PARAMETER_IS_DEAD_BUT_OVERWRITTENCRITICALfindbugsRV_RETURN_VALUE_IGNOREDMINORfindbugsRV_EXCEPTION_NOT_THROWNCRITICALfindbugsDP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGEDMAJORfindbugsCO_SELF_NO_OBJECTMAJORfindbugsMS_MUTABLE_ARRAYMAJORfindbugsDM_CONVERT_CASEINFOfindbugsINT_VACUOUS_COMPARISONCRITICALfindbugsUW_UNCOND_WAITMAJORfindbugsMS_FINAL_PKGPROTECTMAJORfindbugsDL_SYNCHRONIZATION_ON_UNSHARED_BOXED_PRIMITIVECRITICALfindbugsNP_BOOLEAN_RETURN_NULLMAJORfindbugsTQ_MAYBE_SOURCE_VALUE_REACHES_ALWAYS_SINKCRITICALfindbugsDMI_RANDOM_USED_ONLY_ONCECRITICALfindbugsDM_GCMAJORfindbugsBX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCIONMAJORfindbugsBIT_SIGNED_CHECK_HIGH_BITCRITICALfindbugsDE_MIGHT_DROPMAJORfindbugsDL_SYNCHRONIZATION_ON_BOXED_PRIMITIVECRITICALfindbugsRV_DONT_JUST_NULL_CHECK_READLINEMAJORfindbugsRV_CHECK_FOR_POSITIVE_INDEXOFMINORfindbugsDMI_USELESS_SUBSTRINGCRITICALfindbugsURF_UNREAD_FIELDMAJORfindbugsNP_NULL_INSTANCEOFCRITICALfindbugsDM_MONITOR_WAIT_ON_CONDITIONMAJORfindbugsTQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINKCRITICALfindbugsMS_PKGPROTECTMAJORfindbugsNP_LOAD_OF_KNOWN_NULL_VALUECRITICALfindbugsEQ_OVERRIDING_EQUALS_NOT_SYMMETRICMAJORfindbugsSWL_SLEEP_WITH_LOCK_HELDCRITICALfindbugsEC_UNRELATED_INTERFACESCRITICALfindbugsDM_FP_NUMBER_CTORMAJORfindbugsFI_PUBLIC_SHOULD_BE_PROTECTEDMAJORfindbugsSTI_INTERRUPTED_ON_CURRENTTHREADCRITICALfindbugsSE_COMPARATOR_SHOULD_BE_SERIALIZABLEMAJORfindbugsDMI_BAD_MONTHCRITICALfindbugsBIT_SIGNED_CHECKCRITICALfindbugsDE_MIGHT_IGNOREMAJORfindbugsIJU_SETUP_NO_SUPERCRITICALfindbugsEQ_OTHER_NO_OBJECTMAJORfindbugsFI_MISSING_SUPER_CALLMAJORfindbugsSQL_BAD_PREPARED_STATEMENT_ACCESSCRITICALfindbugsNP_NONNULL_PARAM_VIOLATIONCRITICALfindbugsEQ_UNUSUALMINORfindbugsFI_EMPTYMAJORfindbugsNP_CLOSING_NULLCRITICALfindbugsNN_NAKED_NOTIFYCRITICALfindbugsSE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASSMAJOR \ No newline at end of file -- GitLab