sonar checking，但大都无关痛痒

sonar 也升级到3.2, 主要改变是findbugs升级到2.0了, 规则改动不算大

examples/quickstart/src/main/java/org/springside/examples/quickstart/web/task/TaskController.java

@@ -38,9 +38,6 @@ import com.google.common.collect.Maps;
 @RequestMapping(value = "/task")
 public class TaskController {
 
-	@Autowired
-	private TaskService taskService;
-
 	private static final int PAGE_SIZE = 3;
 
 	private static Map<String, String> sortTypes = Maps.newLinkedHashMap();
@@ -49,6 +46,9 @@ public class TaskController {
 		sortTypes.put("title", "标题");
 	}
 
+	@Autowired
+	private TaskService taskService;
+
 	@RequestMapping(method = RequestMethod.GET)
 	public String list(@RequestParam(value = "sortType", defaultValue = "auto") String sortType,
 			@RequestParam(value = "page", defaultValue = "1") int pageNumber, Model model) {

examples/showcase/src/main/java/org/springside/examples/showcase/demos/utilities/collection/AdvancedMapDemo.java

@@ -43,13 +43,13 @@ public class AdvancedMapDemo {
 	 * Guava的BiMap，可随时调转Key与Value.
 	 */
 	@Test
-	public void BiMap() {
+	public void biMap() {
 		BiMap<Integer, String> bimap = HashBiMap.create();
 		bimap.put(1, "a");
 		bimap.put(2, "b");
 
 		BiMap<String, Integer> bimap2 = bimap.inverse();
-		assertEquals(new Integer(2), bimap2.get("b"));
+		assertEquals(Integer.valueOf(2), bimap2.get("b"));
 	}
 
 	/*

examples/showcase/src/main/java/org/springside/examples/showcase/demos/utilities/dozer/DozerDemo.java

@@ -35,7 +35,7 @@ public class DozerDemo {
 
 		assertEquals("car", product.getProductName());
 		//原来的字符串被Map成Double。
-		assertEquals(new Double(200), product.getPrice());
+		assertEquals(Double.valueOf(200), product.getPrice());
 		//原来的PartDTO同样被Map成Part ,Array被Map成List
 		assertEquals("door", product.getParts().get(0).getName());
 		//Part中循环依赖的Product同样被赋值。
@@ -73,9 +73,9 @@ public class DozerDemo {
 		//原来的horse，被替换成car
 		assertEquals("car", product.getProductName());
 		//原来的20的属性被覆盖成200，同样被从字符串被专为Double。
-		assertEquals(new Double(200), product.getPrice());
+		assertEquals(Double.valueOf(200), product.getPrice());
 		//DTO中没有的属性值,在Product中被保留
-		assertEquals(new Double(20), product.getWeight());
+		assertEquals(Double.valueOf(20), product.getWeight());
 		//Part中循环依赖的Product同样被赋值。
 		assertEquals("car", product.getParts().get(0).getProduct().getProductName());
 	}

examples/showcase/src/main/java/org/springside/examples/showcase/demos/utilities/json/JsonDemo.java

@@ -29,7 +29,6 @@ import com.fasterxml.jackson.annotation.JsonPropertyOrder;
 import com.fasterxml.jackson.annotation.JsonView;
 import com.fasterxml.jackson.core.JsonGenerator;
 import com.fasterxml.jackson.core.JsonParser;
-import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.DeserializationContext;
 import com.fasterxml.jackson.databind.JavaType;
 import com.fasterxml.jackson.databind.JsonMappingException;
@@ -320,7 +319,7 @@ public class JsonDemo {
 	public static enum TestEnum {
 		One(1), Two(2), Three(3);
 
-		private int index;
+		private final int index;
 
 		TestEnum(int index) {
 			this.index = index;
@@ -512,7 +511,7 @@ public class JsonDemo {
 		// 固定属性
 		private String name;
 		// 扩展属性
-		private Map<String, String> properties = Maps.newHashMap();
+		private final Map<String, String> properties = Maps.newHashMap();
 
 		public ExtensibleBean() {
 		}
@@ -625,7 +624,7 @@ public class JsonDemo {
 
 		//from
 		User resultUser = newMapper.fromJson(jsonString, User.class);
-		assertEquals(new Double(1.2), resultUser.getSalary().value);
+		assertEquals(Double.valueOf(1.2), resultUser.getSalary().value);
 
 	}
 
@@ -635,8 +634,7 @@ public class JsonDemo {
 		}
 
 		@Override
-		public void serialize(Money value, JsonGenerator jgen, SerializerProvider provider) throws IOException,
-				JsonProcessingException {
+		public void serialize(Money value, JsonGenerator jgen, SerializerProvider provider) throws IOException {
 
 			jgen.writeString(value.toString());
 		}
@@ -648,15 +646,14 @@ public class JsonDemo {
 		}
 
 		@Override
-		public Money deserialize(JsonParser jp, DeserializationContext ctxt) throws IOException,
-				JsonProcessingException {
+		public Money deserialize(JsonParser jp, DeserializationContext ctxt) throws IOException {
 			return Money.valueOf(jp.getText());
 		}
 
 	}
 
 	public static class Money {
-		private Double value;
+		private final Double value;
 
 		public Money(Double value) {
 			this.value = value;

examples/showcase/src/main/java/org/springside/examples/showcase/repository/mybatis/TeamMybatisDao.java

@@ -11,5 +11,5 @@ import org.springside.examples.showcase.entity.Team;
 @MyBatisRepository
 public interface TeamMybatisDao {
 
-	public Team getWithDetail(Long id);
+	Team getWithDetail(Long id);
 }

examples/showcase/src/main/java/org/springside/examples/showcase/repository/mybatis/UserMybatisDao.java

@@ -14,12 +14,11 @@ import org.springside.examples.showcase.entity.User;
 @MyBatisRepository
 public interface UserMybatisDao {
 
-	public User get(Long id);
+	User get(Long id);
 
-	public List<User> search(Map<String, Object> parameters);
+	List<User> search(Map<String, Object> parameters);
 
-	public void save(User user);
-
-	public void delete(Long id);
+	void save(User user);
 
+	void delete(Long id);
 }

examples/showcase/src/main/java/org/springside/examples/showcase/web/UserController.java

@@ -30,9 +30,6 @@ import com.google.common.collect.Maps;
 @RequestMapping(value = "/account/user")
 public class UserController {
 
-	@Autowired
-	private AccountService accountService;
-
 	private static Map<String, String> allStatus = Maps.newHashMap();
 
 	static {
@@ -40,6 +37,9 @@ public class UserController {
 		allStatus.put("disabled", "无效");
 	}
 
+	@Autowired
+	private AccountService accountService;
+
 	//特别设定多个ReuireRoles之间为Or关系，而不是默认的And.
 	@RequiresRoles(value = { "Admin", "User" }, logical = Logical.OR)
 	@RequestMapping(value = "")

modules/core/src/main/java/org/springside/modules/mapper/JaxbMapper.java

@@ -35,7 +35,7 @@ import org.springside.modules.utils.Reflections;
  */
 public class JaxbMapper {
 
-	private static final ConcurrentMap<Class, JAXBContext> jaxbContexts = new ConcurrentHashMap<Class, JAXBContext>();
+	private static ConcurrentMap<Class, JAXBContext> jaxbContexts = new ConcurrentHashMap<Class, JAXBContext>();
 
 	/**
 	 * Java Object->Xml without encoding.

modules/core/src/main/java/org/springside/modules/security/shiro/HasAnyPermissionsTag.java

@@ -10,6 +10,7 @@ import org.apache.shiro.web.tags.PermissionTag;
  */
 public class HasAnyPermissionsTag extends PermissionTag {
 
+	private static final long serialVersionUID = -4786931833148680306L;
 	private static final String PERMISSION_NAMES_DELIMETER = ",";
 
 	@Override

modules/core/src/main/java/org/springside/modules/utils/Reflections.java

@@ -30,8 +30,7 @@ public class Reflections {
 
 	private static final String GETTER_PREFIX = "get";
 
-	/** The CGLIB class separator character "$$" */
-	public static final String CGLIB_CLASS_SEPARATOR = "$$";
+	private static final String CGLIB_CLASS_SEPARATOR = "$$";
 
 	private static Logger logger = LoggerFactory.getLogger(Reflections.class);
 
@@ -45,7 +44,6 @@ public class Reflections {
 
 	/**
 	 * 调用Setter方法, 仅匹配方法名。
-	 * 
 	 */
 	public static void invokeSetter(Object obj, String propertyName, Object value) {
 		String setterMethodName = SETTER_PREFIX + StringUtils.capitalize(propertyName);

modules/core/src/main/java/org/springside/modules/web/taglib/BSCheckboxesTag.java

@@ -7,6 +7,8 @@ import org.springframework.web.servlet.tags.form.TagWriter;
 
 public class BSCheckboxesTag extends BSAbstractMultiCheckedElementTag {
 
+	private static final long serialVersionUID = 4310358928301706621L;
+
 	@Override
 	protected int writeTagContent(TagWriter tagWriter) throws JspException {
 		super.writeTagContent(tagWriter);

modules/core/src/main/java/org/springside/modules/web/taglib/BSRadioButtonsTag.java

 package org.springside.modules.web.taglib;
 
 public class BSRadioButtonsTag extends BSAbstractMultiCheckedElementTag {
+	private static final long serialVersionUID = 6257615872362092808L;
+
 	@Override
 	protected String getInputType() {
 		return "radio";

support/sonar/springside-checkstyle.xml

-<?xml version="1.0" encoding="UTF-8"?><!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.2//EN" "http://www.puppycrawl.com/dtds/configuration_1_2.dtd"><!-- Generated by Sonar --><module name="Checker"><module name="SuppressionCommentFilter"/><module name="TreeWalker"><module name="FileContentsHolder"/> <module name="CyclomaticComplexity"><property name="severity" value="warning"/><property name="max" value="10"/></module><module name="ModifiedControlVariable"><property name="severity" value="warning"/></module><module name="DoubleCheckedLocking"><property name="severity" value="warning"/></module><module name="HiddenField"><property name="severity" value="warning"/><property name="tokens" value="VARIABLE_DEF"/><property name="ignoreConstructorParameter" value="true"/><property name="ignoreSetter" value="true"/><property name="ignoreAbstractMethods" value="true"/></module><module name="StringLiteralEquality"><property name="severity" value="warning"/></module><module name="NestedForDepth"><property name="severity" value="warning"/><property name="max" value="3"/></module><module name="LocalVariableName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/></module><module name="JavaNCSS"><property name="severity" value="warning"/><property name="classMaximum" value="500"/><property name="fileMaximum" value="600"/></module><module name="IllegalThrows"><property name="severity" value="warning"/></module><module name="RedundantModifier"><property name="severity" value="info"/></module><module name="AnonInnerLength"><property name="severity" value="warning"/></module><module name="StaticVariableName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/><property name="applyToPublic" value="true"/><property name="applyToProtected" value="true"/><property name="applyToPackage" value="true"/><property name="applyToPrivate" value="true"/></module><module name="DeclarationOrder"><property name="severity" value="info"/></module><module name="MethodName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/><property name="allowClassName" value="false"/></module><module name="ParameterName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/></module><module name="FinalClass"><property name="severity" value="warning"/></module><module name="OneStatementPerLine"><property name="severity" value="warning"/></module><module name="ParameterNumber"><property name="severity" value="warning"/><property name="max" value="5"/></module><module name="DefaultComesLast"><property name="severity" value="warning"/></module><module name="LocalFinalVariableName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/></module><module name="MultipleVariableDeclarations"><property name="severity" value="warning"/></module><module name="MemberName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/><property name="applyToPublic" value="true"/><property name="applyToProtected" value="true"/><property name="applyToPackage" value="true"/><property name="applyToPrivate" value="true"/></module><module name="EqualsHashCode"><property name="severity" value="error"/></module><module name="EmptyStatement"><property name="severity" value="info"/></module><module name="PackageName"><property name="severity" value="warning"/><property name="format" value="^[a-z]+(\.[a-zA-Z_][a-zA-Z0-9_]*)*$"/></module><module name="ConstantName"><property name="severity" value="info"/><property name="format" value="^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$"/><property name="applyToPublic" value="true"/><property name="applyToProtected" value="true"/><property name="applyToPackage" value="true"/><property name="applyToPrivate" value="true"/></module><module name="RedundantThrows"><property name="severity" value="info"/><property name="allowUnchecked" value="true"/></module><module name="ParameterAssignment"><property name="severity" value="warning"/></module><module name="UnusedImports"><property name="severity" value="info"/><property name="processJavadoc" value="false"/></module><module name="TodoComment"><property name="severity" value="info"/><property name="format" value="TODO"/></module><module name="SimplifyBooleanExpression"><property name="severity" value="warning"/></module><module name="SimplifyBooleanReturn"><property name="severity" value="warning"/></module><module name="ModifierOrder"><property name="severity" value="info"/></module><module name="BooleanExpressionComplexity"><property name="severity" value="warning"/></module><module name="InnerAssignment"><property name="severity" value="warning"/></module><module name="MagicNumber"><property name="severity" value="info"/><property name="ignoreHashCodeMethod" value="false"/><property name="ignoreAnnotation" value="false"/></module></module></module>
\ No newline at end of file
+<?xml version="1.0" encoding="UTF-8"?><!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.2//EN" "http://www.puppycrawl.com/dtds/configuration_1_2.dtd"><!-- Generated by Sonar --><module name="Checker"><module name="SuppressionCommentFilter"/><module name="TreeWalker"><module name="FileContentsHolder"/> <module name="CyclomaticComplexity"><property name="severity" value="warning"/><property name="max" value="10"/></module><module name="NestedIfDepth"><property name="severity" value="warning"/><property name="max" value="3"/></module><module name="DoubleCheckedLocking"><property name="severity" value="warning"/></module><module name="HiddenField"><property name="severity" value="warning"/><property name="tokens" value="VARIABLE_DEF"/><property name="ignoreConstructorParameter" value="true"/><property name="ignoreSetter" value="true"/><property name="ignoreAbstractMethods" value="true"/></module><module name="StringLiteralEquality"><property name="severity" value="warning"/></module><module name="LocalVariableName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/></module><module name="JavaNCSS"><property name="severity" value="warning"/><property name="classMaximum" value="500"/><property name="fileMaximum" value="600"/></module><module name="IllegalThrows"><property name="severity" value="warning"/></module><module name="RedundantModifier"><property name="severity" value="info"/></module><module name="AnonInnerLength"><property name="severity" value="warning"/></module><module name="StaticVariableName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/><property name="applyToPublic" value="true"/><property name="applyToProtected" value="true"/><property name="applyToPackage" value="true"/><property name="applyToPrivate" value="true"/></module><module name="DeclarationOrder"><property name="severity" value="info"/></module><module name="MethodName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/><property name="allowClassName" value="false"/></module><module name="ParameterName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/></module><module name="OneStatementPerLine"><property name="severity" value="warning"/></module><module name="ParameterNumber"><property name="severity" value="warning"/><property name="max" value="5"/></module><module name="DefaultComesLast"><property name="severity" value="warning"/></module><module name="LocalFinalVariableName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/></module><module name="MemberName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/><property name="applyToPublic" value="true"/><property name="applyToProtected" value="true"/><property name="applyToPackage" value="true"/><property name="applyToPrivate" value="true"/></module><module name="EqualsHashCode"><property name="severity" value="error"/></module><module name="EmptyStatement"><property name="severity" value="info"/></module><module name="PackageName"><property name="severity" value="warning"/><property name="format" value="^[a-z]+(\.[a-zA-Z_][a-zA-Z0-9_]*)*$"/></module><module name="ConstantName"><property name="severity" value="info"/><property name="format" value="^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$"/><property name="applyToPublic" value="true"/><property name="applyToProtected" value="true"/><property name="applyToPackage" value="true"/><property name="applyToPrivate" value="true"/></module><module name="RedundantThrows"><property name="severity" value="info"/><property name="allowUnchecked" value="true"/><property name="suppressLoadErrors" value="true"/></module><module name="ParameterAssignment"><property name="severity" value="warning"/></module><module name="UnusedImports"><property name="severity" value="info"/><property name="processJavadoc" value="false"/></module><module name="SimplifyBooleanExpression"><property name="severity" value="warning"/></module><module name="SimplifyBooleanReturn"><property name="severity" value="warning"/></module><module name="ModifierOrder"><property name="severity" value="info"/></module><module name="BooleanExpressionComplexity"><property name="severity" value="warning"/></module><module name="InnerAssignment"><property name="severity" value="warning"/></module><module name="MagicNumber"><property name="severity" value="info"/><property name="ignoreHashCodeMethod" value="false"/><property name="ignoreAnnotation" value="false"/></module></module></module>
\ No newline at end of file

support/sonar/springside-pmd.xml

@@ -255,12 +255,6 @@
   <rule ref="rulesets/strings.xml/AvoidDuplicateLiterals">
     <priority>3</priority>
   </rule>
-  <rule ref="rulesets/j2ee.xml/UseProperClassLoader">
-    <priority>2</priority>
-  </rule>
-  <rule ref="rulesets/basic.xml/MisplacedNullCheck">
-    <priority>2</priority>
-  </rule>
   <rule ref="rulesets/optimizations.xml/AddEmptyString">
     <priority>3</priority>
   </rule>
@@ -270,9 +264,15 @@
   <rule ref="rulesets/basic.xml/AvoidMultipleUnaryOperators">
     <priority>3</priority>
   </rule>
+  <rule ref="rulesets/basic.xml/MisplacedNullCheck">
+    <priority>2</priority>
+  </rule>
   <rule ref="rulesets/naming.xml/PackageCase">
     <priority>3</priority>
   </rule>
+  <rule ref="rulesets/j2ee.xml/UseProperClassLoader">
+    <priority>2</priority>
+  </rule>
   <rule ref="rulesets/basic.xml/UnnecessaryReturn">
     <priority>4</priority>
   </rule>