From ec73362a76076733ed2a987750b765e810daa996 Mon Sep 17 00:00:00 2001 From: Brian Rosner Date: Fri, 7 Aug 2009 01:20:27 -0600 Subject: [PATCH] knocked down the log method when fetching a page is problematic this has caused quite a bit of confusion by Pinax users thinking the 404s are errors. in most cases the 404s are harmless and don't prevent the installation or location of a package. if there is cause for concern in this i recommend to output something once *all* pages have been hit and all produced some sort of error. --- pip.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pip.py b/pip.py index eab855ff5..d01f0128b 100644 --- a/pip.py +++ b/pip.py @@ -2335,11 +2335,11 @@ class HTMLPage(object): except (urllib2.HTTPError, urllib2.URLError, socket.timeout, socket.error), e: desc = str(e) if isinstance(e, socket.timeout): - log_meth = logger.warn + log_meth = logger.info level =1 desc = 'timed out' elif isinstance(e, urllib2.URLError): - log_meth = logger.warn + log_meth = logger.info if hasattr(e, 'reason') and isinstance(e.reason, socket.timeout): desc = 'timed out' level = 1 @@ -2350,7 +2350,7 @@ class HTMLPage(object): log_meth = logger.info level = 2 else: - log_meth = logger.warn + log_meth = logger.info level = 1 log_meth('Could not fetch URL %s: %s' % (link, desc)) log_meth('Will skip URL %s when looking for download links for %s' % (link.url, req)) -- GitLab