From 6a4baa67d2f6e8e32f11d06f10652d2a47f9f070 Mon Sep 17 00:00:00 2001 From: kernelai Date: Mon, 21 Mar 2022 17:27:19 +0800 Subject: [PATCH] bugfix: coredump in ubuntu when it shutdown (#1151) issue: https://github.com/OpenAtomFoundation/pika/issues/1152 --- include/pika_proxy_cli.h | 1 + src/pika_proxy_cli.cc | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/include/pika_proxy_cli.h b/include/pika_proxy_cli.h index 2595d5ef..0cc3de3f 100644 --- a/include/pika_proxy_cli.h +++ b/include/pika_proxy_cli.h @@ -73,6 +73,7 @@ class ProxyCli : public std::enable_shared_from_this { std::shared_ptr resp_ptr; }; void LostConn(const std::string& ip_port); + ~ProxyCli(); private: int cron_interval_; diff --git a/src/pika_proxy_cli.cc b/src/pika_proxy_cli.cc index c5ffb860..3da34625 100644 --- a/src/pika_proxy_cli.cc +++ b/src/pika_proxy_cli.cc @@ -47,8 +47,6 @@ int ProxyCli::Start() { int ProxyCli::Stop() { client_ptr_->StopThread(); - delete proxy_factory_; - delete proxy_handle_; return pink::kSuccess; } @@ -154,3 +152,7 @@ void ProxyCli::LostConn(const std::string& ip_port) { delete proxy_task; } } +ProxyCli::~ProxyCli() { + delete proxy_factory_; + delete proxy_handle_; +} -- GitLab